diff mbox

[2/3] EXYNOS5: Add device node for USB.

Message ID 1354541409-9642-3-git-send-email-rajeshwari.s@samsung.com
State New
Headers show

Commit Message

Rajeshwari Shinde Dec. 3, 2012, 1:30 p.m. UTC
This patch adds the device node required for USB

Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
---
 arch/arm/dts/exynos5250.dtsi |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

Comments

Simon Glass Dec. 12, 2012, 2:38 p.m. UTC | #1
Hi Rajeshwari,

On Mon, Dec 3, 2012 at 5:30 AM, Rajeshwari Shinde
<rajeshwari.s@samsung.com> wrote:
> This patch adds the device node required for USB
>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> ---
>  arch/arm/dts/exynos5250.dtsi |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/dts/exynos5250.dtsi b/arch/arm/dts/exynos5250.dtsi
> index e8ecf3f..dd2c6ac 100644
> --- a/arch/arm/dts/exynos5250.dtsi
> +++ b/arch/arm/dts/exynos5250.dtsi
> @@ -127,4 +127,10 @@
>                 clock-frequency = <50000000>;
>                 interrupts = <0 70 0>;
>          };
> +
> +       ehci@12110000 {
> +               compatible = "samsung,exynos-ehci";
> +               reg = <0x12110000 0x100>;
> +               phyreg = <0x12130000>;

I think this last thing is a phy, but perhaps it should be written out
as a sub-node, something like:

> +       ehci@12110000 {
> +               compatible = "samsung,exynos-ehci";
> +               reg = <0x12110000 0x100>;
> +               phy {
                        compatible = "samsung,exynos-usb-phy";
                        reg = <0x12130000 0xsomething>;
                    }

If you copy your patch to devicetree-discuss you might get some ideas.

> +       };
>  };
> --
> 1.7.4.4
>

Regards,
Simon
diff mbox

Patch

diff --git a/arch/arm/dts/exynos5250.dtsi b/arch/arm/dts/exynos5250.dtsi
index e8ecf3f..dd2c6ac 100644
--- a/arch/arm/dts/exynos5250.dtsi
+++ b/arch/arm/dts/exynos5250.dtsi
@@ -127,4 +127,10 @@ 
 		clock-frequency = <50000000>;
 		interrupts = <0 70 0>;
         };
+
+	ehci@12110000 {
+		compatible = "samsung,exynos-ehci";
+		reg = <0x12110000 0x100>;
+		phyreg = <0x12130000>;
+	};
 };