| Message ID | 1303386420-12997-1-git-send-email-j.weitzel@phytec.de |
|---|---|
| State | New |
| Headers | show |
On 04/21/2011 12:47 PM, Somebody in the thread at some point said: > Without OMAP_I2C_FLAG_RESET_REGS_POSTIDLE I got i2c controller > timeouts on each accsess after an NACK message. > Taking this flag fix it. Ahhh that will explain why if you accidentally configure LM75 system monitor support, which isn't there on Panda, the I2C controllers die slowly on boot. Good catch! -Andy
Am Donnerstag, den 21.04.2011, 13:13 +0100 schrieb Andy Green: > On 04/21/2011 12:47 PM, Somebody in the thread at some point said: > > Without OMAP_I2C_FLAG_RESET_REGS_POSTIDLE I got i2c controller > > timeouts on each accsess after an NACK message. > > Taking this flag fix it. > > Ahhh that will explain why if you accidentally configure LM75 system > monitor support, which isn't there on Panda, the I2C controllers die > slowly on boot. Good catch! Can I get an Acked-by ? Jan
On 05/16/2011 09:56 AM, Somebody in the thread at some point said: > Am Donnerstag, den 21.04.2011, 13:13 +0100 schrieb Andy Green: >> On 04/21/2011 12:47 PM, Somebody in the thread at some point said: >>> Without OMAP_I2C_FLAG_RESET_REGS_POSTIDLE I got i2c controller >>> timeouts on each accsess after an NACK message. >>> Taking this flag fix it. >> >> Ahhh that will explain why if you accidentally configure LM75 system >> monitor support, which isn't there on Panda, the I2C controllers die >> slowly on boot. Good catch! > > Can I get an Acked-by ? Sure, I had it on my tree for a while too. Tested-by: Andy Green <andy.green@linaro.org> Acked-by: Andy Green <andy.green@linaro.org> -Andy
diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c index 5f4a1b2..3d3b4f4 100644 --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c @@ -2130,7 +2130,8 @@ static struct omap_hwmod_class omap44xx_i2c_hwmod_class = { }; static struct omap_i2c_dev_attr i2c_dev_attr = { - .flags = OMAP_I2C_FLAG_BUS_SHIFT_NONE, + .flags = OMAP_I2C_FLAG_BUS_SHIFT_NONE | + OMAP_I2C_FLAG_RESET_REGS_POSTIDLE, }; /* i2c1 */
Without OMAP_I2C_FLAG_RESET_REGS_POSTIDLE I got i2c controller timeouts on each accsess after an NACK message. Taking this flag fix it. This patch is on top of the i2c feature implementation flags patches Signed-off-by: Jan Weitzel <j.weitzel@phytec.de> --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)