| Message ID | 1431688090-2145-2-git-send-email-fu.wei@linaro.org |
|---|---|
| State | New |
| Headers | show |
Hi Arnd, Great thanks, np, will do so On 15 May 2015 at 22:06, Arnd Bergmann <arnd@arndb.de> wrote: > On Friday 15 May 2015 19:08:05 fu.wei@linaro.org wrote: >> From: Fu Wei <fu.wei@linaro.org> >> >> The sbsa-gwdt.txt documentation in devicetree/bindings/watchdog is for >> introducing SBSA(Server Base System Architecture) Generic Watchdog >> device node info into FDT >> >> Signed-off-by: Fu Wei <fu.wei@linaro.org> > > Looks good, just one minor comment: > >> +Optional properties >> +- timeout-sec : Watchdog pre-timeout and timeout values (in seconds). >> + The first is timeout values, then pre-timeout. > > Please update Documentation/watchdog/watchdog-kernel-api.txt as well, to > mention the second number in the timeout-sec property. > > Arnd > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Arnd, Great thanks for reminding, I should do it earlier. You will see it in next patchset. On 05/15/2015 10:06 PM, Arnd Bergmann wrote: > On Friday 15 May 2015 19:08:05 fu.wei@linaro.org wrote: >> From: Fu Wei <fu.wei@linaro.org> >> >> The sbsa-gwdt.txt documentation in devicetree/bindings/watchdog is for >> introducing SBSA(Server Base System Architecture) Generic Watchdog >> device node info into FDT >> >> Signed-off-by: Fu Wei <fu.wei@linaro.org> > > Looks good, just one minor comment: > >> +Optional properties >> +- timeout-sec : Watchdog pre-timeout and timeout values (in seconds). >> + The first is timeout values, then pre-timeout. > > Please update Documentation/watchdog/watchdog-kernel-api.txt as well, to > mention the second number in the timeout-sec property. > > Arnd > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
diff --git a/Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt b/Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt new file mode 100644 index 0000000..bd1768d --- /dev/null +++ b/Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt @@ -0,0 +1,36 @@ +* SBSA(Server Base System Architecture) Generic Watchdog + +The SBSA Generic Watchdog Timer is used for resetting the system after +two stages of timeout. +More details: ARM-DEN-0029 - Server Base System Architecture (SBSA) + +Required properties: +- compatible : Should at least contain "arm,sbsa-gwdt". + +- reg : base physical address of the frames and length of memory mapped region. + +- reg-names : Should contain the resource reg names to show the order of + the values in "reg". + Must include the following entries : "refresh", "control". + +- interrupts : Should at least contain WS0 interrupt, + the WS1 Signal is optional. + +- interrupt-names : Should contain the resource interrupt names. + Must include the following entries : "ws0". "ws1" is optional. + +Optional properties +- timeout-sec : Watchdog pre-timeout and timeout values (in seconds). + The first is timeout values, then pre-timeout. + +Example for FVP Foundation Model v8: + +watchdog@2a450000 { + compatible = "arm,sbsa-gwdt"; + reg = <0x0 0x2a450000 0 0x10000>, + <0x0 0x2a440000 0 0x10000>; + reg-names = "refresh", "control"; + interrupts = <0 27 4>; + interrupt-names = "ws0"; + timeout-sec = <10 5>; +};