| Message ID | 1441708283-29002-2-git-send-email-maxim.uvarov@linaro.org |
|---|---|
| State | New |
| Headers | show |
Maxim, Could you please clarify. I expect that after patch adding some implementation should build. If you adding new API it doesn't have impact. But if API is modified, probably that project has build problem. This patch, can have examples/validations in one patch in order to allow every patch to build. linux-generic changes can exist separately as it's implementation specific. What do you say? On 08.09.15 13:31, Maxim Uvarov wrote: > Use full default word in api to make function > name more clear. > https://bugs.linaro.org/show_bug.cgi?id=1745 > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> > --- > include/odp/api/cpumask.h | 4 ++-- > platform/linux-generic/odp_cpumask_task.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/odp/api/cpumask.h b/include/odp/api/cpumask.h > index 2ad7fea..4835a6c 100644 > --- a/include/odp/api/cpumask.h > +++ b/include/odp/api/cpumask.h > @@ -203,7 +203,7 @@ int odp_cpumask_next(const odp_cpumask_t *mask, int cpu); > * @param num Number of worker threads, zero for all available CPUs > * @return Actual number of CPUs used to create the mask > */ > -int odp_cpumask_def_worker(odp_cpumask_t *mask, int num); > +int odp_cpumask_default_worker(odp_cpumask_t *mask, int num); > > /** > * Default cpumask for control threads > @@ -215,7 +215,7 @@ int odp_cpumask_def_worker(odp_cpumask_t *mask, int num); > * @param num Number of control threads, zero for all available CPUs > * @return Actual number of CPUs used to create the mask > */ > -int odp_cpumask_def_control(odp_cpumask_t *mask, int num); > +int odp_cpumask_default_control(odp_cpumask_t *mask, int num); > > /** > * @} > diff --git a/platform/linux-generic/odp_cpumask_task.c b/platform/linux-generic/odp_cpumask_task.c > index 665e82a..535891c 100644 > --- a/platform/linux-generic/odp_cpumask_task.c > +++ b/platform/linux-generic/odp_cpumask_task.c > @@ -13,7 +13,7 @@ > #include <odp/cpumask.h> > #include <odp_debug_internal.h> > > -int odp_cpumask_def_worker(odp_cpumask_t *mask, int num) > +int odp_cpumask_default_worker(odp_cpumask_t *mask, int num) > { > int ret, cpu, i; > cpu_set_t cpuset; > @@ -43,7 +43,7 @@ int odp_cpumask_def_worker(odp_cpumask_t *mask, int num) > return cpu; > } > > -int odp_cpumask_def_control(odp_cpumask_t *mask, int num ODP_UNUSED) > +int odp_cpumask_default_control(odp_cpumask_t *mask, int num ODP_UNUSED) > { > odp_cpumask_zero(mask); > /* By default all control threads on CPU 0 */ >
On 09/08/15 13:55, Ivan Khoronzhuk wrote: > Maxim, > Could you please clarify. > > I expect that after patch adding some implementation should build. > If you adding new API it doesn't have impact. > But if API is modified, probably that project has build problem. > This patch, can have examples/validations in one patch in order to > allow every patch to build. > linux-generic changes can exist separately as it's implementation > specific. > What do you say? > On merge I'm going to concatenate patches 1/4 and 2/4 to one single patch. For review it might be easy to review separately api change and renames in implementation. I planned to write about that in cover latter. But can also send v2. Maxim. > On 08.09.15 13:31, Maxim Uvarov wrote: >> Use full default word in api to make function >> name more clear. >> https://bugs.linaro.org/show_bug.cgi?id=1745 >> >> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> >> --- >> include/odp/api/cpumask.h | 4 ++-- >> platform/linux-generic/odp_cpumask_task.c | 4 ++-- >> 2 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/include/odp/api/cpumask.h b/include/odp/api/cpumask.h >> index 2ad7fea..4835a6c 100644 >> --- a/include/odp/api/cpumask.h >> +++ b/include/odp/api/cpumask.h >> @@ -203,7 +203,7 @@ int odp_cpumask_next(const odp_cpumask_t *mask, >> int cpu); >> * @param num Number of worker threads, zero for all >> available CPUs >> * @return Actual number of CPUs used to create the mask >> */ >> -int odp_cpumask_def_worker(odp_cpumask_t *mask, int num); >> +int odp_cpumask_default_worker(odp_cpumask_t *mask, int num); >> >> /** >> * Default cpumask for control threads >> @@ -215,7 +215,7 @@ int odp_cpumask_def_worker(odp_cpumask_t *mask, >> int num); >> * @param num Number of control threads, zero for all >> available CPUs >> * @return Actual number of CPUs used to create the mask >> */ >> -int odp_cpumask_def_control(odp_cpumask_t *mask, int num); >> +int odp_cpumask_default_control(odp_cpumask_t *mask, int num); >> >> /** >> * @} >> diff --git a/platform/linux-generic/odp_cpumask_task.c >> b/platform/linux-generic/odp_cpumask_task.c >> index 665e82a..535891c 100644 >> --- a/platform/linux-generic/odp_cpumask_task.c >> +++ b/platform/linux-generic/odp_cpumask_task.c >> @@ -13,7 +13,7 @@ >> #include <odp/cpumask.h> >> #include <odp_debug_internal.h> >> >> -int odp_cpumask_def_worker(odp_cpumask_t *mask, int num) >> +int odp_cpumask_default_worker(odp_cpumask_t *mask, int num) >> { >> int ret, cpu, i; >> cpu_set_t cpuset; >> @@ -43,7 +43,7 @@ int odp_cpumask_def_worker(odp_cpumask_t *mask, int >> num) >> return cpu; >> } >> >> -int odp_cpumask_def_control(odp_cpumask_t *mask, int num ODP_UNUSED) >> +int odp_cpumask_default_control(odp_cpumask_t *mask, int num >> ODP_UNUSED) >> { >> odp_cpumask_zero(mask); >> /* By default all control threads on CPU 0 */ >> >
On 08.09.15 14:03, Maxim Uvarov wrote: > On 09/08/15 13:55, Ivan Khoronzhuk wrote: >> Maxim, >> Could you please clarify. >> >> I expect that after patch adding some implementation should build. >> If you adding new API it doesn't have impact. >> But if API is modified, probably that project has build problem. >> This patch, can have examples/validations in one patch in order to allow every patch to build. >> linux-generic changes can exist separately as it's implementation specific. >> What do you say? >> > > On merge I'm going to concatenate patches 1/4 and 2/4 to one single patch. For review it might > be easy to review separately api change and renames in implementation. I planned to write about > that in cover latter. But can also send v2. > > Maxim. I just wanted to clarify if it has some other sense. It can require to be squashed for checking in some cases If it's going to be squashed it's OK. > > >> On 08.09.15 13:31, Maxim Uvarov wrote: >>> Use full default word in api to make function >>> name more clear. >>> https://bugs.linaro.org/show_bug.cgi?id=1745 >>> >>> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> >>> --- >>> include/odp/api/cpumask.h | 4 ++-- >>> platform/linux-generic/odp_cpumask_task.c | 4 ++-- >>> 2 files changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/include/odp/api/cpumask.h b/include/odp/api/cpumask.h >>> index 2ad7fea..4835a6c 100644 >>> --- a/include/odp/api/cpumask.h >>> +++ b/include/odp/api/cpumask.h >>> @@ -203,7 +203,7 @@ int odp_cpumask_next(const odp_cpumask_t *mask, int cpu); >>> * @param num Number of worker threads, zero for all available CPUs >>> * @return Actual number of CPUs used to create the mask >>> */ >>> -int odp_cpumask_def_worker(odp_cpumask_t *mask, int num); >>> +int odp_cpumask_default_worker(odp_cpumask_t *mask, int num); >>> >>> /** >>> * Default cpumask for control threads >>> @@ -215,7 +215,7 @@ int odp_cpumask_def_worker(odp_cpumask_t *mask, int num); >>> * @param num Number of control threads, zero for all available CPUs >>> * @return Actual number of CPUs used to create the mask >>> */ >>> -int odp_cpumask_def_control(odp_cpumask_t *mask, int num); >>> +int odp_cpumask_default_control(odp_cpumask_t *mask, int num); >>> >>> /** >>> * @} >>> diff --git a/platform/linux-generic/odp_cpumask_task.c b/platform/linux-generic/odp_cpumask_task.c >>> index 665e82a..535891c 100644 >>> --- a/platform/linux-generic/odp_cpumask_task.c >>> +++ b/platform/linux-generic/odp_cpumask_task.c >>> @@ -13,7 +13,7 @@ >>> #include <odp/cpumask.h> >>> #include <odp_debug_internal.h> >>> >>> -int odp_cpumask_def_worker(odp_cpumask_t *mask, int num) >>> +int odp_cpumask_default_worker(odp_cpumask_t *mask, int num) >>> { >>> int ret, cpu, i; >>> cpu_set_t cpuset; >>> @@ -43,7 +43,7 @@ int odp_cpumask_def_worker(odp_cpumask_t *mask, int num) >>> return cpu; >>> } >>> >>> -int odp_cpumask_def_control(odp_cpumask_t *mask, int num ODP_UNUSED) >>> +int odp_cpumask_default_control(odp_cpumask_t *mask, int num ODP_UNUSED) >>> { >>> odp_cpumask_zero(mask); >>> /* By default all control threads on CPU 0 */ >>> >> >
diff --git a/include/odp/api/cpumask.h b/include/odp/api/cpumask.h index 2ad7fea..4835a6c 100644 --- a/include/odp/api/cpumask.h +++ b/include/odp/api/cpumask.h @@ -203,7 +203,7 @@ int odp_cpumask_next(const odp_cpumask_t *mask, int cpu); * @param num Number of worker threads, zero for all available CPUs * @return Actual number of CPUs used to create the mask */ -int odp_cpumask_def_worker(odp_cpumask_t *mask, int num); +int odp_cpumask_default_worker(odp_cpumask_t *mask, int num); /** * Default cpumask for control threads @@ -215,7 +215,7 @@ int odp_cpumask_def_worker(odp_cpumask_t *mask, int num); * @param num Number of control threads, zero for all available CPUs * @return Actual number of CPUs used to create the mask */ -int odp_cpumask_def_control(odp_cpumask_t *mask, int num); +int odp_cpumask_default_control(odp_cpumask_t *mask, int num); /** * @} diff --git a/platform/linux-generic/odp_cpumask_task.c b/platform/linux-generic/odp_cpumask_task.c index 665e82a..535891c 100644 --- a/platform/linux-generic/odp_cpumask_task.c +++ b/platform/linux-generic/odp_cpumask_task.c @@ -13,7 +13,7 @@ #include <odp/cpumask.h> #include <odp_debug_internal.h> -int odp_cpumask_def_worker(odp_cpumask_t *mask, int num) +int odp_cpumask_default_worker(odp_cpumask_t *mask, int num) { int ret, cpu, i; cpu_set_t cpuset; @@ -43,7 +43,7 @@ int odp_cpumask_def_worker(odp_cpumask_t *mask, int num) return cpu; } -int odp_cpumask_def_control(odp_cpumask_t *mask, int num ODP_UNUSED) +int odp_cpumask_default_control(odp_cpumask_t *mask, int num ODP_UNUSED) { odp_cpumask_zero(mask); /* By default all control threads on CPU 0 */
Use full default word in api to make function name more clear. https://bugs.linaro.org/show_bug.cgi?id=1745 Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> --- include/odp/api/cpumask.h | 4 ++-- platform/linux-generic/odp_cpumask_task.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)