| Message ID | 1445213365-24530-2-git-send-email-alexey.klimov@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
On Mon, 2015-10-19 at 03:09 +0300, Alexey Klimov wrote: > 1) Change pr_warn()s to pr_err()s. These messages are actually > errors and not warnings. > 2) Add missing \n. > 3) Error message for kzalloc() failure is removed per suggestion > by Joe Perches. There is generic stack_dump() for allocation issues. Some of the braces around single statements could also be removed. > diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c > index ca5ea9e..ac92ca2 100644 > @@ -184,7 +184,6 @@ static void __init mtk_timer_init(struct device_node *node) > > evt = kzalloc(sizeof(*evt), GFP_KERNEL); > if (!evt) { > - pr_warn("Can't allocate mtk clock event driver struct"); > return; > } could be written: evt = kzalloc(sizeof(*evt), GFP_KERNEL); if (!evt) return; etc... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c index ca5ea9e..ac92ca2 100644 --- a/drivers/clocksource/mtk_timer.c +++ b/drivers/clocksource/mtk_timer.c @@ -184,7 +184,6 @@ static void __init mtk_timer_init(struct device_node *node) evt = kzalloc(sizeof(*evt), GFP_KERNEL); if (!evt) { - pr_warn("Can't allocate mtk clock event driver struct"); return; } @@ -200,24 +199,24 @@ static void __init mtk_timer_init(struct device_node *node) evt->gpt_base = of_io_request_and_map(node, 0, "mtk-timer"); if (IS_ERR(evt->gpt_base)) { - pr_warn("Can't get resource\n"); + pr_err("Can't get resource\n"); return; } evt->dev.irq = irq_of_parse_and_map(node, 0); if (evt->dev.irq <= 0) { - pr_warn("Can't parse IRQ"); + pr_err("Can't parse IRQ\n"); goto err_mem; } clk = of_clk_get(node, 0); if (IS_ERR(clk)) { - pr_warn("Can't get timer clock"); + pr_err("Can't get timer clock\n"); goto err_irq; } if (clk_prepare_enable(clk)) { - pr_warn("Can't prepare clock"); + pr_err("Can't prepare clock\n"); goto err_clk_put; } rate = clk_get_rate(clk); @@ -226,7 +225,7 @@ static void __init mtk_timer_init(struct device_node *node) if (request_irq(evt->dev.irq, mtk_timer_interrupt, IRQF_TIMER | IRQF_IRQPOLL, "mtk_timer", evt)) { - pr_warn("failed to setup irq %d\n", evt->dev.irq); + pr_err("failed to setup irq %d\n", evt->dev.irq); goto err_clk_disable; }
1) Change pr_warn()s to pr_err()s. These messages are actually errors and not warnings. 2) Add missing \n. 3) Error message for kzalloc() failure is removed per suggestion by Joe Perches. There is generic stack_dump() for allocation issues. Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org> --- drivers/clocksource/mtk_timer.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)