| Message ID | 1376938761-13657-3-git-send-email-markus.mayer@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Mon, Aug 19, 2013 at 8:59 PM, Markus Mayer <markus.mayer@linaro.org> wrote: > This patch adds the Kconfig and Makefile glue to compile the GPIO > driver for bcm281xx when CONFIG_GPIO_BCM=y. > > Signed-off-by: Markus Mayer <markus.mayer@linaro.org> > Reviewed-by: Tim Kryger <tim.kryger@linaro.org> > Reviewed-by: Matt Porter <matt.porter@linaro.org> (...) > +++ b/arch/arm/mach-bcm/Kconfig > @@ -9,7 +9,6 @@ config ARCH_BCM > select CLKSRC_OF > select GENERIC_CLOCKEVENTS > select GENERIC_TIME > - select GPIO_BCM select GPIO_BCM_KONA > select SPARSE_IRQ > select TICK_ONESHOT > help > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > index b2450ba..869e234 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -714,6 +714,13 @@ config GPIO_MSIC > Enable support for GPIO on intel MSIC controllers found in > intel MID devices > > +config GPIO_BCM_KONA > + bool "Broadcom Kona GPIO" > + depends on ARCH_BCM > + default y I prefer that you do not depend on ARCH_BCM and do not encode default y, but select it in the arch instead. That way some other system can test-compile it for example. Which should work fine. And when that can be done, some of the good kernel proofreaders and janitors will make a deep review some day. Yours, Linus Walleij
diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig index f112895..2dfbf06 100644 --- a/arch/arm/mach-bcm/Kconfig +++ b/arch/arm/mach-bcm/Kconfig @@ -9,7 +9,6 @@ config ARCH_BCM select CLKSRC_OF select GENERIC_CLOCKEVENTS select GENERIC_TIME - select GPIO_BCM select SPARSE_IRQ select TICK_ONESHOT help diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index b2450ba..869e234 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -714,6 +714,13 @@ config GPIO_MSIC Enable support for GPIO on intel MSIC controllers found in intel MID devices +config GPIO_BCM_KONA + bool "Broadcom Kona GPIO" + depends on ARCH_BCM + default y + help + Turn on GPIO support for Broadcom "Kona" chips. + comment "USB GPIO expanders:" config GPIO_VIPERBOARD diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile index ef3e983..fcd0751 100644 --- a/drivers/gpio/Makefile +++ b/drivers/gpio/Makefile @@ -16,6 +16,7 @@ obj-$(CONFIG_GPIO_ADP5520) += gpio-adp5520.o obj-$(CONFIG_GPIO_ADP5588) += gpio-adp5588.o obj-$(CONFIG_GPIO_AMD8111) += gpio-amd8111.o obj-$(CONFIG_GPIO_ARIZONA) += gpio-arizona.o +obj-$(CONFIG_GPIO_BCM_KONA) += gpio-bcm-kona.o obj-$(CONFIG_GPIO_BT8XX) += gpio-bt8xx.o obj-$(CONFIG_GPIO_CLPS711X) += gpio-clps711x.o obj-$(CONFIG_GPIO_CS5535) += gpio-cs5535.o