| Message ID | 6d8d406ebca886e5147191cc8c333d926ef9eb30.1379063063.git.viresh.kumar@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Fri, Sep 13, 2013 at 06:30:52PM +0530, Viresh Kumar wrote: > Many common initializations of struct policy are moved to core now and hence > this driver doesn't need to do it. This patch removes such code. > > Most recent of those changes is to call ->get() in the core after calling > ->init(). > > Cc: Russell King <linux@arm.linux.org.uk> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > drivers/cpufreq/integrator-cpufreq.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/cpufreq/integrator-cpufreq.c b/drivers/cpufreq/integrator-cpufreq.c > index 8152a9b..babf3e4 100644 > --- a/drivers/cpufreq/integrator-cpufreq.c > +++ b/drivers/cpufreq/integrator-cpufreq.c > @@ -181,10 +181,9 @@ static int integrator_cpufreq_init(struct cpufreq_policy *policy) > { > > /* set default policy and cpuinfo */ > - policy->cpuinfo.max_freq = 160000; > - policy->cpuinfo.min_freq = 12000; > + policy->max = policy->cpuinfo.max_freq = 160000; > + policy->min = policy->cpuinfo.min_freq = 12000; > policy->cpuinfo.transition_latency = 1000000; /* 1 ms, assumed */ > - policy->cur = policy->min = policy->max = integrator_get(policy->cpu); This patch actually changes things - the description is misleading. Please explain why this change - which results in different values for policy->min and policy->max doesn't cause any functional difference. Thanks.
On 13 September 2013 21:40, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote: > This patch actually changes things - the description is misleading. > Please explain why this change - which results in different values for > policy->min and policy->max doesn't cause any functional difference. Yeah, see if below log looks correct (patch attached): Subject: [PATCH 106/228] cpufreq: integrator: don't initialize part of policy that is set by core too Many common initializations of struct policy are moved to core now and hence this driver doesn't need to do it. This patch removes such code. Most recent of those changes is to call ->get() in the core after calling ->init(). And so we don't need to set policy->cur from driver anymore. Over that it sets policy->min and max correctly. They were earlier set to current frequency of CPU but they should be set to max and min freq of cpu. Cc: Russell King <linux@arm.linux.org.uk> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/cpufreq/integrator-cpufreq.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/cpufreq/integrator-cpufreq.c b/drivers/cpufreq/integrator-cpufreq.c index 8152a9b..babf3e4 100644 --- a/drivers/cpufreq/integrator-cpufreq.c +++ b/drivers/cpufreq/integrator-cpufreq.c @@ -181,10 +181,9 @@ static int integrator_cpufreq_init(struct cpufreq_policy *policy) { /* set default policy and cpuinfo */ - policy->cpuinfo.max_freq = 160000; - policy->cpuinfo.min_freq = 12000; + policy->max = policy->cpuinfo.max_freq = 160000; + policy->min = policy->cpuinfo.min_freq = 12000; policy->cpuinfo.transition_latency = 1000000; /* 1 ms, assumed */ - policy->cur = policy->min = policy->max = integrator_get(policy->cpu); return 0; }
Many common initializations of struct policy are moved to core now and hence this driver doesn't need to do it. This patch removes such code. Most recent of those changes is to call ->get() in the core after calling ->init(). Cc: Russell King <linux@arm.linux.org.uk> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/cpufreq/integrator-cpufreq.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)