| Message ID | 524F1684.8070804@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
> If we are running on a Linux platform we should call linux_init_abi > in order to get all the useful hooks it enables. > > gdb/ChangeLog: > > 2013-10-04 Will Newton <will.newton@linaro.org> > > * aarch64-linux-tdep.c (aarch64_linux_init_abi): Call > linux_init_abi. This makes sense to me, and it's actually what the 32bit side of the code is already doing. OK to apply. It'd be nice also if you could confirm that this patch was tested prior to submitting, and how it affects the testsuite results. This often helps future research...
On 7 October 2013 06:02, Joel Brobecker <brobecker@adacore.com> wrote: >> If we are running on a Linux platform we should call linux_init_abi >> in order to get all the useful hooks it enables. >> >> gdb/ChangeLog: >> >> 2013-10-04 Will Newton <will.newton@linaro.org> >> >> * aarch64-linux-tdep.c (aarch64_linux_init_abi): Call >> linux_init_abi. > > This makes sense to me, and it's actually what the 32bit side of > the code is already doing. OK to apply. I'll wait a couple of days to see if anyone from ARM objects. > It'd be nice also if you could confirm that this patch was tested > prior to submitting, and how it affects the testsuite results. > This often helps future research... The patch was tested manually to check that things like "info proc maps" now works. The testsuite is in pretty bad shape on aarch64 but no new failures are added.
On 7 October 2013 08:36, Will Newton <will.newton@linaro.org> wrote: > On 7 October 2013 06:02, Joel Brobecker <brobecker@adacore.com> wrote: >>> If we are running on a Linux platform we should call linux_init_abi >>> in order to get all the useful hooks it enables. >>> >>> gdb/ChangeLog: >>> >>> 2013-10-04 Will Newton <will.newton@linaro.org> >>> >>> * aarch64-linux-tdep.c (aarch64_linux_init_abi): Call >>> linux_init_abi. >> >> This makes sense to me, and it's actually what the 32bit side of >> the code is already doing. OK to apply. > > I'll wait a couple of days to see if anyone from ARM objects. > >> It'd be nice also if you could confirm that this patch was tested >> prior to submitting, and how it affects the testsuite results. >> This often helps future research... > > The patch was tested manually to check that things like "info proc > maps" now works. The testsuite is in pretty bad shape on aarch64 but > no new failures are added. I applied this as there were no objections.
diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c index 8e66425..bcfcce2 100644 --- a/gdb/aarch64-linux-tdep.c +++ b/gdb/aarch64-linux-tdep.c @@ -270,6 +270,8 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) tdep->lowest_pc = 0x8000; + linux_init_abi (info, gdbarch); + set_solib_svr4_fetch_link_map_offsets (gdbarch, svr4_lp64_fetch_link_map_offsets);