| Message ID | 20161207194325.19472-1-mike.holmes@linaro.org |
|---|---|
| State | Accepted |
| Commit | d660e0e1647d7f1a6c6698b6f1b79b4590b84e1f |
| Headers | show |
For this series: Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org> On Wed, Dec 7, 2016 at 1:43 PM, Mike Holmes <mike.holmes@linaro.org> wrote: > Signed-off-by: Mike Holmes <mike.holmes@linaro.org> > --- > configure.ac | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/configure.ac b/configure.ac > index 3e89b0a..543f535 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -254,6 +254,8 @@ AC_ARG_ENABLE([abi-compat], > ODP_ABI_COMPAT=0 > abi_compat=no > enable_shared=no > + #if there is no API compatibility the .so numbers are meaningless > + ODP_LIBSO_VERSION=0:0:0 > fi]) > AC_SUBST(ODP_ABI_COMPAT) > > -- > 2.9.3 >
> -----Original Message----- > From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of Mike > Holmes > Sent: Wednesday, December 07, 2016 9:43 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH 1/2] configure: if no ABI reset .so to 0 > > Signed-off-by: Mike Holmes <mike.holmes@linaro.org> > --- > configure.ac | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/configure.ac b/configure.ac > index 3e89b0a..543f535 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -254,6 +254,8 @@ AC_ARG_ENABLE([abi-compat], > ODP_ABI_COMPAT=0 > abi_compat=no > enable_shared=no > + #if there is no API compatibility the .so numbers are meaningless Typo: API => ABI -Petri > + ODP_LIBSO_VERSION=0:0:0 > fi]) > AC_SUBST(ODP_ABI_COMPAT) > > -- > 2.9.3
Thanks Petri Maxim can you fix typo on commit ? On 8 December 2016 at 02:32, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolainen@nokia-bell-labs.com> wrote: > > > > -----Original Message----- > > From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of > Mike > > Holmes > > Sent: Wednesday, December 07, 2016 9:43 PM > > To: lng-odp@lists.linaro.org > > Subject: [lng-odp] [PATCH 1/2] configure: if no ABI reset .so to 0 > > > > Signed-off-by: Mike Holmes <mike.holmes@linaro.org> > > --- > > configure.ac | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/configure.ac b/configure.ac > > index 3e89b0a..543f535 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -254,6 +254,8 @@ AC_ARG_ENABLE([abi-compat], > > ODP_ABI_COMPAT=0 > > abi_compat=no > > enable_shared=no > > + #if there is no API compatibility the .so numbers are meaningless > > Typo: API => ABI > > -Petri > > > + ODP_LIBSO_VERSION=0:0:0 > > fi]) > > AC_SUBST(ODP_ABI_COMPAT) > > > > -- > > 2.9.3 > > -- Mike Holmes Program Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs "Work should be fun and collaborative, the rest follows"
On 12/08/16 18:58, Mike Holmes wrote: > Thanks Petri > > Maxim can you fix typo on commit ? > yes, will fix. > On 8 December 2016 at 02:32, Savolainen, Petri (Nokia - FI/Espoo) < > petri.savolainen@nokia-bell-labs.com> wrote: > >> >> >>> -----Original Message----- >>> From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of >> Mike >>> Holmes >>> Sent: Wednesday, December 07, 2016 9:43 PM >>> To: lng-odp@lists.linaro.org >>> Subject: [lng-odp] [PATCH 1/2] configure: if no ABI reset .so to 0 >>> >>> Signed-off-by: Mike Holmes <mike.holmes@linaro.org> >>> --- >>> configure.ac | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/configure.ac b/configure.ac >>> index 3e89b0a..543f535 100644 >>> --- a/configure.ac >>> +++ b/configure.ac >>> @@ -254,6 +254,8 @@ AC_ARG_ENABLE([abi-compat], >>> ODP_ABI_COMPAT=0 >>> abi_compat=no >>> enable_shared=no >>> + #if there is no API compatibility the .so numbers are meaningless >> >> Typo: API => ABI >> >> -Petri >> >>> + ODP_LIBSO_VERSION=0:0:0 >>> fi]) >>> AC_SUBST(ODP_ABI_COMPAT) >>> >>> -- >>> 2.9.3 >> >> > >
Merged with fix. Maxim. On 12/08/16 18:58, Mike Holmes wrote: > Thanks Petri > > Maxim can you fix typo on commit ? > > On 8 December 2016 at 02:32, Savolainen, Petri (Nokia - FI/Espoo) < > petri.savolainen@nokia-bell-labs.com> wrote: > >> >> >>> -----Original Message----- >>> From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of >> Mike >>> Holmes >>> Sent: Wednesday, December 07, 2016 9:43 PM >>> To: lng-odp@lists.linaro.org >>> Subject: [lng-odp] [PATCH 1/2] configure: if no ABI reset .so to 0 >>> >>> Signed-off-by: Mike Holmes <mike.holmes@linaro.org> >>> --- >>> configure.ac | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/configure.ac b/configure.ac >>> index 3e89b0a..543f535 100644 >>> --- a/configure.ac >>> +++ b/configure.ac >>> @@ -254,6 +254,8 @@ AC_ARG_ENABLE([abi-compat], >>> ODP_ABI_COMPAT=0 >>> abi_compat=no >>> enable_shared=no >>> + #if there is no API compatibility the .so numbers are meaningless >> >> Typo: API => ABI >> >> -Petri >> >>> + ODP_LIBSO_VERSION=0:0:0 >>> fi]) >>> AC_SUBST(ODP_ABI_COMPAT) >>> >>> -- >>> 2.9.3 >> >> > >
diff --git a/configure.ac b/configure.ac index 3e89b0a..543f535 100644 --- a/configure.ac +++ b/configure.ac @@ -254,6 +254,8 @@ AC_ARG_ENABLE([abi-compat], ODP_ABI_COMPAT=0 abi_compat=no enable_shared=no + #if there is no API compatibility the .so numbers are meaningless + ODP_LIBSO_VERSION=0:0:0 fi]) AC_SUBST(ODP_ABI_COMPAT)
Signed-off-by: Mike Holmes <mike.holmes@linaro.org> --- configure.ac | 2 ++ 1 file changed, 2 insertions(+) -- 2.9.3