| Message ID | 1483102054-1752-10-git-send-email-ulf.hansson@linaro.org |
|---|---|
| State | New |
| Headers | show |
Hi Ulf, On 12/30/2016 13:47, Ulf Hansson wrote: > Don't rely on host.h to include the mmc.h header, but instead include it > explicitly because the driver depends on it. You refer in description to header file (mmc.h) not related to this patch. > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > drivers/mmc/host/sdhci.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h > index 0b66f21..a10a7b6 100644 > --- a/drivers/mmc/host/sdhci.h > +++ b/drivers/mmc/host/sdhci.h > @@ -17,6 +17,7 @@ > #include <linux/compiler.h> > #include <linux/types.h> > #include <linux/io.h> > +#include <linux/leds.h> > > #include <linux/mmc/host.h> > > Regards, Mateusz. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Dec 30, 2016 at 1:47 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote: > Don't rely on host.h to include the mmc.h header, but instead include it > explicitly because the driver depends on it. > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> As noted, the commit message is bogus. Refer to <linux/leds.h> With that: Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 30/12/16 14:47, Ulf Hansson wrote: > Don't rely on host.h to include the mmc.h header, but instead include it > explicitly because the driver depends on it. > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Apart from commit message: Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > drivers/mmc/host/sdhci.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h > index 0b66f21..a10a7b6 100644 > --- a/drivers/mmc/host/sdhci.h > +++ b/drivers/mmc/host/sdhci.h > @@ -17,6 +17,7 @@ > #include <linux/compiler.h> > #include <linux/types.h> > #include <linux/io.h> > +#include <linux/leds.h> > > #include <linux/mmc/host.h> > > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 30 December 2016 at 14:35, Mateusz Nowak <mateusz.nowak@linux.intel.com> wrote: > Hi Ulf, > > On 12/30/2016 13:47, Ulf Hansson wrote: >> >> Don't rely on host.h to include the mmc.h header, but instead include it >> explicitly because the driver depends on it. > > You refer in description to header file (mmc.h) not related to this patch. Ahh, copy/paste error. Thanks, for reviewing! Kind regards Uffe > >> >> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> >> --- >> drivers/mmc/host/sdhci.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h >> index 0b66f21..a10a7b6 100644 >> --- a/drivers/mmc/host/sdhci.h >> +++ b/drivers/mmc/host/sdhci.h >> @@ -17,6 +17,7 @@ >> #include <linux/compiler.h> >> #include <linux/types.h> >> #include <linux/io.h> >> +#include <linux/leds.h> >> >> #include <linux/mmc/host.h> >> >> > > Regards, > Mateusz. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h index 0b66f21..a10a7b6 100644 --- a/drivers/mmc/host/sdhci.h +++ b/drivers/mmc/host/sdhci.h @@ -17,6 +17,7 @@ #include <linux/compiler.h> #include <linux/types.h> #include <linux/io.h> +#include <linux/leds.h> #include <linux/mmc/host.h>
Don't rely on host.h to include the mmc.h header, but instead include it explicitly because the driver depends on it. Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> --- drivers/mmc/host/sdhci.h | 1 + 1 file changed, 1 insertion(+) -- 1.9.1