diff mbox series

[4/5] travis: do not post codecov tests for not official repo

Message ID 20170214203202.13342-5-maxim.uvarov@linaro.org
State New
Headers show
Series various travis updates | expand

Commit Message

Maxim Uvarov Feb. 14, 2017, 8:32 p.m. UTC
Github may allow administrators in Linaro github group post
codecov from their local repositories. That happens if
same token is used for personal git and Linaro group. There is
one small side affect that history of tests fill web page of
Linaro official project. To make history more clean post codecov
results only for main repo.

Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>

---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.11.0.295.gd7dffce

Comments

Mike Holmes Feb. 16, 2017, 4:11 p.m. UTC | #1
On 14 February 2017 at 15:32, Maxim Uvarov <maxim.uvarov@linaro.org> wrote:

> Github may allow administrators in Linaro github group post

> codecov from their local repositories. That happens if

> same token is used for personal git and Linaro group. There is

> one small side affect that history of tests fill web page of

> Linaro official project. To make history more clean post codecov

> results only for main repo.

>

> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>

>


I am not yet convinced that this is needed, some simple tests I have done
where I replace the Hash for the main ODP to which I am also admin with my
private codcov hash have not resulted in the  upstream repo getting touched


> ---

>  .travis.yml | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/.travis.yml b/.travis.yml

> index 1ab943fe..ef9c3283 100644

> --- a/.travis.yml

> +++ b/.travis.yml

> @@ -133,7 +133,7 @@ script:

>          - sudo rm -rf $KSRC

>

>  after_success:

> -  - if [ -n "$DOCOV" ]; then find . -type f -iname '*.[ch]' -not -path

> ".git/*" -execdir gcov {} \; ; bash <(curl -s https://codecov.io/bash) -X

> coveragepy; fi

> +  - if [ -n "$DOCOV" ] && [ "$TRAVIS_REPO_SLUG" = "Linaro/odp" ]; then

> find . -type f -iname '*.[ch]' -not -path ".git/*" -execdir gcov {} \; ;

> bash <(curl -s https://codecov.io/bash) -X coveragepy; fi

>

>  addons:

>      coverity_scan:

> --

> 2.11.0.295.gd7dffce

>

>



-- 
Mike Holmes
Program Manager - Linaro Networking Group
Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
"Work should be fun and collaborative, the rest follows"
Maxim Uvarov Feb. 16, 2017, 7:11 p.m. UTC | #2
On 02/16/17 19:11, Mike Holmes wrote:
> 

> 

> On 14 February 2017 at 15:32, Maxim Uvarov <maxim.uvarov@linaro.org

> <mailto:maxim.uvarov@linaro.org>> wrote:

> 

>     Github may allow administrators in Linaro github group post

>     codecov from their local repositories. That happens if

>     same token is used for personal git and Linaro group. There is

>     one small side affect that history of tests fill web page of

>     Linaro official project. To make history more clean post codecov

>     results only for main repo.

> 

>     Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org

>     <mailto:maxim.uvarov@linaro.org>>

> 

> 

> I am not yet convinced that this is needed, some simple tests I have

> done where I replace the Hash for the main ODP to which I am also admin

> with my private codcov hash have not resulted in the  upstream repo

> getting touched

>  


Codecov needed to be run on each commit and pull request in main repo.
Do you have other idea how to do it?

Maxim.

> 

>     ---

>      .travis.yml | 2 +-

>      1 file changed, 1 insertion(+), 1 deletion(-)

> 

>     diff --git a/.travis.yml b/.travis.yml

>     index 1ab943fe..ef9c3283 100644

>     --- a/.travis.yml

>     +++ b/.travis.yml

>     @@ -133,7 +133,7 @@ script:

>              - sudo rm -rf $KSRC

> 

>      after_success:

>     -  - if [ -n "$DOCOV" ]; then find . -type f -iname '*.[ch]' -not

>     -path ".git/*" -execdir gcov {} \; ; bash <(curl -s

>     https://codecov.io/bash) -X coveragepy; fi

>     +  - if [ -n "$DOCOV" ] && [ "$TRAVIS_REPO_SLUG" = "Linaro/odp" ];

>     then find . -type f -iname '*.[ch]' -not -path ".git/*" -execdir

>     gcov {} \; ; bash <(curl -s https://codecov.io/bash) -X coveragepy; fi

> 

>      addons:

>          coverity_scan:

>     --

>     2.11.0.295.gd7dffce

> 

> 

> 

> 

> -- 

> Mike Holmes

> Program Manager - Linaro Networking Group

> Linaro.org <http://www.linaro.org/>* **│ *Open source software for ARM SoCs

> "Work should be fun and collaborative, the rest follows"

> 

> __

> 

>
Mike Holmes Feb. 16, 2017, 7:21 p.m. UTC | #3
On 16 February 2017 at 14:11, Maxim Uvarov <maxim.uvarov@linaro.org> wrote:

> On 02/16/17 19:11, Mike Holmes wrote:

> >

> >

> > On 14 February 2017 at 15:32, Maxim Uvarov <maxim.uvarov@linaro.org

> > <mailto:maxim.uvarov@linaro.org>> wrote:

> >

> >     Github may allow administrators in Linaro github group post

> >     codecov from their local repositories. That happens if

> >     same token is used for personal git and Linaro group. There is

> >     one small side affect that history of tests fill web page of

> >     Linaro official project. To make history more clean post codecov

> >     results only for main repo.

> >

> >     Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org

> >     <mailto:maxim.uvarov@linaro.org>>

> >

> >

> > I am not yet convinced that this is needed, some simple tests I have

> > done where I replace the Hash for the main ODP to which I am also admin

> > with my private codcov hash have not resulted in the  upstream repo

> > getting touched

> >

>

> Codecov needed to be run on each commit and pull request in main repo.

> Do you have other idea how to do it?

>


I might be miss understand the problem you are solving, lets sync on a HO
and check, it will be easier than a mail description



> Maxim.

>

> >

> >     ---

> >      .travis.yml | 2 +-

> >      1 file changed, 1 insertion(+), 1 deletion(-)

> >

> >     diff --git a/.travis.yml b/.travis.yml

> >     index 1ab943fe..ef9c3283 100644

> >     --- a/.travis.yml

> >     +++ b/.travis.yml

> >     @@ -133,7 +133,7 @@ script:

> >              - sudo rm -rf $KSRC

> >

> >      after_success:

> >     -  - if [ -n "$DOCOV" ]; then find . -type f -iname '*.[ch]' -not

> >     -path ".git/*" -execdir gcov {} \; ; bash <(curl -s

> >     https://codecov.io/bash) -X coveragepy; fi

> >     +  - if [ -n "$DOCOV" ] && [ "$TRAVIS_REPO_SLUG" = "Linaro/odp" ];

> >     then find . -type f -iname '*.[ch]' -not -path ".git/*" -execdir

> >     gcov {} \; ; bash <(curl -s https://codecov.io/bash) -X coveragepy;

> fi

> >

> >      addons:

> >          coverity_scan:

> >     --

> >     2.11.0.295.gd7dffce

> >

> >

> >

> >

> > --

> > Mike Holmes

> > Program Manager - Linaro Networking Group

> > Linaro.org <http://www.linaro.org/>* **│ *Open source software for ARM

> SoCs

> > "Work should be fun and collaborative, the rest follows"

> >

> > __

> >

> >

>

>



-- 
Mike Holmes
Program Manager - Linaro Networking Group
Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
"Work should be fun and collaborative, the rest follows"
diff mbox series

Patch

diff --git a/.travis.yml b/.travis.yml
index 1ab943fe..ef9c3283 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -133,7 +133,7 @@  script:
         - sudo rm -rf $KSRC
 
 after_success:
-  - if [ -n "$DOCOV" ]; then find . -type f -iname '*.[ch]' -not -path ".git/*" -execdir gcov {} \; ; bash <(curl -s https://codecov.io/bash) -X coveragepy; fi
+  - if [ -n "$DOCOV" ] && [ "$TRAVIS_REPO_SLUG" = "Linaro/odp" ]; then find . -type f -iname '*.[ch]' -not -path ".git/*" -execdir gcov {} \; ; bash <(curl -s https://codecov.io/bash) -X coveragepy; fi
 
 addons:
     coverity_scan: