| Message ID | 20170209153403.9730-9-linus.walleij@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | multiqueue for MMC/SD third try | expand |
On Thursday, February 09, 2017 04:33:55 PM Linus Walleij wrote: > The host context member "is_new_req" is only assigned values, > never checked. Delete it. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index fcb40ade9b82..933a4d1f20d5 100644 --- a/drivers/mmc/core/core.c +++ b/drivers/mmc/core/core.c @@ -2985,7 +2985,6 @@ void mmc_unregister_pm_notifier(struct mmc_host *host) */ void mmc_init_context_info(struct mmc_host *host) { - host->context_info.is_new_req = false; host->context_info.is_waiting_last_req = false; } diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c index 73250ed8f093..63927ffd6825 100644 --- a/drivers/mmc/core/queue.c +++ b/drivers/mmc/core/queue.c @@ -66,7 +66,6 @@ static int mmc_queue_thread(void *d) req = blk_fetch_request(q); mq->asleep = false; cntx->is_waiting_last_req = false; - cntx->is_new_req = false; if (!req) { /* * Dispatch queue is empty so set flags for @@ -136,10 +135,6 @@ static void mmc_request_fn(struct request_queue *q) cntx = &mq->card->host->context_info; - if (cntx->is_waiting_last_req) { - cntx->is_new_req = true; - } - if (mq->asleep) wake_up_process(mq->thread); } diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h index cbb40682024a..970d7f9b1eba 100644 --- a/include/linux/mmc/host.h +++ b/include/linux/mmc/host.h @@ -194,11 +194,9 @@ struct mmc_slot { /** * mmc_context_info - synchronization details for mmc context - * @is_new_req wake up reason was new request * @is_waiting_last_req mmc context waiting for single running request */ struct mmc_context_info { - bool is_new_req; bool is_waiting_last_req; };
The host context member "is_new_req" is only assigned values, never checked. Delete it. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/mmc/core/core.c | 1 - drivers/mmc/core/queue.c | 5 ----- include/linux/mmc/host.h | 2 -- 3 files changed, 8 deletions(-) -- 2.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html