diff mbox

drivers: net: cpsw: abort init() on aneg timeout

Message ID 20170508151956.12231-1-nsekhar@ti.com
State Accepted
Commit 96d1d84c79b63e5882f09be451227f7145ea8599
Headers show

Commit Message

Sekhar Nori May 8, 2017, 3:19 p.m. UTC 
Abort CPSW driver init when auto-negotiation of link
times out. Currently, the code ignores return status
of phy_startup(), and goes ahead with network operation
(like DHCP) even though the link may be down.

Instead, abort init process if link is down or if there
is another error, so phy_startup() can easily be retried
again. This also helps quick fallback to next network interface
(like USB RNDIS) without inordinate delay.

Tested on AM571x IDK and AM335x BeagleBone black.

Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
 drivers/net/cpsw.c | 34 ++++++++++++++++++++++------------
 1 file changed, 22 insertions(+), 12 deletions(-)

Comments

Tom Rini May 8, 2017, 3:27 p.m. UTC | #1 
On Mon, May 08, 2017 at 08:49:56PM +0530, Sekhar Nori wrote:

> Abort CPSW driver init when auto-negotiation of link

> times out. Currently, the code ignores return status

> of phy_startup(), and goes ahead with network operation

> (like DHCP) even though the link may be down.

> 

> Instead, abort init process if link is down or if there

> is another error, so phy_startup() can easily be retried

> again. This also helps quick fallback to next network interface

> (like USB RNDIS) without inordinate delay.

> 

> Tested on AM571x IDK and AM335x BeagleBone black.

> 

> Signed-off-by: Sekhar Nori <nsekhar@ti.com>


Reviewed-by: Tom Rini <trini@konsulko.com>


-- 
Tom
Joe Hershberger May 30, 2017, 8:15 p.m. UTC | #2 
On Mon, May 8, 2017 at 10:19 AM, Sekhar Nori <nsekhar@ti.com> wrote:
> Abort CPSW driver init when auto-negotiation of link
> times out. Currently, the code ignores return status
> of phy_startup(), and goes ahead with network operation
> (like DHCP) even though the link may be down.
>
> Instead, abort init process if link is down or if there
> is another error, so phy_startup() can easily be retried
> again. This also helps quick fallback to next network interface
> (like USB RNDIS) without inordinate delay.
>
> Tested on AM571x IDK and AM335x BeagleBone black.
>
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Joe Hershberger June 2, 2017, 7:48 p.m. UTC | #3 
Hi Sekhar,

https://patchwork.ozlabs.org/patch/759682/ was applied to u-boot-net.git.

Thanks!
-Joe
diff mbox

Patch

diff --git a/drivers/net/cpsw.c b/drivers/net/cpsw.c
index 5fbab9e492f8..d85a25904d02 100644
--- a/drivers/net/cpsw.c
+++ b/drivers/net/cpsw.c
@@ -612,21 +612,25 @@  static void cpsw_set_slave_mac(struct cpsw_slave *slave,
 #endif
 }
 
-static void cpsw_slave_update_link(struct cpsw_slave *slave,
+static int cpsw_slave_update_link(struct cpsw_slave *slave,
 				   struct cpsw_priv *priv, int *link)
 {
 	struct phy_device *phy;
 	u32 mac_control = 0;
+	int ret = -ENODEV;
 
 	phy = priv->phydev;
-
 	if (!phy)
-		return;
+		goto out;
+
+	ret = phy_startup(phy);
+	if (ret)
+		goto out;
 
-	phy_startup(phy);
-	*link = phy->link;
+	if (link)
+		*link = phy->link;
 
-	if (*link) { /* link up */
+	if (phy->link) { /* link up */
 		mac_control = priv->data.mac_control;
 		if (phy->speed == 1000)
 			mac_control |= GIGABITEN;
@@ -637,7 +641,7 @@  static void cpsw_slave_update_link(struct cpsw_slave *slave,
 	}
 
 	if (mac_control == slave->mac_control)
-		return;
+		goto out;
 
 	if (mac_control) {
 		printf("link up on port %d, speed %d, %s duplex\n",
@@ -649,17 +653,20 @@  static void cpsw_slave_update_link(struct cpsw_slave *slave,
 
 	__raw_writel(mac_control, &slave->sliver->mac_control);
 	slave->mac_control = mac_control;
+
+out:
+	return ret;
 }
 
 static int cpsw_update_link(struct cpsw_priv *priv)
 {
-	int link = 0;
+	int ret = -ENODEV;
 	struct cpsw_slave *slave;
 
 	for_active_slave(slave, priv)
-		cpsw_slave_update_link(slave, priv, &link);
+		ret = cpsw_slave_update_link(slave, priv, NULL);
 
-	return link;
+	return ret;
 }
 
 static inline u32  cpsw_get_slave_port(struct cpsw_priv *priv, u32 slave_num)
@@ -822,7 +829,9 @@  static int _cpsw_init(struct cpsw_priv *priv, u8 *enetaddr)
 	for_active_slave(slave, priv)
 		cpsw_slave_init(slave, priv);
 
-	cpsw_update_link(priv);
+	ret = cpsw_update_link(priv);
+	if (ret)
+		goto out;
 
 	/* init descriptor pool */
 	for (i = 0; i < NUM_DESCS; i++) {
@@ -897,7 +906,8 @@  static int _cpsw_init(struct cpsw_priv *priv, u8 *enetaddr)
 		}
 	}
 
-	return 0;
+out:
+	return ret;
 }
 
 static void _cpsw_halt(struct cpsw_priv *priv)