| Message ID | 1475445239-25006-1-git-send-email-linus.walleij@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Sun, Oct 02, 2016 at 11:53:59PM +0200, Linus Walleij wrote: > After being asked to not depend on ARCH_QCOM* or similar, > unsurprisingly compilation fails on UM as it has no I/O > memory: > > drivers/built-in.o: In function `qcom_ebi2_probe': > >> drivers/bus/qcom-ebi2.c:333: undefined reference to > `devm_ioremap_resource' > > Fix this by letting the Kconfig atleast depend on HAS_IOMEM. > > Reported-by: kbuild test robot <fengguang.wu@intel.com> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Andy Gross <andy.gross@linaro.org> > Cc: linux-arm-msm@vger.kernel.org > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > ARM SoC maintainers: please apply this directly on the offending > branch, or line it up for v4.9 fixes. Applied to next/drivers. A Fixes: tag could have been nice, but it was easy to find where the offender was. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/02/2016 02:53 PM, Linus Walleij wrote: > After being asked to not depend on ARCH_QCOM* or similar, > unsurprisingly compilation fails on UM as it has no I/O > memory: We could have depends on ARCH_QCOM || COMPILE_TEST and then life is good. The HAS_IOMEM would of course stick around for compile testing. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Monday, October 3, 2016 12:04:00 PM CEST Stephen Boyd wrote: > On 10/02/2016 02:53 PM, Linus Walleij wrote: > > After being asked to not depend on ARCH_QCOM* or similar, > > unsurprisingly compilation fails on UM as it has no I/O > > memory: > > We could have depends on ARCH_QCOM || COMPILE_TEST and then life is > good. The HAS_IOMEM would of course stick around for compile testing. Agreed, that would be nice also since most x86 don't want to see the Kconfig option unless they set COMPILE_TEST. Note that COMPILE_TEST now depends on !UML, so we don't have to worry about that any more. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig index 5a2d47c71525..7010dcac9328 100644 --- a/drivers/bus/Kconfig +++ b/drivers/bus/Kconfig @@ -110,6 +110,7 @@ config OMAP_OCP2SCP config QCOM_EBI2 bool "Qualcomm External Bus Interface 2 (EBI2)" + depends on HAS_IOMEM help Say y here to enable support for the Qualcomm External Bus Interface 2, which can be used to connect things like NAND Flash,