| Message ID | 1504317191-3257-1-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | 2aca29557d54dbce6b563eed62f2188640cef29e |
| Headers | show |
| Series | ARM: socfpga: remove unneeded NAND config options | expand |
On 09/02/2017 03:53 AM, Masahiro Yamada wrote: > CONFIG_NAND_DENALI select's CONFIG_SYS_NAND_SELF_INIT, so the > NAND initialization process is driven by the driver itself. > CONFIG_SYS_NAND_MAX_CHIPS and CONFIG_SYS_NAND_BASE are unused. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Acked-by: Marek Vasut <marex@denx.de> Is this for -master or for -next ? > --- > > include/configs/socfpga_common.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h > index 175b01ef84a9..4f64c3281e42 100644 > --- a/include/configs/socfpga_common.h > +++ b/include/configs/socfpga_common.h > @@ -144,12 +144,10 @@ > */ > #ifdef CONFIG_NAND_DENALI > #define CONFIG_SYS_MAX_NAND_DEVICE 1 > -#define CONFIG_SYS_NAND_MAX_CHIPS 1 > #define CONFIG_SYS_NAND_ONFI_DETECTION > #define CONFIG_NAND_DENALI_ECC_SIZE 512 > #define CONFIG_SYS_NAND_REGS_BASE SOCFPGA_NANDREGS_ADDRESS > #define CONFIG_SYS_NAND_DATA_BASE SOCFPGA_NANDDATA_ADDRESS > -#define CONFIG_SYS_NAND_BASE (CONFIG_SYS_NAND_DATA_BASE + 0x10) > #endif > > /* >
Hi Marek. 2017-09-02 18:23 GMT+09:00 Marek Vasut <marex@denx.de>: > On 09/02/2017 03:53 AM, Masahiro Yamada wrote: >> CONFIG_NAND_DENALI select's CONFIG_SYS_NAND_SELF_INIT, so the >> NAND initialization process is driven by the driver itself. >> CONFIG_SYS_NAND_MAX_CHIPS and CONFIG_SYS_NAND_BASE are unused. >> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > Acked-by: Marek Vasut <marex@denx.de> > > Is this for -master or for -next ? > It is up to you, but no need to rush for this patch. It will just reduce the source file size.
On 09/02/2017 04:18 PM, Masahiro Yamada wrote: > Hi Marek. Hello Masahiro, > 2017-09-02 18:23 GMT+09:00 Marek Vasut <marex@denx.de>: >> On 09/02/2017 03:53 AM, Masahiro Yamada wrote: >>> CONFIG_NAND_DENALI select's CONFIG_SYS_NAND_SELF_INIT, so the >>> NAND initialization process is driven by the driver itself. >>> CONFIG_SYS_NAND_MAX_CHIPS and CONFIG_SYS_NAND_BASE are unused. >>> >>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> >> >> Acked-by: Marek Vasut <marex@denx.de> >> >> Is this for -master or for -next ? >> > > > It is up to you, > but no need to rush for this patch. > It will just reduce the source file size. OK, I doubt anyone really uses the Denali NAND on SoCFPGA now anyway. Applied, thanks.
diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h index 175b01ef84a9..4f64c3281e42 100644 --- a/include/configs/socfpga_common.h +++ b/include/configs/socfpga_common.h @@ -144,12 +144,10 @@ */ #ifdef CONFIG_NAND_DENALI #define CONFIG_SYS_MAX_NAND_DEVICE 1 -#define CONFIG_SYS_NAND_MAX_CHIPS 1 #define CONFIG_SYS_NAND_ONFI_DETECTION #define CONFIG_NAND_DENALI_ECC_SIZE 512 #define CONFIG_SYS_NAND_REGS_BASE SOCFPGA_NANDREGS_ADDRESS #define CONFIG_SYS_NAND_DATA_BASE SOCFPGA_NANDDATA_ADDRESS -#define CONFIG_SYS_NAND_BASE (CONFIG_SYS_NAND_DATA_BASE + 0x10) #endif /*
CONFIG_NAND_DENALI select's CONFIG_SYS_NAND_SELF_INIT, so the NAND initialization process is driven by the driver itself. CONFIG_SYS_NAND_MAX_CHIPS and CONFIG_SYS_NAND_BASE are unused. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- include/configs/socfpga_common.h | 2 -- 1 file changed, 2 deletions(-)