| Message ID | 20171009120302.23611-3-dmurphy@ti.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3,1/3] net: phy: Remove TI DP83822 from DP83848 driver | expand |
On 10/09/2017 05:03 AM, Dan Murphy wrote: > Change the return error code to EINVAL if the MAC > address is not valid in the set_wol function. Looks fine to me, since you are respining, do you mind using "net: phy: at803x: Change error to EINVAL for invalid MAC" as a subject to further specify what this is about? Thanks! > > Signed-off-by: Dan Murphy <dmurphy@ti.com> > --- > > v3 - No changes made > v2 - There was no v1 on this patch this is new. > > drivers/net/phy/at803x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c > index c1e52b9dc58d..5f93e6add563 100644 > --- a/drivers/net/phy/at803x.c > +++ b/drivers/net/phy/at803x.c > @@ -167,7 +167,7 @@ static int at803x_set_wol(struct phy_device *phydev, > mac = (const u8 *) ndev->dev_addr; > > if (!is_valid_ether_addr(mac)) > - return -EFAULT; > + return -EINVAL; > > for (i = 0; i < 3; i++) { > phy_write(phydev, AT803X_MMD_ACCESS_CONTROL, > -- Florian
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index c1e52b9dc58d..5f93e6add563 100644 --- a/drivers/net/phy/at803x.c +++ b/drivers/net/phy/at803x.c @@ -167,7 +167,7 @@ static int at803x_set_wol(struct phy_device *phydev, mac = (const u8 *) ndev->dev_addr; if (!is_valid_ether_addr(mac)) - return -EFAULT; + return -EINVAL; for (i = 0; i < 3; i++) { phy_write(phydev, AT803X_MMD_ACCESS_CONTROL,
Change the return error code to EINVAL if the MAC address is not valid in the set_wol function. Signed-off-by: Dan Murphy <dmurphy@ti.com> --- v3 - No changes made v2 - There was no v1 on this patch this is new. drivers/net/phy/at803x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.14.0