| Message ID | 20171208133535.17562-1-linus.walleij@linaro.org |
|---|---|
| State | Accepted |
| Commit | 7d42762d8cdff2974c3cfddeb480d467018f55fe |
| Headers | show |
| Series | i2c: imx: Include the right GPIO header | expand |
On Fri, Dec 8, 2017 at 11:35 AM, Linus Walleij <linus.walleij@linaro.org> wrote: > <linux/of_gpio.h> is not used in this file, by > <linux/gpio/consumer.h> is. s/by/but > > Someone is just lucky with their implicit includes. > > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Sascha Hauer <kernel@pengutronix.de> > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Other than this nit: Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
On Fri, Dec 08, 2017 at 02:35:35PM +0100, Linus Walleij wrote: > <linux/of_gpio.h> is not used in this file, by > <linux/gpio/consumer.h> is. > > Someone is just lucky with their implicit includes. > > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Sascha Hauer <kernel@pengutronix.de> > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Applied to for-next, thanks!
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index c4cf26571b66..e54a2516c036 100644 --- a/drivers/i2c/busses/i2c-imx.c +++ b/drivers/i2c/busses/i2c-imx.c @@ -37,6 +37,7 @@ #include <linux/dmapool.h> #include <linux/err.h> #include <linux/errno.h> +#include <linux/gpio/consumer.h> #include <linux/i2c.h> #include <linux/init.h> #include <linux/interrupt.h> @@ -46,7 +47,6 @@ #include <linux/of.h> #include <linux/of_device.h> #include <linux/of_dma.h> -#include <linux/of_gpio.h> #include <linux/pinctrl/consumer.h> #include <linux/platform_data/i2c-imx.h> #include <linux/platform_device.h>
<linux/of_gpio.h> is not used in this file, by <linux/gpio/consumer.h> is. Someone is just lucky with their implicit includes. Cc: Shawn Guo <shawnguo@kernel.org> Cc: Sascha Hauer <kernel@pengutronix.de> Cc: Fabio Estevam <fabio.estevam@nxp.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/i2c/busses/i2c-imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.14.3