| Message ID | 20171221124030.23721-9-maxime.ripard@free-electrons.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | sunxi: arm64 binary size fixes | expand |
Hi, On 21/12/17 12:40, Maxime Ripard wrote: > The sunXi arm64 build has overflown, leading to the main U-boot binary > overwriting the environment when flashing the new image, or even worse, > overwriting itself when we're calling saveenv. > > Disable this command that is not critical until we can adress the issue > properly. Nit: this not a command. > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> Reviewed-by: Andre Przywara <andre.przywara@arm.com> Cheers, Andre. > --- > lib/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/Kconfig b/lib/Kconfig > index f447c53bdeff..8a17a9afe10b 100644 > --- a/lib/Kconfig > +++ b/lib/Kconfig > @@ -47,6 +47,7 @@ config USE_TINY_PRINTF > > config REGEX > bool "Enable regular expression support" > + default n if ARCH_SUNXI > default y if NET > help > If this variable is defined, U-Boot is linked against the >
On Thu, Dec 21, 2017 at 9:35 PM, Andre Przywara <andre.przywara@arm.com> wrote: > Hi, > > On 21/12/17 12:40, Maxime Ripard wrote: >> The sunXi arm64 build has overflown, leading to the main U-boot binary >> overwriting the environment when flashing the new image, or even worse, >> overwriting itself when we're calling saveenv. >> >> Disable this command that is not critical until we can adress the issue >> properly. > > Nit: this not a command. > >> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > Reviewed-by: Andre Przywara <andre.przywara@arm.com> Fixed nit Applied to u-boot-sunxi/master
diff --git a/lib/Kconfig b/lib/Kconfig index f447c53bdeff..8a17a9afe10b 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -47,6 +47,7 @@ config USE_TINY_PRINTF config REGEX bool "Enable regular expression support" + default n if ARCH_SUNXI default y if NET help If this variable is defined, U-Boot is linked against the
The sunXi arm64 build has overflown, leading to the main U-boot binary overwriting the environment when flashing the new image, or even worse, overwriting itself when we're calling saveenv. Disable this command that is not critical until we can adress the issue properly. Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> --- lib/Kconfig | 1 + 1 file changed, 1 insertion(+)