| Message ID | 1519929921-1344-1-git-send-email-luis.machado@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [AArch64] Update L2 cache size on Falkor's prefetch tuning structure. | expand |
On 03/01/2018 03:45 PM, Luis Machado wrote: > Falkor's prefetch tuning structure still carries the L2 cache size value from > early support code. This patch updates it to match the specifications. > > Even though the prefetcher is currently disabled for Falkor, we have a patch > waiting for GCC development to reopen that re-enables it, so i take it this > update should be trivial enough to go in before development reopens? > > Thanks, > Luis > > 2018-03-01 Luis Machado <luis.machado@linaro.org> > > * config/aarch64/aarch64.c (qdf24xx_prefetch_tune) <l2_cache_size>: Set > to 512. > --- > gcc/config/aarch64/aarch64.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c > index 2f98a21..5a732b1 100644 > --- a/gcc/config/aarch64/aarch64.c > +++ b/gcc/config/aarch64/aarch64.c > @@ -564,7 +564,7 @@ static const cpu_prefetch_tune qdf24xx_prefetch_tune = > 4, /* num_slots */ > 32, /* l1_cache_size */ > 64, /* l1_cache_line_size */ > - 1024, /* l2_cache_size */ > + 512, /* l2_cache_size */ > -1 /* default_opt_level */ > }; > > Ping?
On Thu, Mar 01, 2018 at 06:45:21PM +0000, Luis Machado wrote: > Falkor's prefetch tuning structure still carries the L2 cache size value from > early support code. This patch updates it to match the specifications. > > Even though the prefetcher is currently disabled for Falkor, we have a patch > waiting for GCC development to reopen that re-enables it, so i take it this > update should be trivial enough to go in before development reopens? This is OK for trunk now. I'm happy for you to take the risk of the change in code-gen for qdf24xx if you are. Thanks, James > 2018-03-01 Luis Machado <luis.machado@linaro.org> > > * config/aarch64/aarch64.c (qdf24xx_prefetch_tune) <l2_cache_size>: Set > to 512. > --- > gcc/config/aarch64/aarch64.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c > index 2f98a21..5a732b1 100644 > --- a/gcc/config/aarch64/aarch64.c > +++ b/gcc/config/aarch64/aarch64.c > @@ -564,7 +564,7 @@ static const cpu_prefetch_tune qdf24xx_prefetch_tune = > 4, /* num_slots */ > 32, /* l1_cache_size */ > 64, /* l1_cache_line_size */ > - 1024, /* l2_cache_size */ > + 512, /* l2_cache_size */ > -1 /* default_opt_level */ > }; > > -- > 2.7.4 >
On 03/08/2018 10:30 AM, James Greenhalgh wrote: > On Thu, Mar 01, 2018 at 06:45:21PM +0000, Luis Machado wrote: >> Falkor's prefetch tuning structure still carries the L2 cache size value from >> early support code. This patch updates it to match the specifications. >> >> Even though the prefetcher is currently disabled for Falkor, we have a patch >> waiting for GCC development to reopen that re-enables it, so i take it this >> update should be trivial enough to go in before development reopens? > > This is OK for trunk now. I'm happy for you to take the risk of the change > in code-gen for qdf24xx if you are. > > Thanks, > James > Thanks. There is no risk yet given prefetching is still disabled for qdf24xx and will be re-enabled once development reopens.
diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c index 2f98a21..5a732b1 100644 --- a/gcc/config/aarch64/aarch64.c +++ b/gcc/config/aarch64/aarch64.c @@ -564,7 +564,7 @@ static const cpu_prefetch_tune qdf24xx_prefetch_tune = 4, /* num_slots */ 32, /* l1_cache_size */ 64, /* l1_cache_line_size */ - 1024, /* l2_cache_size */ + 512, /* l2_cache_size */ -1 /* default_opt_level */ };