| Message ID | 95b85b6d0369b4693e9d4e57af5eac49eee87dc9.1524710929.git.baolin.wang@linaro.org |
|---|---|
| State | Accepted |
| Commit | 369a30a5f1c9245a214155ee527fa169e7f813ff |
| Headers | show |
| Series | [1/2] rtc: sprd: Change to use devm_rtc_allocate_device() | expand |
On 26/04/2018 10:58:44+0800, Baolin Wang wrote: > This is a preparation patch, changing to use devm_rtc_allocate_device() > that can allow driver to set 'range_max' and 'range_min' for the RTC > device. > > Signed-off-by: Baolin Wang <baolin.wang@linaro.org> > --- > drivers/rtc/rtc-sc27xx.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > Both applied, thanks. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
diff --git a/drivers/rtc/rtc-sc27xx.c b/drivers/rtc/rtc-sc27xx.c index 00d87d1..ac86322 100644 --- a/drivers/rtc/rtc-sc27xx.c +++ b/drivers/rtc/rtc-sc27xx.c @@ -600,6 +600,10 @@ static int sprd_rtc_probe(struct platform_device *pdev) return rtc->irq; } + rtc->rtc = devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc->rtc)) + return PTR_ERR(rtc->rtc); + rtc->dev = &pdev->dev; platform_set_drvdata(pdev, rtc); @@ -626,10 +630,12 @@ static int sprd_rtc_probe(struct platform_device *pdev) return ret; } - rtc->rtc = devm_rtc_device_register(&pdev->dev, pdev->name, - &sprd_rtc_ops, THIS_MODULE); - if (IS_ERR(rtc->rtc)) - return PTR_ERR(rtc->rtc); + rtc->rtc->ops = &sprd_rtc_ops; + ret = rtc_register_device(rtc->rtc); + if (ret) { + dev_err(&pdev->dev, "failed to register rtc device\n"); + return ret; + } device_init_wakeup(&pdev->dev, 1); return 0;
This is a preparation patch, changing to use devm_rtc_allocate_device() that can allow driver to set 'range_max' and 'range_min' for the RTC device. Signed-off-by: Baolin Wang <baolin.wang@linaro.org> --- drivers/rtc/rtc-sc27xx.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) -- 1.7.9.5