| Message ID | CAAdirjzajg7zj5ADhQ5QJFfv7zxTStT0eiryO_QgO3sNtb0DEw@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [AARCH64] Add support of ARMv8.4 in saphira for Qualcomm server part | expand |
On Tue, May 29, 2018 at 05:01:42AM -0500, Sameera Deshpande wrote: > Hi! > > Please find attached the patch to add support of ARMv8.4 in saphira > for Qualcomm server part. Tested on aarch64, without any regressions. > > Ok for trunk? I'm trusting that this is the right thing to do for this core. As Siddhesh contributed the original patch; I'd like him to also sign off on this modification. OK for trunk with Siddhesh's ack. Thanks, James > diff --git a/gcc/config/aarch64/aarch64-cores.def b/gcc/config/aarch64/aarch64-cores.def > index 33b96ca2861..e64d8314fa9 100644 > --- a/gcc/config/aarch64/aarch64-cores.def > +++ b/gcc/config/aarch64/aarch64-cores.def > @@ -86,10 +86,10 @@ AARCH64_CORE("thunderx2t99", thunderx2t99, thunderx2t99, 8_1A, AARCH64_FL_FOR > AARCH64_CORE("cortex-a55", cortexa55, cortexa53, 8_2A, AARCH64_FL_FOR_ARCH8_2 | AARCH64_FL_F16 | AARCH64_FL_RCPC | AARCH64_FL_DOTPROD, cortexa53, 0x41, 0xd05, -1) > AARCH64_CORE("cortex-a75", cortexa75, cortexa57, 8_2A, AARCH64_FL_FOR_ARCH8_2 | AARCH64_FL_F16 | AARCH64_FL_RCPC | AARCH64_FL_DOTPROD, cortexa73, 0x41, 0xd0a, -1) > > -/* ARMv8.3-A Architecture Processors. */ > +/* ARMv8.4-A Architecture Processors. */ > > /* Qualcomm ('Q') cores. */ > -AARCH64_CORE("saphira", saphira, falkor, 8_3A, AARCH64_FL_FOR_ARCH8_3 | AARCH64_FL_CRYPTO | AARCH64_FL_RCPC, saphira, 0x51, 0xC01, -1) > +AARCH64_CORE("saphira", saphira, falkor, 8_4A, AARCH64_FL_FOR_ARCH8_4 | AARCH64_FL_CRYPTO | AARCH64_FL_RCPC, saphira, 0x51, 0xC01, -1) > > /* ARMv8-A big.LITTLE implementations. */ >
On 29 May 2018 at 21:17, James Greenhalgh <james.greenhalgh@arm.com> wrote: > On Tue, May 29, 2018 at 05:01:42AM -0500, Sameera Deshpande wrote: >> Hi! >> >> Please find attached the patch to add support of ARMv8.4 in saphira >> for Qualcomm server part. Tested on aarch64, without any regressions. >> >> Ok for trunk? > > I'm trusting that this is the right thing to do for this core. As Siddhesh > contributed the original patch; I'd like him to also sign off on this > modification. > > OK for trunk with Siddhesh's ack. LGTM too. Thanks, Siddhesh
On Tue 29 May, 2018, 9:19 PM Siddhesh Poyarekar, < siddhesh.poyarekar@linaro.org> wrote: > On 29 May 2018 at 21:17, James Greenhalgh <james.greenhalgh@arm.com> > wrote: > > On Tue, May 29, 2018 at 05:01:42AM -0500, Sameera Deshpande wrote: > >> Hi! > >> > >> Please find attached the patch to add support of ARMv8.4 in saphira > >> for Qualcomm server part. Tested on aarch64, without any regressions. > >> > >> Ok for trunk? > > > > I'm trusting that this is the right thing to do for this core. As > Siddhesh > > contributed the original patch; I'd like him to also sign off on this > > modification. > > > > OK for trunk with Siddhesh's ack. > > LGTM too. > > Thanks, > Siddhesh > Thanks James and Siddhesh. - Sameera >
diff --git a/gcc/config/aarch64/aarch64-cores.def b/gcc/config/aarch64/aarch64-cores.def index 33b96ca2861..e64d8314fa9 100644 --- a/gcc/config/aarch64/aarch64-cores.def +++ b/gcc/config/aarch64/aarch64-cores.def @@ -86,10 +86,10 @@ AARCH64_CORE("thunderx2t99", thunderx2t99, thunderx2t99, 8_1A, AARCH64_FL_FOR AARCH64_CORE("cortex-a55", cortexa55, cortexa53, 8_2A, AARCH64_FL_FOR_ARCH8_2 | AARCH64_FL_F16 | AARCH64_FL_RCPC | AARCH64_FL_DOTPROD, cortexa53, 0x41, 0xd05, -1) AARCH64_CORE("cortex-a75", cortexa75, cortexa57, 8_2A, AARCH64_FL_FOR_ARCH8_2 | AARCH64_FL_F16 | AARCH64_FL_RCPC | AARCH64_FL_DOTPROD, cortexa73, 0x41, 0xd0a, -1) -/* ARMv8.3-A Architecture Processors. */ +/* ARMv8.4-A Architecture Processors. */ /* Qualcomm ('Q') cores. */ -AARCH64_CORE("saphira", saphira, falkor, 8_3A, AARCH64_FL_FOR_ARCH8_3 | AARCH64_FL_CRYPTO | AARCH64_FL_RCPC, saphira, 0x51, 0xC01, -1) +AARCH64_CORE("saphira", saphira, falkor, 8_4A, AARCH64_FL_FOR_ARCH8_4 | AARCH64_FL_CRYPTO | AARCH64_FL_RCPC, saphira, 0x51, 0xC01, -1) /* ARMv8-A big.LITTLE implementations. */