| Message ID | 20190116174320.14938-1-daniel.diaz@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [1/4] selftests: lib: allow to override CC in the top-level Makefile | expand |
On 1/16/19 10:43 AM, Daniel Díaz wrote: > From: Fathi Boudra <fathi.boudra@linaro.org> > > Relax CC assignment to allow to override CC in the top-level Makefile. > > Signed-off-by: Denys Dmytriyenko <denys@ti.com> > --- > tools/testing/selftests/lib.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk > index 8b0f16409ed7..0f9c47eaaa6f 100644 > --- a/tools/testing/selftests/lib.mk > +++ b/tools/testing/selftests/lib.mk > @@ -1,6 +1,6 @@ > # This mimics the top-level Makefile. We do it explicitly here so that this > # Makefile can operate with or without the kbuild infrastructure. > -CC := $(CROSS_COMPILE)gcc > +CC ?= $(CROSS_COMPILE)gcc > > ifeq (0,$(MAKELEVEL)) > OUTPUT := $(shell pwd) > What problem does this fix? thanks, -- Shuah
Hello! On Wed, 16 Jan 2019 at 15:56, shuah <shuah@kernel.org> wrote: > > On 1/16/19 10:43 AM, Daniel Díaz wrote: > > From: Fathi Boudra <fathi.boudra@linaro.org> > > > > Relax CC assignment to allow to override CC in the top-level Makefile. > > > > Signed-off-by: Denys Dmytriyenko <denys@ti.com> > > --- > > tools/testing/selftests/lib.mk | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk > > index 8b0f16409ed7..0f9c47eaaa6f 100644 > > --- a/tools/testing/selftests/lib.mk > > +++ b/tools/testing/selftests/lib.mk > > @@ -1,6 +1,6 @@ > > # This mimics the top-level Makefile. We do it explicitly here so that this > > # Makefile can operate with or without the kbuild infrastructure. > > -CC := $(CROSS_COMPILE)gcc > > +CC ?= $(CROSS_COMPILE)gcc > > > > ifeq (0,$(MAKELEVEL)) > > OUTPUT := $(shell pwd) > > > > What problem does this fix? Sometimes "$(CROSS_COMPILE)gcc" is not enough: For instance, we need to pass --sysroot to CC: CC="aarch64-linaro-linux-gcc --sysroot=/oe/build/tmp-lkft-glibc/work/hikey-linaro-linux/kselftests-mainline/4.19-r0/recipe-sysroot" Greetings! Daniel Díaz daniel.diaz@linaro.org
Hi Daniel, On 1/18/19 10:54 AM, Daniel Díaz wrote: > Hello! > > On Wed, 16 Jan 2019 at 15:56, shuah <shuah@kernel.org> wrote: >> >> On 1/16/19 10:43 AM, Daniel Díaz wrote: >>> From: Fathi Boudra <fathi.boudra@linaro.org> >>> >>> Relax CC assignment to allow to override CC in the top-level Makefile. >>> >>> Signed-off-by: Denys Dmytriyenko <denys@ti.com> Author signed-off missing on this patch. I am dropping this patch from rc5 for now. Please fix it resend the patch. In the future, I would like to see that author sends the patch. thanks, -- Shuah
On Mon, Jan 28, 2019 at 08:01:15AM -0700, shuah wrote: > Hi Daniel, > > On 1/18/19 10:54 AM, Daniel Díaz wrote: > >Hello! > > > >On Wed, 16 Jan 2019 at 15:56, shuah <shuah@kernel.org> wrote: > >> > >>On 1/16/19 10:43 AM, Daniel Díaz wrote: > >>>From: Fathi Boudra <fathi.boudra@linaro.org> > >>> > >>>Relax CC assignment to allow to override CC in the top-level Makefile. > >>> > >>>Signed-off-by: Denys Dmytriyenko <denys@ti.com> ^^^ I am the original author of the patch and this is my signed-off line. > Author signed-off missing on this patch. I am dropping this patch > from rc5 for now. Please fix it resend the patch. In the future, > I would like to see that author sends the patch. -- Denys
On 1/28/19 8:42 AM, Denys Dmytriyenko wrote: > On Mon, Jan 28, 2019 at 08:01:15AM -0700, shuah wrote: >> Hi Daniel, >> >> On 1/18/19 10:54 AM, Daniel Díaz wrote: >>> Hello! >>> >>> On Wed, 16 Jan 2019 at 15:56, shuah <shuah@kernel.org> wrote: >>>> >>>> On 1/16/19 10:43 AM, Daniel Díaz wrote: >>>>> From: Fathi Boudra <fathi.boudra@linaro.org> This is the problem. It says, it came from Fathi Boudra <fathi.boudra@linaro.org> >>>>> >>>>> Relax CC assignment to allow to override CC in the top-level Makefile. >>>>> >>>>> Signed-off-by: Denys Dmytriyenko <denys@ti.com> > > ^^^ I am the original author of the patch and this is my signed-off line. > thanks, -- Shuah
Hello! On Mon, 28 Jan 2019 at 10:28, shuah <shuah@kernel.org> wrote: > On 1/28/19 8:42 AM, Denys Dmytriyenko wrote: > > On Mon, Jan 28, 2019 at 08:01:15AM -0700, shuah wrote: > >> Hi Daniel, > >> > >> On 1/18/19 10:54 AM, Daniel Díaz wrote: > >>> Hello! > >>> > >>> On Wed, 16 Jan 2019 at 15:56, shuah <shuah@kernel.org> wrote: > >>>> > >>>> On 1/16/19 10:43 AM, Daniel Díaz wrote: > >>>>> From: Fathi Boudra <fathi.boudra@linaro.org> > > This is the problem. It says, it came from Fathi Boudra > <fathi.boudra@linaro.org> Denys, apologies for sending this patch as Fathi's. In our Git repository [1] he's marked as author, probably as it got copied from repo to repo. Would you mind sending this patch yourself? Thanks and greetings! Daniel Díaz daniel.diaz@linaro.org [1] https://github.com/96boards/meta-rpb/blob/master/recipes-overlayed/kselftests/files/0001-selftests-lib-allow-to-override-CC-in-the-top-level-Makefile.patch > >>>>> Relax CC assignment to allow to override CC in the top-level Makefile. > >>>>> > >>>>> Signed-off-by: Denys Dmytriyenko <denys@ti.com> > > > > ^^^ I am the original author of the patch and this is my signed-off line. > > > > thanks, > -- Shuah
diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk index 8b0f16409ed7..0f9c47eaaa6f 100644 --- a/tools/testing/selftests/lib.mk +++ b/tools/testing/selftests/lib.mk @@ -1,6 +1,6 @@ # This mimics the top-level Makefile. We do it explicitly here so that this # Makefile can operate with or without the kbuild infrastructure. -CC := $(CROSS_COMPILE)gcc +CC ?= $(CROSS_COMPILE)gcc ifeq (0,$(MAKELEVEL)) OUTPUT := $(shell pwd)