diff mbox series

[4/5] tcg: Remove duplicate #if !defined(CODE_ACCESS)

Message ID 20190709092049.13771-5-richard.henderson@linaro.org
State Superseded
Headers show
Series tcg: Fix mmap_lock assertion failure, take 2 | expand

Commit Message

Richard Henderson July 9, 2019, 9:20 a.m. UTC 
This code block is already surrounded by #ifndef CODE_ACCESS.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 include/exec/cpu_ldst_useronly_template.h | 2 --
 1 file changed, 2 deletions(-)

-- 
2.17.1

Comments

Alex Bennée July 9, 2019, 10:11 a.m. UTC | #1 
Richard Henderson <richard.henderson@linaro.org> writes:

> This code block is already surrounded by #ifndef CODE_ACCESS.

>

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Reviewed-by: Alex Bennée <alex.bennee@linaro.org>


> ---

>  include/exec/cpu_ldst_useronly_template.h | 2 --

>  1 file changed, 2 deletions(-)

>

> diff --git a/include/exec/cpu_ldst_useronly_template.h b/include/exec/cpu_ldst_useronly_template.h

> index 8c7a2c6cd7..d663826ac2 100644

> --- a/include/exec/cpu_ldst_useronly_template.h

> +++ b/include/exec/cpu_ldst_useronly_template.h

> @@ -118,11 +118,9 @@ static inline void

>  glue(glue(cpu_st, SUFFIX), MEMSUFFIX)(CPUArchState *env, abi_ptr ptr,

>                                        RES_TYPE v)

>  {

> -#if !defined(CODE_ACCESS)

>      trace_guest_mem_before_exec(

>          env_cpu(env), ptr,

>          trace_mem_build_info(SHIFT, false, MO_TE, true));

> -#endif

>      glue(glue(st, SUFFIX), _p)(g2h(ptr), v);

>  }



--
Alex Bennée
diff mbox series

Patch

diff --git a/include/exec/cpu_ldst_useronly_template.h b/include/exec/cpu_ldst_useronly_template.h
index 8c7a2c6cd7..d663826ac2 100644
--- a/include/exec/cpu_ldst_useronly_template.h
+++ b/include/exec/cpu_ldst_useronly_template.h
@@ -118,11 +118,9 @@  static inline void
 glue(glue(cpu_st, SUFFIX), MEMSUFFIX)(CPUArchState *env, abi_ptr ptr,
                                       RES_TYPE v)
 {
-#if !defined(CODE_ACCESS)
     trace_guest_mem_before_exec(
         env_cpu(env), ptr,
         trace_mem_build_info(SHIFT, false, MO_TE, true));
-#endif
     glue(glue(st, SUFFIX), _p)(g2h(ptr), v);
 }