| Message ID | 20191119165549.14570-4-rrichter@marvell.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] MAINTAINERS: Update Cavium ThunderX drivers | expand |
On Tue, 2019-11-19 at 16:56 +0000, Robert Richter wrote: > Switch all addresses from @cavium.com to @marvell.com. > > On that occasion, switching also to my Marvell address for all my > Cavium/Marvell entries. [] > diff --git a/MAINTAINERS b/MAINTAINERS [] > @@ -3727,14 +3727,14 @@ S: Supported > F: drivers/mmc/host/cavium* > > CAVIUM OCTEON-TX CRYPTO DRIVER > -M: George Cherian <george.cherian@cavium.com> > +M: George Cherian <gcherian@marvell.com> > L: linux-crypto@vger.kernel.org > W: http://www.cavium.com Might want to change these W: links too > @@ -17911,7 +17911,7 @@ S: Supported > F: drivers/char/xillybus/ > > XLP9XX I2C DRIVER > -M: George Cherian <george.cherian@cavium.com> > +M: George Cherian <gcherian@marvell.com> > L: linux-i2c@vger.kernel.org > W: http://www.cavium.com etc... > S: Supported
On 19.11.19 09:14:36, Joe Perches wrote: > On Tue, 2019-11-19 at 16:56 +0000, Robert Richter wrote: > > W: http://www.cavium.com > > Might want to change these W: links too Yeah, good catch, was searching only for @cavium, which did not work quite well here. Fixed that. Will send v2. Thanks, -Robert
On Tue, 2019-11-19 at 18:50 +0000, Robert Richter wrote: > On 19.11.19 09:14:36, Joe Perches wrote: > > On Tue, 2019-11-19 at 16:56 +0000, Robert Richter wrote: > > > W: http://www.cavium.com > > > > Might want to change these W: links too > > Yeah, good catch, was searching only for @cavium, which did not work > quite well here. Fixed that. Maybe make that change globally in all the files other than MAINTAINERS as well eventually. arch/arm64/mm/numa.c:6: * Author: Ganapatrao Kulkarni <gkulkarni@cavium.com> arch/mips/cavium-octeon/octeon-usb.c:551:MODULE_AUTHOR("David Daney <david.daney@cavium.com>"); arch/mips/include/asm/octeon/cvmx-coremask.h:6: * Copyright (c) 2016 Cavium Inc. (support@cavium.com). arch/mips/include/asm/octeon/cvmx-lmcx-defs.h:4: * Contact: support@cavium.com arch/mips/include/asm/octeon/cvmx-rst-defs.h:4: * Contact: support@cavium.com drivers/ata/ahci_octeon.c:99:MODULE_AUTHOR("Cavium, Inc. <support@cavium.com>"); drivers/crypto/cavium/cpt/cptpf_main.c:668:MODULE_AUTHOR("George Cherian <george.cherian@cavium.com>"); drivers/crypto/cavium/cpt/cptvf_main.c:860:MODULE_AUTHOR("George Cherian <george.cherian@cavium.com>"); drivers/crypto/cavium/nitrox/nitrox_main.c:593:MODULE_AUTHOR("Srikanth Jampala <Jampala.Srikanth@cavium.com>"); drivers/i2c/busses/i2c-thunderx-pcidrv.c:6: * Jan Glauber <jglauber@cavium.com> drivers/mmc/host/cavium-octeon.c:336:MODULE_AUTHOR("Cavium Inc. <support@cavium.com>"); drivers/mmc/host/cavium.c:11: * David Daney <david.daney@cavium.com> drivers/mmc/host/cavium.c:12: * Peter Swain <pswain@cavium.com> drivers/mmc/host/cavium.c:13: * Steven J. Hill <steven.hill@cavium.com> drivers/mmc/host/cavium.c:14: * Jan Glauber <jglauber@cavium.com> drivers/net/ethernet/cavium/common/cavium_ptp.c:338:MODULE_AUTHOR("Cavium Networks <support@cavium.com>"); drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.h:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/cn23xx_pf_regs.h:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.h:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/cn23xx_vf_regs.h:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/cn66xx_device.c:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/cn66xx_device.h:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/cn66xx_regs.h:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/cn68xx_device.c:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/cn68xx_device.h:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/cn68xx_regs.h:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/lio_core.c:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/lio_ethtool.c:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/lio_main.c:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/lio_main.c:39:MODULE_AUTHOR("Cavium Networks, <support@cavium.com>"); drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:32:MODULE_AUTHOR("Cavium Networks, <support@cavium.com>"); drivers/net/ethernet/cavium/liquidio/lio_vf_rep.c:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/lio_vf_rep.h:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/liquidio_common.h:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/liquidio_image.h:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/octeon_config.h:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/octeon_console.c:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/octeon_device.c:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/octeon_device.h:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/octeon_droq.c:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/octeon_droq.h:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/octeon_iq.h:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/octeon_mailbox.h:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/octeon_main.h:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.h:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/octeon_network.h:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/octeon_nic.c:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/octeon_nic.h:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/request_manager.c:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/response_manager.c:4: * Contact: support@cavium.com drivers/net/ethernet/cavium/liquidio/response_manager.h:4: * Contact: support@cavium.com drivers/perf/thunderx2_pmu.c:5: * Author: Ganapatrao Kulkarni <gkulkarni@cavium.com> drivers/perf/thunderx2_pmu.c:1054:MODULE_AUTHOR("Ganapatrao Kulkarni <gkulkarni@cavium.com>"); drivers/spi/spi-cavium-thunderx.c:6: * Authors: Jan Glauber <jglauber@cavium.com> drivers/staging/octeon-usb/octeon-hcd.c:11: * Copyright (c) 2003-2010 Cavium Networks (support@cavium.com). All rights drivers/staging/octeon-usb/octeon-hcd.c:3736:MODULE_AUTHOR("Cavium, Inc. <support@cavium.com>"); drivers/staging/octeon-usb/octeon-hcd.h:11: * Copyright (c) 2003-2010 Cavium Networks (support@cavium.com). All rights drivers/usb/storage/unusual_devs.h:2140:/* Reported-by George Cherian <george.cherian@cavium.com> */ drivers/watchdog/octeon-wdt-main.c:607:MODULE_AUTHOR("Cavium Inc. <support@cavium.com>");
Joe, thanks for your review. On 19.11.19 11:56:53, Joe Perches wrote: > Maybe make that change globally in all the files other > than MAINTAINERS as well eventually. > > arch/arm64/mm/numa.c:6: * Author: Ganapatrao Kulkarni <gkulkarni@cavium.com> > arch/mips/cavium-octeon/octeon-usb.c:551:MODULE_AUTHOR("David Daney <david.daney@cavium.com>"); > arch/mips/include/asm/octeon/cvmx-coremask.h:6: * Copyright (c) 2016 Cavium Inc. (support@cavium.com). [...] This is a bit past the scope of this patch. I will leave that change to the driver's maintainers. I also think that authorship does not change even if the author's email address changed or vanished later. I am not sure on the general handling of MODULE_AUTHOR(), should that always contain a valid email address? Seems not the case. I don't think somebody actually sends an email to the author, it is more to better identify the author. Thank you, -Robert
On Tue, 2019-11-19 at 20:23 +0000, Robert Richter wrote: > Joe, > > thanks for your review. > > On 19.11.19 11:56:53, Joe Perches wrote: > > Maybe make that change globally in all the files other > > than MAINTAINERS as well eventually. > > > > arch/arm64/mm/numa.c:6: * Author: Ganapatrao Kulkarni <gkulkarni@cavium.com> > > arch/mips/cavium-octeon/octeon-usb.c:551:MODULE_AUTHOR("David Daney <david.daney@cavium.com>"); > > arch/mips/include/asm/octeon/cvmx-coremask.h:6: * Copyright (c) 2016 Cavium Inc. (support@cavium.com). > > [...] > > This is a bit past the scope of this patch. Yup, completely agree, as it seems I understated with "eventually". > I will leave that change to the driver's maintainers. Fine by me. btw: There's also entries for @caviumnetworks.com so those might change one day too. > I also think that authorship does not > change even if the author's email address changed or vanished later. I > am not sure on the general handling of MODULE_AUTHOR(), should that > always contain a valid email address? Seems not the case. I don't > think somebody actually sends an email to the author, it is more to > better identify the author. Changelog identifies the author, MODULE_AUTHOR is actually available via modinfo -a, which shows email if entered, but that may also be rarely used in practice.
diff --git a/MAINTAINERS b/MAINTAINERS index 2bef41729946..e1d8c905521a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1547,8 +1547,8 @@ S: Maintained F: arch/arm/mach-cns3xxx/ ARM/CAVIUM THUNDER NETWORK DRIVER -M: Sunil Goutham <sgoutham@cavium.com> -M: Robert Richter <rric@kernel.org> +M: Sunil Goutham <sgoutham@marvell.com> +M: Robert Richter <rrichter@marvell.com> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) S: Supported F: drivers/net/ethernet/cavium/thunder/ @@ -3727,14 +3727,14 @@ S: Supported F: drivers/mmc/host/cavium* CAVIUM OCTEON-TX CRYPTO DRIVER -M: George Cherian <george.cherian@cavium.com> +M: George Cherian <gcherian@marvell.com> L: linux-crypto@vger.kernel.org W: http://www.cavium.com S: Supported F: drivers/crypto/cavium/cpt/ CAVIUM THUNDERX2 ARM64 SOC -M: Robert Richter <rrichter@cavium.com> +M: Robert Richter <rrichter@marvell.com> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) S: Maintained F: arch/arm64/boot/dts/cavium/thunder2-99xx* @@ -17911,7 +17911,7 @@ S: Supported F: drivers/char/xillybus/ XLP9XX I2C DRIVER -M: George Cherian <george.cherian@cavium.com> +M: George Cherian <gcherian@marvell.com> L: linux-i2c@vger.kernel.org W: http://www.cavium.com S: Supported
Switch all addresses from @cavium.com to @marvell.com. On that occasion, switching also to my Marvell address for all my Cavium/Marvell entries. Cc: Sunil Goutham <sgoutham@marvell.com> Cc: George Cherian <gcherian@marvell.com> Cc: soc@kernel.org Signed-off-by: Robert Richter <rrichter@marvell.com> --- MAINTAINERS | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.20.1