mbox series

[v2,for,5.0-rc3,00/17] more randome fixes (user, pie, docker and gdbstub)

Message ID 20200414200631.12799-1-alex.bennee@linaro.org
Headers show
Series more randome fixes (user, pie, docker and gdbstub) | expand

Message

Alex Bennée April 14, 2020, 8:06 p.m. UTC 
Hi,

This is version 2 of my random fixes for rc3 series. In no particular
order we have:

  - A trivial fix to /proc/self/stat output
  - An attempt to fix broken PIE builds for Windows (please test!)
  - Some fixes to get "make docker-all-tests" running again
  - A tweak to .gitignore 
  - A couple of bugs found in the gdbstub GByteArray conversion
  - A new test case for linux-user gdbstub support
  - Which found a few more gdbstub bugs :-/

The m68k FPU patch is definitely a hack but it seemed easier than
disabling completely. The chatter on #gdb seems to be there is some
combination of qemu and gdb tress that does work but I suspect this
needs some maintainer action.

I've dropped the MacOSX travis patch as Travis has hopefully sorted
itself out.

I've also included the guest base re-factoring patches as it makes it
easier for me to soak test the tree with the sanitiser although those
actual fixes won't go into 5.0 at this late stage.

The following patches need review:

 - tests/tcg: add a multiarch linux-user gdb test
 - tests/tcg: drop inferior.was_attached() test
 - target/m68k: hack around the FPU register support (HACK!)
 - linux-user: completely re-write init_guest_space

Alex Bennée (9):
  linux-user: completely re-write init_guest_space
  .gitignore: include common build sub-directories
  tests/docker: add docs FEATURE flag and use for test-misc
  configure: redirect sphinx-build check to config.log
  configure: disable PIE for Windows builds
  linux-user: fix /proc/self/stat handling
  target/m68k: hack around the FPU register support (HACK!)
  tests/tcg: drop inferior.was_attached() test
  tests/tcg: add a multiarch linux-user gdb test

Peter Xu (1):
  gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb

Philippe Mathieu-Daudé (4):
  target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray
  gdbstub: Do not use memset() on GByteArray
  gdbstub: Introduce gdb_get_float32() to get 32-bit float registers
  gdbstub: Introduce gdb_get_float64() to get 64-bit float registers

Richard Henderson (3):
  exec/cpu-all: Use bool for have_guest_base
  accel/tcg: Relax va restrictions on 64-bit guests
  linux-user/ppc: Fix padding in mcontext_t for ppc64

 configure                                   |   5 +-
 include/exec/cpu-all.h                      |  25 +-
 include/exec/gdbstub.h                      |  29 ++
 linux-user/qemu.h                           |  31 +-
 target/alpha/cpu-param.h                    |  15 +-
 accel/tcg/translate-all.c                   |  15 +-
 bsd-user/main.c                             |   4 +-
 linux-user/elfload.c                        | 503 ++++++++++----------
 linux-user/flatload.c                       |   6 +
 linux-user/main.c                           |  27 +-
 linux-user/ppc/signal.c                     |  69 ++-
 linux-user/syscall.c                        |  43 +-
 target/arm/gdbstub.c                        |   3 +-
 target/i386/gdbstub.c                       |   2 +-
 target/m68k/helper.c                        |  14 +-
 target/ppc/gdbstub.c                        |   4 +-
 target/ppc/translate_init.inc.c             |   2 +-
 target/sh4/gdbstub.c                        |   6 +-
 target/xtensa/gdbstub.c                     |   6 +-
 .gitignore                                  |   1 +
 gdb-xml/m68k-fp.xml                         |  16 +-
 tests/docker/dockerfiles/debian10.docker    |   2 +
 tests/docker/dockerfiles/debian9.docker     |   2 -
 tests/docker/dockerfiles/fedora.docker      |   2 +-
 tests/docker/dockerfiles/travis.docker      |   2 +-
 tests/docker/dockerfiles/ubuntu.docker      |   2 +-
 tests/docker/dockerfiles/ubuntu1804.docker  |   2 +-
 tests/docker/test-misc                      |   2 +
 tests/tcg/aarch64/gdbstub/test-sve-ioctl.py |   3 -
 tests/tcg/aarch64/gdbstub/test-sve.py       |   3 -
 tests/tcg/multiarch/Makefile.target         |  15 +
 tests/tcg/multiarch/gdbstub/sha1.py         |  81 ++++
 32 files changed, 522 insertions(+), 420 deletions(-)
 create mode 100644 tests/tcg/multiarch/gdbstub/sha1.py

-- 
2.20.1

Comments

no-reply@patchew.org April 15, 2020, 1:42 a.m. UTC | #1 
Patchew URL: https://patchew.org/QEMU/20200414200631.12799-1-alex.bennee@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH  v2 for 5.0-rc3 00/17] more randome fixes (user, pie, docker and gdbstub)
Message-id: 20200414200631.12799-1-alex.bennee@linaro.org
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
1d9b560 tests/tcg: add a multiarch linux-user gdb test
0421111 tests/tcg: drop inferior.was_attached() test
d252cf5 target/m68k: hack around the FPU register support (HACK!)
fe2d373 gdbstub: Introduce gdb_get_float64() to get 64-bit float registers
a067a36 gdbstub: Introduce gdb_get_float32() to get 32-bit float registers
22159df gdbstub: Do not use memset() on GByteArray
0440574 gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb
661c288 target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray
6d7f04a linux-user: fix /proc/self/stat handling
8077d16 configure: disable PIE for Windows builds
3525a95 configure: redirect sphinx-build check to config.log
d7cc6ea tests/docker: add docs FEATURE flag and use for test-misc
2faca0a linux-user/ppc: Fix padding in mcontext_t for ppc64
bd002dd .gitignore: include common build sub-directories
2cb4915 accel/tcg: Relax va restrictions on 64-bit guests
b81214a exec/cpu-all: Use bool for have_guest_base
56dda0e linux-user: completely re-write init_guest_space

=== OUTPUT BEGIN ===
1/17 Checking commit 56dda0ee6d96 (linux-user: completely re-write init_guest_space)
2/17 Checking commit b81214a4a7b1 (exec/cpu-all: Use bool for have_guest_base)
3/17 Checking commit 2cb4915f8641 (accel/tcg: Relax va restrictions on 64-bit guests)
ERROR: Macros with complex values should be enclosed in parenthesis
#91: FILE: include/exec/cpu-all.h:182:
+# define GUEST_ADDR_MAX_  ~0ul

total: 1 errors, 0 warnings, 88 lines checked

Patch 3/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/17 Checking commit bd002dddde97 (.gitignore: include common build sub-directories)
5/17 Checking commit 2faca0a20813 (linux-user/ppc: Fix padding in mcontext_t for ppc64)
6/17 Checking commit d7cc6eab6083 (tests/docker: add docs FEATURE flag and use for test-misc)
7/17 Checking commit 3525a9514500 (configure: redirect sphinx-build check to config.log)
8/17 Checking commit 8077d168511c (configure: disable PIE for Windows builds)
9/17 Checking commit 6d7f04aaf64a (linux-user: fix /proc/self/stat handling)
10/17 Checking commit 661c288d6e96 (target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray)
11/17 Checking commit 04405743253c (gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb)
12/17 Checking commit 22159df16cb9 (gdbstub: Do not use memset() on GByteArray)
13/17 Checking commit a067a369add1 (gdbstub: Introduce gdb_get_float32() to get 32-bit float registers)
14/17 Checking commit fe2d3733f79b (gdbstub: Introduce gdb_get_float64() to get 64-bit float registers)
15/17 Checking commit d252cf53d601 (target/m68k: hack around the FPU register support (HACK!))
ERROR: space prohibited after that '*' (ctx:BxW)
#88: FILE: target/m68k/helper.c:130:
+        env->fregs[n].l.lower = le64_to_cpu(* (uint64_t *) mem_buf);
                                             ^

ERROR: space prohibited after that '*' (ctx:BxW)
#89: FILE: target/m68k/helper.c:131:
+        env->fregs[n].l.upper = le16_to_cpu(* (uint16_t *) (mem_buf + 8));
                                             ^

total: 2 errors, 0 warnings, 45 lines checked

Patch 15/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

16/17 Checking commit 04211112b3bd (tests/tcg: drop inferior.was_attached() test)
17/17 Checking commit 1d9b560da197 (tests/tcg: add a multiarch linux-user gdb test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 101 lines checked

Patch 17/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200414200631.12799-1-alex.bennee@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com