diff mbox series

drm: gma500: Drop surplus include

Message ID 20200626220134.340209-1-linus.walleij@linaro.org
State New
Headers show
Series drm: gma500: Drop surplus include | expand

Commit Message

Linus Walleij June 26, 2020, 10:01 p.m. UTC 
This file includes <linux/gpio.h> but does not use any
symbols from it, drop the include.

Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
 drivers/gpu/drm/gma500/psb_intel_drv.h | 1 -
 1 file changed, 1 deletion(-)

-- 
2.25.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Comments

kernel test robot June 27, 2020, 3:20 a.m. UTC | #1 
Hi Linus,

I love your patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next drm-tip/drm-tip linus/master v5.8-rc2 next-20200626]
[cannot apply to drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Linus-Walleij/drm-gma500-Drop-surplus-include/20200627-060308
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project ee3620643dfc88a178fa4ca116cf83014e4ee547)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/gma500/mdfld_dsi_output.c:452:8: error: implicit declaration of function 'gpio_request' [-Werror,-Wimplicit-function-declaration]

           ret = gpio_request(gpio, "gfx");
                 ^
>> drivers/gpu/drm/gma500/mdfld_dsi_output.c:458:8: error: implicit declaration of function 'gpio_direction_output' [-Werror,-Wimplicit-function-declaration]

           ret = gpio_direction_output(gpio, 1);
                 ^
>> drivers/gpu/drm/gma500/mdfld_dsi_output.c:464:2: error: implicit declaration of function 'gpio_get_value' [-Werror,-Wimplicit-function-declaration]

           gpio_get_value(128);
           ^
>> drivers/gpu/drm/gma500/mdfld_dsi_output.c:467:6: error: implicit declaration of function 'gpio_is_valid' [-Werror,-Wimplicit-function-declaration]

           if (gpio_is_valid(gpio))
               ^
   drivers/gpu/drm/gma500/mdfld_dsi_output.c:467:6: note: did you mean 'uuid_is_valid'?
   include/linux/uuid.h:92:19: note: 'uuid_is_valid' declared here
   bool __must_check uuid_is_valid(const char *uuid);
                     ^
>> drivers/gpu/drm/gma500/mdfld_dsi_output.c:468:3: error: implicit declaration of function 'gpio_free' [-Werror,-Wimplicit-function-declaration]

                   gpio_free(gpio);
                   ^
   5 errors generated.

vim +/gpio_request +452 drivers/gpu/drm/gma500/mdfld_dsi_output.c

026abc333205c1 Kirill A. Shutemov 2012-03-08  434  
026abc333205c1 Kirill A. Shutemov 2012-03-08  435  int mdfld_dsi_panel_reset(int pipe)
026abc333205c1 Kirill A. Shutemov 2012-03-08  436  {
026abc333205c1 Kirill A. Shutemov 2012-03-08  437  	unsigned gpio;
026abc333205c1 Kirill A. Shutemov 2012-03-08  438  	int ret = 0;
026abc333205c1 Kirill A. Shutemov 2012-03-08  439  
026abc333205c1 Kirill A. Shutemov 2012-03-08  440  	switch (pipe) {
026abc333205c1 Kirill A. Shutemov 2012-03-08  441  	case 0:
026abc333205c1 Kirill A. Shutemov 2012-03-08  442  		gpio = 128;
026abc333205c1 Kirill A. Shutemov 2012-03-08  443  		break;
026abc333205c1 Kirill A. Shutemov 2012-03-08  444  	case 2:
026abc333205c1 Kirill A. Shutemov 2012-03-08  445  		gpio = 34;
026abc333205c1 Kirill A. Shutemov 2012-03-08  446  		break;
026abc333205c1 Kirill A. Shutemov 2012-03-08  447  	default:
026abc333205c1 Kirill A. Shutemov 2012-03-08  448  		DRM_ERROR("Invalid output\n");
026abc333205c1 Kirill A. Shutemov 2012-03-08  449  		return -EINVAL;
026abc333205c1 Kirill A. Shutemov 2012-03-08  450  	}
026abc333205c1 Kirill A. Shutemov 2012-03-08  451  
026abc333205c1 Kirill A. Shutemov 2012-03-08 @452  	ret = gpio_request(gpio, "gfx");
026abc333205c1 Kirill A. Shutemov 2012-03-08  453  	if (ret) {
026abc333205c1 Kirill A. Shutemov 2012-03-08  454  		DRM_ERROR("gpio_rqueset failed\n");
026abc333205c1 Kirill A. Shutemov 2012-03-08  455  		return ret;
026abc333205c1 Kirill A. Shutemov 2012-03-08  456  	}
026abc333205c1 Kirill A. Shutemov 2012-03-08  457  
026abc333205c1 Kirill A. Shutemov 2012-03-08 @458  	ret = gpio_direction_output(gpio, 1);
026abc333205c1 Kirill A. Shutemov 2012-03-08  459  	if (ret) {
026abc333205c1 Kirill A. Shutemov 2012-03-08  460  		DRM_ERROR("gpio_direction_output failed\n");
026abc333205c1 Kirill A. Shutemov 2012-03-08  461  		goto gpio_error;
026abc333205c1 Kirill A. Shutemov 2012-03-08  462  	}
026abc333205c1 Kirill A. Shutemov 2012-03-08  463  
026abc333205c1 Kirill A. Shutemov 2012-03-08 @464  	gpio_get_value(128);
026abc333205c1 Kirill A. Shutemov 2012-03-08  465  
026abc333205c1 Kirill A. Shutemov 2012-03-08  466  gpio_error:
026abc333205c1 Kirill A. Shutemov 2012-03-08 @467  	if (gpio_is_valid(gpio))
026abc333205c1 Kirill A. Shutemov 2012-03-08 @468  		gpio_free(gpio);
026abc333205c1 Kirill A. Shutemov 2012-03-08  469  
026abc333205c1 Kirill A. Shutemov 2012-03-08  470  	return ret;
026abc333205c1 Kirill A. Shutemov 2012-03-08  471  }
026abc333205c1 Kirill A. Shutemov 2012-03-08  472  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Patrik Jakobsson June 27, 2020, 8:06 p.m. UTC | #2 
On Sat, Jun 27, 2020 at 12:01 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>

> This file includes <linux/gpio.h> but does not use any

> symbols from it, drop the include.


Hi Linus,
Seems the include should be moved to mdfld_dsi_output.c instead.

Thanks
Patrik

>

> Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

> ---

>  drivers/gpu/drm/gma500/psb_intel_drv.h | 1 -

>  1 file changed, 1 deletion(-)

>

> diff --git a/drivers/gpu/drm/gma500/psb_intel_drv.h b/drivers/gpu/drm/gma500/psb_intel_drv.h

> index fb601983cef0..9221d1f545b0 100644

> --- a/drivers/gpu/drm/gma500/psb_intel_drv.h

> +++ b/drivers/gpu/drm/gma500/psb_intel_drv.h

> @@ -13,7 +13,6 @@

>  #include <drm/drm_encoder.h>

>  #include <drm/drm_probe_helper.h>

>  #include <drm/drm_vblank.h>

> -#include <linux/gpio.h>

>  #include "gma_display.h"

>

>  /*

> --

> 2.25.4

>

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Linus Walleij June 27, 2020, 10:09 p.m. UTC | #3 
On Sat, Jun 27, 2020 at 10:07 PM Patrik Jakobsson
<patrik.r.jakobsson@gmail.com> wrote:
> On Sat, Jun 27, 2020 at 12:01 AM Linus Walleij <linus.walleij@linaro.org> wrote:

> >

> > This file includes <linux/gpio.h> but does not use any

> > symbols from it, drop the include.

>

> Hi Linus,

> Seems the include should be moved to mdfld_dsi_output.c instead.


Yeah we are in include file hell :/

I'll figure it out.

Yours,
Linus Walleij
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox series

Patch

diff --git a/drivers/gpu/drm/gma500/psb_intel_drv.h b/drivers/gpu/drm/gma500/psb_intel_drv.h
index fb601983cef0..9221d1f545b0 100644
--- a/drivers/gpu/drm/gma500/psb_intel_drv.h
+++ b/drivers/gpu/drm/gma500/psb_intel_drv.h
@@ -13,7 +13,6 @@ 
 #include <drm/drm_encoder.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
-#include <linux/gpio.h>
 #include "gma_display.h"
 
 /*