| Message ID | 20200406113724.8504-1-ulf.hansson@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | mmc: sdhci-sprd: Drop redundant cap flags | expand |
On Mon, Apr 6, 2020 at 7:37 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > The MMC_CAP_ERASE and MMC_CAP_CMD23 flags are already being set in the > common sdhci_setup_host(). This makes it redundant to set them for > sdhci-sprd, so let's drop them. > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Thanks Ulf. Reviewed-by: Baolin Wang <baolin.wang7@gmail.com> > --- > drivers/mmc/host/sdhci-sprd.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c > index 2ab42c59e4f8..60c3a4c620f9 100644 > --- a/drivers/mmc/host/sdhci-sprd.c > +++ b/drivers/mmc/host/sdhci-sprd.c > @@ -556,7 +556,8 @@ static int sdhci_sprd_probe(struct platform_device *pdev) > sdhci_sprd_voltage_switch; > > host->mmc->caps = MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED | > - MMC_CAP_ERASE | MMC_CAP_CMD23 | MMC_CAP_WAIT_WHILE_BUSY; > + MMC_CAP_WAIT_WHILE_BUSY; > + > ret = mmc_of_parse(host->mmc); > if (ret) > goto pltfm_free; > -- > 2.20.1 >
diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c index 2ab42c59e4f8..60c3a4c620f9 100644 --- a/drivers/mmc/host/sdhci-sprd.c +++ b/drivers/mmc/host/sdhci-sprd.c @@ -556,7 +556,8 @@ static int sdhci_sprd_probe(struct platform_device *pdev) sdhci_sprd_voltage_switch; host->mmc->caps = MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED | - MMC_CAP_ERASE | MMC_CAP_CMD23 | MMC_CAP_WAIT_WHILE_BUSY; + MMC_CAP_WAIT_WHILE_BUSY; + ret = mmc_of_parse(host->mmc); if (ret) goto pltfm_free;
The MMC_CAP_ERASE and MMC_CAP_CMD23 flags are already being set in the common sdhci_setup_host(). This makes it redundant to set them for sdhci-sprd, so let's drop them. Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> --- drivers/mmc/host/sdhci-sprd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.20.1