Message ID | 20200512100247.512048-1-jakov.petrina@sartura.hr |
---|---|
State | Accepted |
Commit | 8678776df6f5b77bbb504b2b3b02e61f73b9168d |
Headers | show |
Series | arch: arm: uDPU: fix PHY mode definition to sgmii-2500 | expand |
On 12/05/2020 12:02, Jakov Petrina wrote: > Commit f49ac7e1c4 switched the default PHY speed to 3.125Gbit to resolve > issues with SFP modules. However, U-Boot does not have a "2500base-x" > phy-mode. > > Resolve this by using "sgmii-2500" instead. > > Signed-off-by: Jakov Petrina <jakov.petrina at sartura.hr> > Signed-off-by: Vladimir Vid <vladimir.vid at sartura.hr> > Cc: Luka Perkov <luka.perkov at sartura.hr> > Cc: Stefan Roese <sr at denx.de> > --- > arch/arm/dts/armada-3720-uDPU.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Hi Stefan, I'm curious if there are any feedback or blockers on this patch? Thanks, Jakov > diff --git a/arch/arm/dts/armada-3720-uDPU.dts b/arch/arm/dts/armada-3720-uDPU.dts > index 07c7b91175..7f4b8222f4 100644 > --- a/arch/arm/dts/armada-3720-uDPU.dts > +++ b/arch/arm/dts/armada-3720-uDPU.dts > @@ -125,14 +125,14 @@ > ð0 { > pinctrl-0 = <&pcie_pins>; > status = "okay"; > - phy-mode = "2500base-x"; > + phy-mode = "sgmii-2500"; > managed = "in-band-status"; > phy = <ðphy0>; > }; > > ð1 { > status = "okay"; > - phy-mode = "2500base-x"; > + phy-mode = "sgmii-2500"; > managed = "in-band-status"; > phy = <ðphy1>; > }; >
Hi Jakov, On 23.05.20 20:23, Jakov Petrina wrote: > On 12/05/2020 12:02, Jakov Petrina wrote: >> Commit f49ac7e1c4 switched the default PHY speed to 3.125Gbit to resolve >> issues with SFP modules. However, U-Boot does not have a "2500base-x" >> phy-mode. >> >> Resolve this by using "sgmii-2500" instead. >> >> Signed-off-by: Jakov Petrina <jakov.petrina at sartura.hr> >> Signed-off-by: Vladimir Vid <vladimir.vid at sartura.hr> >> Cc: Luka Perkov <luka.perkov at sartura.hr> >> Cc: Stefan Roese <sr at denx.de> >> --- >> ? arch/arm/dts/armada-3720-uDPU.dts | 4 ++-- >> ? 1 file changed, 2 insertions(+), 2 deletions(-) >> > > Hi Stefan, > > I'm curious if there are any feedback or blockers on this patch? Sorry for the delay. I'll take care of it shortly. Thanks, Stefan > > Thanks, > Jakov > >> diff --git a/arch/arm/dts/armada-3720-uDPU.dts >> b/arch/arm/dts/armada-3720-uDPU.dts >> index 07c7b91175..7f4b8222f4 100644 >> --- a/arch/arm/dts/armada-3720-uDPU.dts >> +++ b/arch/arm/dts/armada-3720-uDPU.dts >> @@ -125,14 +125,14 @@ >> ? ð0 { >> ????? pinctrl-0 = <&pcie_pins>; >> ????? status = "okay"; >> -??? phy-mode = "2500base-x"; >> +??? phy-mode = "sgmii-2500"; >> ????? managed = "in-band-status"; >> ????? phy = <ðphy0>; >> ? }; >> ? ð1 { >> ????? status = "okay"; >> -??? phy-mode = "2500base-x"; >> +??? phy-mode = "sgmii-2500"; >> ????? managed = "in-band-status"; >> ????? phy = <ðphy1>; >> ? }; >> > > Viele Gr??e, Stefan
On 12.05.20 12:02, Jakov Petrina wrote: > Commit f49ac7e1c4 switched the default PHY speed to 3.125Gbit to resolve > issues with SFP modules. However, U-Boot does not have a "2500base-x" > phy-mode. > > Resolve this by using "sgmii-2500" instead. > > Signed-off-by: Jakov Petrina <jakov.petrina at sartura.hr> > Signed-off-by: Vladimir Vid <vladimir.vid at sartura.hr> > Cc: Luka Perkov <luka.perkov at sartura.hr> > Cc: Stefan Roese <sr at denx.de> Applied to u-boot-marvell/master Thanks, Stefan
diff --git a/arch/arm/dts/armada-3720-uDPU.dts b/arch/arm/dts/armada-3720-uDPU.dts index 07c7b91175..7f4b8222f4 100644 --- a/arch/arm/dts/armada-3720-uDPU.dts +++ b/arch/arm/dts/armada-3720-uDPU.dts @@ -125,14 +125,14 @@ ð0 { pinctrl-0 = <&pcie_pins>; status = "okay"; - phy-mode = "2500base-x"; + phy-mode = "sgmii-2500"; managed = "in-band-status"; phy = <ðphy0>; }; ð1 { status = "okay"; - phy-mode = "2500base-x"; + phy-mode = "sgmii-2500"; managed = "in-band-status"; phy = <ðphy1>; };