diff mbox series

[v2,01/12] wcn36xx: Add VHT fields to parameter data structures

Message ID 20200829033908.2167689-2-bryan.odonoghue@linaro.org
State New
Headers show
Series wcn36xx: Add support for extended V1 SMD parameter passing | expand

Commit Message

Bryan O'Donoghue Aug. 29, 2020, 3:38 a.m. UTC 
In order to pass VHT parameters to wcn3680 we need to use a super-set of
the V1 data-structures with additional VHT parameters tacked on.

This patch adds the additional fields to the STA and BSS parameter
structures with some utility macros to make calculation of the structure
size easier.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

---
 drivers/net/wireless/ath/wcn36xx/hal.h | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

-- 
2.27.0


_______________________________________________
wcn36xx mailing list
wcn36xx@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/wcn36xx

Comments

Kalle Valo Sept. 2, 2020, 8:59 a.m. UTC | #1 
Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:

> In order to pass VHT parameters to wcn3680 we need to use a super-set of

> the V1 data-structures with additional VHT parameters tacked on.

> 

> This patch adds the additional fields to the STA and BSS parameter

> structures with some utility macros to make calculation of the structure

> size easier.

> 

> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>


New warnings:

drivers/net/wireless/ath/wcn36xx/smd.c:1257:1: warning: 'wcn36xx_smd_set_sta_params_v1' defined but not used [-Wunused-function]
 1257 | wcn36xx_smd_set_sta_params_v1(struct wcn36xx *wcn,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/wcn36xx/smd.c:150:1: warning: 'wcn36xx_smd_set_bss_vht_params' defined but not used [-Wunused-function]
  150 | wcn36xx_smd_set_bss_vht_params(struct ieee80211_vif *vif,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

12 patches set to Changes Requested.

11743937 [v2,01/12] wcn36xx: Add VHT fields to parameter data structures
11743997 [v2,02/12] wcn36xx: Use V1 data structure to store supported rates
11743939 [v2,03/12] wcn36xx: Add wcn36xx_set_default_rates_v1
11743977 [v2,04/12] wcn36xx: Add VHT rates to wcn36xx_update_allowed_rates()
11743963 [v2,05/12] wcn36xx: Add wcn36xx_smd_set_sta_default_vht_params()
11743943 [v2,06/12] wcn36xx: Add wcn36xx_smd_set_sta_default_ht_ldpc_params()
11743945 [v2,07/12] wcn36xx: Add wcn36xx_smd_set_sta_vht_params()
11743951 [v2,08/12] wcn36xx: Add wcn36xx_smd_set_sta_ht_ldpc_params()
11743949 [v2,09/12] wcn36xx: Add wcn36xx_smd_set_bss_vht_params()
11743947 [v2,10/12] wcn36xx: Add wrapper function wcn36xx_smd_set_sta_params_v1()
11743961 [v2,11/12] wcn36xx: Define INIT_HAL_MSG_V1()
11743953 [v2,12/12] wcn36xx: Convert to VHT parameter structure on wcn3680

-- 
https://patchwork.kernel.org/patch/11743937/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Kalle Valo Sept. 2, 2020, 8:59 a.m. UTC | #2 
Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:

> In order to pass VHT parameters to wcn3680 we need to use a super-set of

> the V1 data-structures with additional VHT parameters tacked on.

> 

> This patch adds the additional fields to the STA and BSS parameter

> structures with some utility macros to make calculation of the structure

> size easier.

> 

> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>


New warnings:

drivers/net/wireless/ath/wcn36xx/smd.c:1257:1: warning: 'wcn36xx_smd_set_sta_params_v1' defined but not used [-Wunused-function]
 1257 | wcn36xx_smd_set_sta_params_v1(struct wcn36xx *wcn,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/wcn36xx/smd.c:150:1: warning: 'wcn36xx_smd_set_bss_vht_params' defined but not used [-Wunused-function]
  150 | wcn36xx_smd_set_bss_vht_params(struct ieee80211_vif *vif,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

12 patches set to Changes Requested.

11743937 [v2,01/12] wcn36xx: Add VHT fields to parameter data structures
11743997 [v2,02/12] wcn36xx: Use V1 data structure to store supported rates
11743939 [v2,03/12] wcn36xx: Add wcn36xx_set_default_rates_v1
11743977 [v2,04/12] wcn36xx: Add VHT rates to wcn36xx_update_allowed_rates()
11743963 [v2,05/12] wcn36xx: Add wcn36xx_smd_set_sta_default_vht_params()
11743943 [v2,06/12] wcn36xx: Add wcn36xx_smd_set_sta_default_ht_ldpc_params()
11743945 [v2,07/12] wcn36xx: Add wcn36xx_smd_set_sta_vht_params()
11743951 [v2,08/12] wcn36xx: Add wcn36xx_smd_set_sta_ht_ldpc_params()
11743949 [v2,09/12] wcn36xx: Add wcn36xx_smd_set_bss_vht_params()
11743947 [v2,10/12] wcn36xx: Add wrapper function wcn36xx_smd_set_sta_params_v1()
11743961 [v2,11/12] wcn36xx: Define INIT_HAL_MSG_V1()
11743953 [v2,12/12] wcn36xx: Convert to VHT parameter structure on wcn3680

-- 
https://patchwork.kernel.org/patch/11743937/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
wcn36xx mailing list
wcn36xx@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/wcn36xx
Bryan O'Donoghue Sept. 2, 2020, 9:39 a.m. UTC | #3 
On 02/09/2020 09:59, Kalle Valo wrote:
> Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:

> 

>> In order to pass VHT parameters to wcn3680 we need to use a super-set of

>> the V1 data-structures with additional VHT parameters tacked on.

>>

>> This patch adds the additional fields to the STA and BSS parameter

>> structures with some utility macros to make calculation of the structure

>> size easier.

>>

>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

> 

> New warnings:

> 

> drivers/net/wireless/ath/wcn36xx/smd.c:1257:1: warning: 'wcn36xx_smd_set_sta_params_v1' defined but not used [-Wunused-function]

>   1257 | wcn36xx_smd_set_sta_params_v1(struct wcn36xx *wcn,

>        | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

> drivers/net/wireless/ath/wcn36xx/smd.c:150:1: warning: 'wcn36xx_smd_set_bss_vht_params' defined but not used [-Wunused-function]

>    150 | wcn36xx_smd_set_bss_vht_params(struct ieee80211_vif *vif,

>        | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


I'm declaring a series of functions in patches for later use, in patches 
03-10.

Do you want those squashed into the patch/patches where they are first 
used ?
Kalle Valo Sept. 2, 2020, 12:19 p.m. UTC | #4 
Bryan O'Donoghue <bryan.odonoghue@linaro.org> writes:

> On 02/09/2020 09:59, Kalle Valo wrote:

>> Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:

>>

>>> In order to pass VHT parameters to wcn3680 we need to use a super-set of

>>> the V1 data-structures with additional VHT parameters tacked on.

>>>

>>> This patch adds the additional fields to the STA and BSS parameter

>>> structures with some utility macros to make calculation of the structure

>>> size easier.

>>>

>>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

>>

>> New warnings:

>>

>> drivers/net/wireless/ath/wcn36xx/smd.c:1257:1: warning:

>> 'wcn36xx_smd_set_sta_params_v1' defined but not used

>> [-Wunused-function]

>>   1257 | wcn36xx_smd_set_sta_params_v1(struct wcn36xx *wcn,

>>        | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

>> drivers/net/wireless/ath/wcn36xx/smd.c:150:1: warning:

>> 'wcn36xx_smd_set_bss_vht_params' defined but not used

>> [-Wunused-function]

>>    150 | wcn36xx_smd_set_bss_vht_params(struct ieee80211_vif *vif,

>>        | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

>

> I'm declaring a series of functions in patches for later use, in

> patches 03-10.

>

> Do you want those squashed into the patch/patches where they are first

> used ?


Yeah, squashing them is better. Every patch should compile on it's own
and be warning free. Kbuild bot will even check that and report if there
are warnings in-between patches.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
wcn36xx mailing list
wcn36xx@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/wcn36xx
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/wcn36xx/hal.h b/drivers/net/wireless/ath/wcn36xx/hal.h
index 573799274a02..3cceeaf0136f 100644
--- a/drivers/net/wireless/ath/wcn36xx/hal.h
+++ b/drivers/net/wireless/ath/wcn36xx/hal.h
@@ -1592,9 +1592,15 @@  struct wcn36xx_hal_config_sta_params_v1 {
 	u8 reserved:4;
 
 	/* These rates are the intersection of peer and self capabilities. */
-	struct wcn36xx_hal_supported_rates supported_rates;
+	struct wcn36xx_hal_supported_rates_v1 supported_rates;
+
+	u8 vht_capable;
+	u8 vht_tx_channel_width_set;
+
 } __packed;
 
+#define WCN36XX_DIFF_STA_PARAMS_V1_NOVHT 10
+
 struct wcn36xx_hal_config_sta_req_msg_v1 {
 	struct wcn36xx_hal_msg_header header;
 	struct wcn36xx_hal_config_sta_params_v1 sta_params;
@@ -2015,8 +2021,14 @@  struct wcn36xx_hal_config_bss_params_v1 {
 	 *  "STA context"
 	 */
 	struct wcn36xx_hal_config_sta_params_v1 sta;
+
+	u8 vht_capable;
+	u8 vht_tx_channel_width_set;
+
 } __packed;
 
+#define WCN36XX_DIFF_BSS_PARAMS_V1_NOVHT (WCN36XX_DIFF_STA_PARAMS_V1_NOVHT + 2)
+
 struct wcn36xx_hal_config_bss_req_msg_v1 {
 	struct wcn36xx_hal_msg_header header;
 	struct wcn36xx_hal_config_bss_params_v1 bss_params;