| Message ID | 20201014072555.12515-1-chen.zhang@intel.com |
|---|---|
| Headers | show |
| Series | COLO project queued patches 20-Oct | expand |
On 2020/10/14 下午3:25, Zhang Chen wrote: > From: Zhang Chen <chen.zhang@intel.com> > > Hi Jason, this series include latest COLO related patches. > please check and merge it. > > Thanks > Zhang Chen Hi: I want to merge but I don't get patch 10/10. Is that lost during posting? Thanks > > Li Zhijian (2): > colo-compare: fix missing compare_seq initialization > colo-compare: check mark in mutual exclusion > > Pan Nengyuan (1): > net/filter-rewriter: destroy g_hash_table in colo_rewriter_cleanup > > Rao, Lei (3): > Optimize seq_sorter function for colo-compare > Reduce the time of checkpoint for COLO > Fix the qemu crash when guest shutdown in COLO mode > > Zhang Chen (4): > net/colo-compare.c: Fix compare_timeout format issue > net/colo-compare.c: Change the timer clock type > net/colo-compare.c: Add secondary old packet detection > net/colo-compare.c: Increase default queued packet scan frequency > > migration/ram.c | 14 ++++++++++- > net/colo-compare.c | 57 ++++++++++++++++++++++--------------------- > net/colo.c | 5 +--- > net/filter-rewriter.c | 2 ++ > softmmu/vl.c | 1 + > 5 files changed, 46 insertions(+), 33 deletions(-) >
> -----Original Message----- > From: Jason Wang <jasowang@redhat.com> > Sent: Thursday, October 15, 2020 3:56 PM > To: Zhang, Chen <chen.zhang@intel.com>; qemu-dev <qemu- > devel@nongnu.org> > Cc: Zhang Chen <zhangckid@gmail.com> > Subject: Re: [PATCH 00/10] COLO project queued patches 20-Oct > > > On 2020/10/14 下午3:25, Zhang Chen wrote: > > From: Zhang Chen <chen.zhang@intel.com> > > > > Hi Jason, this series include latest COLO related patches. > > please check and merge it. > > > > Thanks > > Zhang Chen > > > Hi: > > I want to merge but I don't get patch 10/10. > > Is that lost during posting? Oh, Sorry I missed it. Already resend it: [PATCH 10/10] net/colo-compare.c: Increase default queued packet scan frequency Thanks Chen > > Thanks > > > > > > Li Zhijian (2): > > colo-compare: fix missing compare_seq initialization > > colo-compare: check mark in mutual exclusion > > > > Pan Nengyuan (1): > > net/filter-rewriter: destroy g_hash_table in colo_rewriter_cleanup > > > > Rao, Lei (3): > > Optimize seq_sorter function for colo-compare > > Reduce the time of checkpoint for COLO > > Fix the qemu crash when guest shutdown in COLO mode > > > > Zhang Chen (4): > > net/colo-compare.c: Fix compare_timeout format issue > > net/colo-compare.c: Change the timer clock type > > net/colo-compare.c: Add secondary old packet detection > > net/colo-compare.c: Increase default queued packet scan frequency > > > > migration/ram.c | 14 ++++++++++- > > net/colo-compare.c | 57 ++++++++++++++++++++++--------------------- > > net/colo.c | 5 +--- > > net/filter-rewriter.c | 2 ++ > > softmmu/vl.c | 1 + > > 5 files changed, 46 insertions(+), 33 deletions(-) > >
On 10/14/20 9:25 AM, Zhang Chen wrote: > From: Li Zhijian <lizhijian@cn.fujitsu.com> > Please include: Fixes: f449c9e549c ("colo: compare the packet based on the tcp sequence number") Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com> > Signed-off-by: Zhang Chen <chen.zhang@intel.com> > Reviewed-by: Zhang Chen <chen.zhang@intel.com> > --- > net/colo.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/net/colo.c b/net/colo.c > index a6c66d829a..ef00609848 100644 > --- a/net/colo.c > +++ b/net/colo.c > @@ -133,14 +133,11 @@ void reverse_connection_key(ConnectionKey *key) > > Connection *connection_new(ConnectionKey *key) > { > - Connection *conn = g_slice_new(Connection); > + Connection *conn = g_slice_new0(Connection); > > conn->ip_proto = key->ip_proto; > conn->processing = false; > - conn->offset = 0; > conn->tcp_state = TCPS_CLOSED; > - conn->pack = 0; > - conn->sack = 0; > g_queue_init(&conn->primary_list); > g_queue_init(&conn->secondary_list); > >
On 2020/10/15 下午3:58, Zhang, Chen wrote: > >> -----Original Message----- >> From: Jason Wang <jasowang@redhat.com> >> Sent: Thursday, October 15, 2020 3:56 PM >> To: Zhang, Chen <chen.zhang@intel.com>; qemu-dev <qemu- >> devel@nongnu.org> >> Cc: Zhang Chen <zhangckid@gmail.com> >> Subject: Re: [PATCH 00/10] COLO project queued patches 20-Oct >> >> >> On 2020/10/14 下午3:25, Zhang Chen wrote: >>> From: Zhang Chen <chen.zhang@intel.com> >>> >>> Hi Jason, this series include latest COLO related patches. >>> please check and merge it. >>> >>> Thanks >>> Zhang Chen >> >> Hi: >> >> I want to merge but I don't get patch 10/10. >> >> Is that lost during posting? > Oh, Sorry I missed it. > Already resend it: > [PATCH 10/10] net/colo-compare.c: Increase default queued packet scan frequency > > Thanks > Chen It looks to me Philippe has some minor comments on some patches, please address them and send a new version. Thanks > >> Thanks >> >> >>> Li Zhijian (2): >>> colo-compare: fix missing compare_seq initialization >>> colo-compare: check mark in mutual exclusion >>> >>> Pan Nengyuan (1): >>> net/filter-rewriter: destroy g_hash_table in colo_rewriter_cleanup >>> >>> Rao, Lei (3): >>> Optimize seq_sorter function for colo-compare >>> Reduce the time of checkpoint for COLO >>> Fix the qemu crash when guest shutdown in COLO mode >>> >>> Zhang Chen (4): >>> net/colo-compare.c: Fix compare_timeout format issue >>> net/colo-compare.c: Change the timer clock type >>> net/colo-compare.c: Add secondary old packet detection >>> net/colo-compare.c: Increase default queued packet scan frequency >>> >>> migration/ram.c | 14 ++++++++++- >>> net/colo-compare.c | 57 ++++++++++++++++++++++--------------------- >>> net/colo.c | 5 +--- >>> net/filter-rewriter.c | 2 ++ >>> softmmu/vl.c | 1 + >>> 5 files changed, 46 insertions(+), 33 deletions(-) >>>
> -----Original Message----- > From: Jason Wang <jasowang@redhat.com> > Sent: Friday, October 16, 2020 10:24 AM > To: Zhang, Chen <chen.zhang@intel.com>; qemu-dev <qemu- > devel@nongnu.org> > Cc: Zhang Chen <zhangckid@gmail.com> > Subject: Re: [PATCH 00/10] COLO project queued patches 20-Oct > > > On 2020/10/15 下午3:58, Zhang, Chen wrote: > > > >> -----Original Message----- > >> From: Jason Wang <jasowang@redhat.com> > >> Sent: Thursday, October 15, 2020 3:56 PM > >> To: Zhang, Chen <chen.zhang@intel.com>; qemu-dev <qemu- > >> devel@nongnu.org> > >> Cc: Zhang Chen <zhangckid@gmail.com> > >> Subject: Re: [PATCH 00/10] COLO project queued patches 20-Oct > >> > >> > >> On 2020/10/14 下午3:25, Zhang Chen wrote: > >>> From: Zhang Chen <chen.zhang@intel.com> > >>> > >>> Hi Jason, this series include latest COLO related patches. > >>> please check and merge it. > >>> > >>> Thanks > >>> Zhang Chen > >> > >> Hi: > >> > >> I want to merge but I don't get patch 10/10. > >> > >> Is that lost during posting? > > Oh, Sorry I missed it. > > Already resend it: > > [PATCH 10/10] net/colo-compare.c: Increase default queued packet scan > > frequency > > > > Thanks > > Chen > > > It looks to me Philippe has some minor comments on some patches, please > address them and send a new version. Sure. I will update to V2. Thanks Chen > > Thanks > > > > > >> Thanks > >> > >> > >>> Li Zhijian (2): > >>> colo-compare: fix missing compare_seq initialization > >>> colo-compare: check mark in mutual exclusion > >>> > >>> Pan Nengyuan (1): > >>> net/filter-rewriter: destroy g_hash_table in > >>> colo_rewriter_cleanup > >>> > >>> Rao, Lei (3): > >>> Optimize seq_sorter function for colo-compare > >>> Reduce the time of checkpoint for COLO > >>> Fix the qemu crash when guest shutdown in COLO mode > >>> > >>> Zhang Chen (4): > >>> net/colo-compare.c: Fix compare_timeout format issue > >>> net/colo-compare.c: Change the timer clock type > >>> net/colo-compare.c: Add secondary old packet detection > >>> net/colo-compare.c: Increase default queued packet scan > >>> frequency > >>> > >>> migration/ram.c | 14 ++++++++++- > >>> net/colo-compare.c | 57 ++++++++++++++++++++++------------------- > -- > >>> net/colo.c | 5 +--- > >>> net/filter-rewriter.c | 2 ++ > >>> softmmu/vl.c | 1 + > >>> 5 files changed, 46 insertions(+), 33 deletions(-) > >>>
From: Zhang Chen <chen.zhang@intel.com> Hi Jason, this series include latest COLO related patches. please check and merge it. Thanks Zhang Chen Li Zhijian (2): colo-compare: fix missing compare_seq initialization colo-compare: check mark in mutual exclusion Pan Nengyuan (1): net/filter-rewriter: destroy g_hash_table in colo_rewriter_cleanup Rao, Lei (3): Optimize seq_sorter function for colo-compare Reduce the time of checkpoint for COLO Fix the qemu crash when guest shutdown in COLO mode Zhang Chen (4): net/colo-compare.c: Fix compare_timeout format issue net/colo-compare.c: Change the timer clock type net/colo-compare.c: Add secondary old packet detection net/colo-compare.c: Increase default queued packet scan frequency migration/ram.c | 14 ++++++++++- net/colo-compare.c | 57 ++++++++++++++++++++++--------------------- net/colo.c | 5 +--- net/filter-rewriter.c | 2 ++ softmmu/vl.c | 1 + 5 files changed, 46 insertions(+), 33 deletions(-)