diff mbox series

[v5,3/3] dt-bindings: media: ov772x: Document endpoint props

Message ID 20200910162055.614089-4-jacopo+renesas@jmondi.org
State Superseded
Headers show
Series dt-bindings: media: ov772x: Convert to json-schema | expand

Commit Message

Jacopo Mondi Sept. 10, 2020, 4:20 p.m. UTC
Document endpoint properties for the parallel bus type and
add them to the example.

Specify a few constraints:
- If the bus type is BT.656 no hsync or vsync polarities can be
  specified.
- If the bus width is 10 bits, not data-shift can be applied.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
 .../bindings/media/i2c/ovti,ov772x.yaml       | 44 +++++++++++++++++++
 1 file changed, 44 insertions(+)

Comments

Rob Herring (Arm) Sept. 15, 2020, 8:12 p.m. UTC | #1
On Thu, 10 Sep 2020 18:20:55 +0200, Jacopo Mondi wrote:
> Document endpoint properties for the parallel bus type and

> add them to the example.

> 

> Specify a few constraints:

> - If the bus type is BT.656 no hsync or vsync polarities can be

>   specified.

> - If the bus width is 10 bits, not data-shift can be applied.

> 

> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>

> ---

>  .../bindings/media/i2c/ovti,ov772x.yaml       | 44 +++++++++++++++++++

>  1 file changed, 44 insertions(+)

> 


Reviewed-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
index b034953b92e9..63b3779d7289 100644
--- a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
@@ -49,6 +49,45 @@  properties:
           bus-type:
             enum: [5, 6]
 
+          bus-width:
+            enum: [8, 10]
+            default: 10
+
+          data-shift:
+            enum: [0, 2]
+            default: 0
+
+          hsync-active:
+            enum: [0, 1]
+            default: 1
+
+          vsync-active:
+            enum: [0, 1]
+            default: 1
+
+          pclk-sample:
+            enum: [0, 1]
+            default: 1
+
+        allOf:
+          - if:
+              properties:
+                bus-type:
+                  const: 6
+            then:
+                properties:
+                  hsync-active: false
+                  vsync-active: false
+
+          - if:
+              properties:
+                bus-width:
+                  const: 10
+            then:
+                properties:
+                  data-shift:
+                    const: 0
+
         required:
           - bus-type
 
@@ -81,6 +120,11 @@  examples:
             port {
                 ov772x_0: endpoint {
                     bus-type = <5>;
+                    vsync-active = <0>;
+                    hsync-active = <0>;
+                    pclk-sample = <0>;
+                    bus-width = <8>;
+                    data-shift = <0>;
                     remote-endpoint = <&vcap1_in0>;
                 };
             };