| Message ID | 20200921162342.7348-7-krzk@kernel.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [01/25] media: i2c: imx214: simplify getting state container | expand |
Hi Krzysztof, Thanks for the patchset! I believe the I²C client has been dug up first as we've been dealing with I²C devices all the time, and it's been a pattern. I don't see that as a reason to reject the patches either though, it definitely cleans up the drivers. On Mon, Sep 21, 2020 at 06:23:24PM +0200, Krzysztof Kozlowski wrote: > If driver is built without ACPI, the struct acpi_device_id won't be > used: > > drivers/media/i2c/imx355.c:1836:36: warning: > 'imx355_acpi_ids' defined but not used [-Wunused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > drivers/media/i2c/imx355.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c > index 51245e71b411..8db287251f49 100644 > --- a/drivers/media/i2c/imx355.c > +++ b/drivers/media/i2c/imx355.c > @@ -1833,7 +1833,7 @@ static const struct dev_pm_ops imx355_pm_ops = { > SET_SYSTEM_SLEEP_PM_OPS(imx355_suspend, imx355_resume) > }; > > -static const struct acpi_device_id imx355_acpi_ids[] = { > +static const struct acpi_device_id imx355_acpi_ids[]__maybe_unused = { A space before __ perhaps? Albeit this seems to be all, I can address that while applying if that's ok. > { "SONY355A" }, > { /* sentinel */ } > };
On Tue, 22 Sep 2020 at 11:37, Sakari Ailus <sakari.ailus@linux.intel.com> wrote: > > Hi Krzysztof, > > Thanks for the patchset! > > I believe the I涎 client has been dug up first as we've been dealing with > I涎 devices all the time, and it's been a pattern. I don't see that as a > reason to reject the patches either though, it definitely cleans up the > drivers. > > On Mon, Sep 21, 2020 at 06:23:24PM +0200, Krzysztof Kozlowski wrote: > > If driver is built without ACPI, the struct acpi_device_id won't be > > used: > > > > drivers/media/i2c/imx355.c:1836:36: warning: > > 'imx355_acpi_ids' defined but not used [-Wunused-const-variable=] > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > drivers/media/i2c/imx355.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c > > index 51245e71b411..8db287251f49 100644 > > --- a/drivers/media/i2c/imx355.c > > +++ b/drivers/media/i2c/imx355.c > > @@ -1833,7 +1833,7 @@ static const struct dev_pm_ops imx355_pm_ops = { > > SET_SYSTEM_SLEEP_PM_OPS(imx355_suspend, imx355_resume) > > }; > > > > -static const struct acpi_device_id imx355_acpi_ids[] = { > > +static const struct acpi_device_id imx355_acpi_ids[]__maybe_unused = { > > A space before __ perhaps? > > Albeit this seems to be all, I can address that while applying if that's > ok. Yes, there should be a space here. Let me know if I should send v2. Best regards, Krzysztof
diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c index 51245e71b411..8db287251f49 100644 --- a/drivers/media/i2c/imx355.c +++ b/drivers/media/i2c/imx355.c @@ -1833,7 +1833,7 @@ static const struct dev_pm_ops imx355_pm_ops = { SET_SYSTEM_SLEEP_PM_OPS(imx355_suspend, imx355_resume) }; -static const struct acpi_device_id imx355_acpi_ids[] = { +static const struct acpi_device_id imx355_acpi_ids[]__maybe_unused = { { "SONY355A" }, { /* sentinel */ } };
If driver is built without ACPI, the struct acpi_device_id won't be used: drivers/media/i2c/imx355.c:1836:36: warning: 'imx355_acpi_ids' defined but not used [-Wunused-const-variable=] Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/media/i2c/imx355.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)