| Message ID | 20201029033802.15366-1-s-anna@ti.com |
|---|---|
| Headers | show |
| Series | Add R5F nodes on TI K3 AM65x and J721E SoCs | expand |
On 29/10/20 9:07 am, Suman Anna wrote: > Hi Nishanth, > > The TI K3 R5F remoteproc driver and bindings were merged into 5.10-rc1, > and this series adds the follow-on base dt nodes for the R5F remote > processors on TI K3 AM65x and J721E SoCs. Additional memory nodes were > also added to boot these processors successfully on applicable TI K3 > AM65x and J721E EVM boards. The series uses previously accepted mailbox > nodes. > > The patches follow slightly different convention between AM65x and > J721E. The reserved-memory nodes are added directly in the relevant > board dts file for AM65x boards, while they are added in the common > k3-j721e-som-p0.dtsi file for J721E SoCs following the similar addition > of K3 C66x and C71x DSP nodes in 5.10-rc1. > > Patches apply on top of your 5.10-rc1 based staging branch. > > I have validated the IPC functionality using System Firmware v2020.04a > and corresponding IPC example firmwares. Series looks good to me. Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com> On a side note: any reason not to add R5f nodes for J7200? Thanks and regards, Lokesh
On 11/6/20 5:43 AM, Lokesh Vutla wrote: > > > On 29/10/20 9:07 am, Suman Anna wrote: >> Hi Nishanth, >> >> The TI K3 R5F remoteproc driver and bindings were merged into 5.10-rc1, >> and this series adds the follow-on base dt nodes for the R5F remote >> processors on TI K3 AM65x and J721E SoCs. Additional memory nodes were >> also added to boot these processors successfully on applicable TI K3 >> AM65x and J721E EVM boards. The series uses previously accepted mailbox >> nodes. >> >> The patches follow slightly different convention between AM65x and >> J721E. The reserved-memory nodes are added directly in the relevant >> board dts file for AM65x boards, while they are added in the common >> k3-j721e-som-p0.dtsi file for J721E SoCs following the similar addition >> of K3 C66x and C71x DSP nodes in 5.10-rc1. >> >> Patches apply on top of your 5.10-rc1 based staging branch. >> >> I have validated the IPC functionality using System Firmware v2020.04a >> and corresponding IPC example firmwares. > > > Series looks good to me. > > Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com> > Thanks Lokesh. > On a side note: any reason not to add R5f nodes for J7200? J7200 nodes would have to wait until the corresponding dt-bindings and driver updates make it into mainline. They do use different compatibles, and I will post them in the next couple of weeks. regards Suman
On Wed, 28 Oct 2020 22:37:54 -0500, Suman Anna wrote: > The TI K3 R5F remoteproc driver and bindings were merged into 5.10-rc1, > and this series adds the follow-on base dt nodes for the R5F remote > processors on TI K3 AM65x and J721E SoCs. Additional memory nodes were > also added to boot these processors successfully on applicable TI K3 > AM65x and J721E EVM boards. The series uses previously accepted mailbox > nodes. > > [...] Hi Suman Anna, I have applied the following to branch ti-k3-dts-next on [1]. Thank you! [1/8] arm64: dts: ti: k3-am65-mcu: Add MCU domain R5F cluster node commit: 5bb9e0f6e8505e31159963150104569d9b8a8911 [2/8] arm64: dts: ti: k3-am654-base-board: Add mailboxes to R5Fs commit: 10332cd6bcf287e22dac875d121b73adb762f96b [3/8] arm64: dts: ti: k3-am654-base-board: Add DDR carveout memory nodes for R5Fs commit: 954ec5139db091ff51cec4bf57c42f9deebc8747 [4/8] arm64: dts: ti: k3-am654-base-board: Reserve memory for IPC between R5F cores commit: f82c5e0a8bc1311aee140bfed0888fc9a99afde0 [5/8] arm64: dts: ti: k3-j721e-mcu: Add MCU domain R5F cluster node commit: dd74c9459cf2c87c3143b4b9005b7c9056fccdb0 [6/8] arm64: dts: ti: k3-j721e-main: Add MAIN domain R5F cluster nodes commit: df445ff9de893146107d37e0cd5e542f800d9b39 [7/8] arm64: dts: ti: k3-j721e-som-p0: Add mailboxes to R5Fs commit: 2879b593c3784e5eafc67cae915d8b7d680455f3 [8/8] arm64: dts: ti: k3-j721e-som-p0: Add DDR carveout memory nodes for R5Fs commit: 0f191152bcba6758804eed4f6463f9bd32bdbfdb Please note: * I understand the complexity of the code requiring the split up in the incremental patches, so I believe it has a case for us to do the same. * Special note on MCU R5: there are cases on J721e, J7200 and future devices where "device management" functionality will run on MCU R5 core 0, which means it is capable of running special firmware that may not respond on mailbox at all.. The assumption is that the driver is capable of detecting and handling such scenarios and this is a hardware description (as it should be). All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. [1] git://git.kernel.org/pub/scm/linux/kernel/git/nmenon/linux.git -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
On 11/12/20 11:48 AM, Nishanth Menon wrote: > On Wed, 28 Oct 2020 22:37:54 -0500, Suman Anna wrote: >> The TI K3 R5F remoteproc driver and bindings were merged into 5.10-rc1, >> and this series adds the follow-on base dt nodes for the R5F remote >> processors on TI K3 AM65x and J721E SoCs. Additional memory nodes were >> also added to boot these processors successfully on applicable TI K3 >> AM65x and J721E EVM boards. The series uses previously accepted mailbox >> nodes. >> >> [...] > > Hi Suman Anna, > > I have applied the following to branch ti-k3-dts-next on [1]. > Thank you! > > [1/8] arm64: dts: ti: k3-am65-mcu: Add MCU domain R5F cluster node > commit: 5bb9e0f6e8505e31159963150104569d9b8a8911 > [2/8] arm64: dts: ti: k3-am654-base-board: Add mailboxes to R5Fs > commit: 10332cd6bcf287e22dac875d121b73adb762f96b > [3/8] arm64: dts: ti: k3-am654-base-board: Add DDR carveout memory nodes for R5Fs > commit: 954ec5139db091ff51cec4bf57c42f9deebc8747 > [4/8] arm64: dts: ti: k3-am654-base-board: Reserve memory for IPC between R5F cores > commit: f82c5e0a8bc1311aee140bfed0888fc9a99afde0 > [5/8] arm64: dts: ti: k3-j721e-mcu: Add MCU domain R5F cluster node > commit: dd74c9459cf2c87c3143b4b9005b7c9056fccdb0 > [6/8] arm64: dts: ti: k3-j721e-main: Add MAIN domain R5F cluster nodes > commit: df445ff9de893146107d37e0cd5e542f800d9b39 > [7/8] arm64: dts: ti: k3-j721e-som-p0: Add mailboxes to R5Fs > commit: 2879b593c3784e5eafc67cae915d8b7d680455f3 > [8/8] arm64: dts: ti: k3-j721e-som-p0: Add DDR carveout memory nodes for R5Fs > commit: 0f191152bcba6758804eed4f6463f9bd32bdbfdb > > > Please note: > * I understand the complexity of the code requiring the split up in the > incremental patches, so I believe it has a case for us to do the same. > * Special note on MCU R5: there are cases on J721e, J7200 and future devices > where "device management" functionality will run on MCU R5 core 0, which > means it is capable of running special firmware that may not respond on > mailbox at all.. The assumption is that the driver is capable of detecting > and handling such scenarios and this is a hardware description (as it > should be). Yep, this is understood. > > All being well this means that it will be integrated into the linux-next > tree (usually sometime in the next 24 hours) and sent up the chain during > the next merge window (or sooner if it is a relevant bug fix), however if > problems are discovered then the patch may be dropped or reverted. > > You may get further e-mails resulting from automated or manual testing > and review of the tree, please engage with people reporting problems and > send followup patches addressing any issues that are reported if needed. > > If any updates are required or you are submitting further changes they > should be sent as incremental updates against current git, existing > patches will not be replaced. > > Please add any relevant lists and maintainers to the CCs when replying > to this mail. > > [1] git://git.kernel.org/pub/scm/linux/kernel/git/nmenon/linux.git > Thanks, Nishanth! regards Suman
Hi Nishanth, The TI K3 R5F remoteproc driver and bindings were merged into 5.10-rc1, and this series adds the follow-on base dt nodes for the R5F remote processors on TI K3 AM65x and J721E SoCs. Additional memory nodes were also added to boot these processors successfully on applicable TI K3 AM65x and J721E EVM boards. The series uses previously accepted mailbox nodes. The patches follow slightly different convention between AM65x and J721E. The reserved-memory nodes are added directly in the relevant board dts file for AM65x boards, while they are added in the common k3-j721e-som-p0.dtsi file for J721E SoCs following the similar addition of K3 C66x and C71x DSP nodes in 5.10-rc1. Patches apply on top of your 5.10-rc1 based staging branch. I have validated the IPC functionality using System Firmware v2020.04a and corresponding IPC example firmwares. regards Suman Suman Anna (8): arm64: dts: ti: k3-am65-mcu: Add MCU domain R5F cluster node arm64: dts: ti: k3-am654-base-board: Add mailboxes to R5Fs arm64: dts: ti: k3-am654-base-board: Add DDR carveout memory nodes for R5Fs arm64: dts: ti: k3-am654-base-board: Reserve memory for IPC between R5F cores arm64: dts: ti: k3-j721e-mcu: Add MCU domain R5F cluster node arm64: dts: ti: k3-j721e-main: Add MAIN domain R5F cluster nodes arm64: dts: ti: k3-j721e-som-p0: Add mailboxes to R5Fs arm64: dts: ti: k3-j721e-som-p0: Add DDR carveout memory nodes for R5Fs arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 42 ++++++- .../arm64/boot/dts/ti/k3-am654-base-board.dts | 45 ++++++- arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 82 ++++++++++++- .../boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 42 ++++++- arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi | 110 +++++++++++++++++- 5 files changed, 316 insertions(+), 5 deletions(-)