| Message ID | 20201119125304.1279-1-aisheng.dong@nxp.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/3] dt-bindings: mmc: imx: fix the wrongly dropped imx8qm compatible string | expand |
On Thu, Nov 19, 2020 at 08:53:02PM +0800, Dong Aisheng wrote: > The compatible string "fsl,imx8qm-usdhc" was wrongly dropped in patch: > 80fd350b9590 ("dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 compatible matching") > Add it back. Although the compatible was dropped, by why wrongly? Please describe it. The compatible is nowhere to be found, it is not used. Best regards, Krzysztof > > Cc: Haibo Chen <haibo.chen@nxp.com> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: Ulf Hansson <ulf.hansson@linaro.org> > Cc: linux-mmc@vger.kernel.org > Fixes: 80fd350b9590 ("dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 compatible matching") > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > --- > Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 1 + > 1 file changed, 1 insertion(+) >
On Thu, Nov 19, 2020 at 08:53:04PM +0800, Dong Aisheng wrote: > Add imx8qm support > > Cc: Rob Herring <robh+dt@kernel.org> > Cc: devicetree@vger.kernel.org > Cc: Shawn Guo <shawnguo@kernel.org> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > --- > Documentation/devicetree/bindings/mailbox/fsl,mu.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml > index 15cef82cd356..1a3dff277e2b 100644 > --- a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml > +++ b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml > @@ -34,12 +34,15 @@ properties: > - fsl,imx8mm-mu > - fsl,imx8mn-mu > - fsl,imx8mp-mu > + - fsl,imx8qm-mu You add the compatible below, so decide which one is it. Please provide also users of this compatible - DTS. Best regards, Krzysztof > - fsl,imx8qxp-mu > - const: fsl,imx6sx-mu > - description: To communicate with i.MX8 SCU with fast IPC > items: > - const: fsl,imx8-mu-scu > - - const: fsl,imx8qxp-mu > + - enum: > + - fsl,imx8qm-mu > + - fsl,imx8qxp-mu > - const: fsl,imx6sx-mu > > reg: > -- > 2.23.0 >
> From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Thursday, November 19, 2020 9:17 PM > > On Thu, Nov 19, 2020 at 08:53:02PM +0800, Dong Aisheng wrote: > > The compatible string "fsl,imx8qm-usdhc" was wrongly dropped in patch: > > 80fd350b9590 ("dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 compatible > > matching") Add it back. > > Although the compatible was dropped, by why wrongly? Please describe it. > The compatible is nowhere to be found, it is not used. The DT patch using it is still under review. So we need it. Regards Aisheng > > Best regards, > Krzysztof > > > > > Cc: Haibo Chen <haibo.chen@nxp.com> > > Cc: Krzysztof Kozlowski <krzk@kernel.org> > > Cc: Ulf Hansson <ulf.hansson@linaro.org> > > Cc: linux-mmc@vger.kernel.org > > Fixes: 80fd350b9590 ("dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 > > compatible matching") > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > > --- > > Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 1 + > > 1 file changed, 1 insertion(+) > >
On Thu, Nov 19, 2020 at 03:21:59PM +0000, Aisheng Dong wrote: > > From: Krzysztof Kozlowski <krzk@kernel.org> > > Sent: Thursday, November 19, 2020 9:17 PM > > > > On Thu, Nov 19, 2020 at 08:53:02PM +0800, Dong Aisheng wrote: > > > The compatible string "fsl,imx8qm-usdhc" was wrongly dropped in patch: > > > 80fd350b9590 ("dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 compatible > > > matching") Add it back. > > > > Although the compatible was dropped, by why wrongly? Please describe it. > > The compatible is nowhere to be found, it is not used. > > The DT patch using it is still under review. So we need it. It looks like other patches here follow similar process of sending and applying dt-bindings separately from patches with users of these bindings. Please don't do it like this. Send the bindings as the first patch in the series implementing the users (so usually the series with driver and DTS changes). The new bindings then are applied by the driver subsystem maintainer. Best regards, Krzysztof
On Thu, 19 Nov 2020 at 16:25, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Thu, Nov 19, 2020 at 03:21:59PM +0000, Aisheng Dong wrote: > > > From: Krzysztof Kozlowski <krzk@kernel.org> > > > Sent: Thursday, November 19, 2020 9:17 PM > > > > > > On Thu, Nov 19, 2020 at 08:53:02PM +0800, Dong Aisheng wrote: > > > > The compatible string "fsl,imx8qm-usdhc" was wrongly dropped in patch: > > > > 80fd350b9590 ("dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 compatible > > > > matching") Add it back. > > > > > > Although the compatible was dropped, by why wrongly? Please describe it. > > > The compatible is nowhere to be found, it is not used. > > > > The DT patch using it is still under review. So we need it. Where? Is there a corresponding update to the mmc driver? > > It looks like other patches here follow similar process of sending > and applying dt-bindings separately from patches with users of these > bindings. Please don't do it like this. Send the bindings as the first > patch in the series implementing the users (so usually the series with > driver and DTS changes). The new bindings then are applied by the > driver subsystem maintainer. Yep, I fully agree, that's the preferred approach. Perhaps it's simply better if the series is reposted to linux-mmc (including the DT doc). Kind regards Uffe
> From: Ulf Hansson <ulf.hansson@linaro.org> > Sent: Monday, November 23, 2020 8:28 PM > > On Thu, 19 Nov 2020 at 16:25, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > > On Thu, Nov 19, 2020 at 03:21:59PM +0000, Aisheng Dong wrote: > > > > From: Krzysztof Kozlowski <krzk@kernel.org> > > > > Sent: Thursday, November 19, 2020 9:17 PM > > > > > > > > On Thu, Nov 19, 2020 at 08:53:02PM +0800, Dong Aisheng wrote: > > > > > The compatible string "fsl,imx8qm-usdhc" was wrongly dropped in > patch: > > > > > 80fd350b9590 ("dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 > > > > > compatible > > > > > matching") Add it back. > > > > > > > > Although the compatible was dropped, by why wrongly? Please describe it. > > > > The compatible is nowhere to be found, it is not used. > > > > > > The DT patch using it is still under review. So we need it. > > Where? Is there a corresponding update to the mmc driver? > > > > > It looks like other patches here follow similar process of sending and > > applying dt-bindings separately from patches with users of these > > bindings. Please don't do it like this. Send the bindings as the first > > patch in the series implementing the users (so usually the series with > > driver and DTS changes). The new bindings then are applied by the > > driver subsystem maintainer. > > Yep, I fully agree, that's the preferred approach. > > Perhaps it's simply better if the series is reposted to linux-mmc (including the DT > doc). I'm going to resend the series with dt-binding patches first. Thanks for the advice. Regards Aisheng > > Kind regards > Uffe
diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml index e71d13c2d109..802c9df23752 100644 --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml @@ -39,6 +39,7 @@ properties: - fsl,imx8mn-usdhc - fsl,imx8mp-usdhc - fsl,imx8mq-usdhc + - fsl,imx8qm-usdhc - fsl,imx8qxp-usdhc - const: fsl,imx7d-usdhc
The compatible string "fsl,imx8qm-usdhc" was wrongly dropped in patch: 80fd350b9590 ("dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 compatible matching") Add it back. Cc: Haibo Chen <haibo.chen@nxp.com> Cc: Krzysztof Kozlowski <krzk@kernel.org> Cc: Ulf Hansson <ulf.hansson@linaro.org> Cc: linux-mmc@vger.kernel.org Fixes: 80fd350b9590 ("dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 compatible matching") Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> --- Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 1 + 1 file changed, 1 insertion(+)