diff mbox series

ASoC: audio-graph-card: Drop remote-endpoint as required property

Message ID 1607498532-19518-1-git-send-email-spujar@nvidia.com
State Superseded
Headers show
Series ASoC: audio-graph-card: Drop remote-endpoint as required property | expand

Commit Message

Sameer Pujar Dec. 9, 2020, 7:22 a.m. UTC
The remote-endpoint may not be available if it is part of some
pluggable module. One such example would be an audio card, the
Codec endpoint will not be available until it is plugged in.
Hence drop 'remote-endpoint' as a required property.

Cc: Rob Herring <robh@kernel.org>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Sameer Pujar <spujar@nvidia.com>
---
 Documentation/devicetree/bindings/sound/audio-graph-port.yaml | 3 ---
 1 file changed, 3 deletions(-)

Comments

Rob Herring (Arm) Dec. 10, 2020, 2:15 a.m. UTC | #1
On Wed, Dec 09, 2020 at 12:52:12PM +0530, Sameer Pujar wrote:
> The remote-endpoint may not be available if it is part of some
> pluggable module. One such example would be an audio card, the
> Codec endpoint will not be available until it is plugged in.
> Hence drop 'remote-endpoint' as a required property.

Please hold off on this. I have more changes coming.

> 
> Cc: Rob Herring <robh@kernel.org>
> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> ---
>  Documentation/devicetree/bindings/sound/audio-graph-port.yaml | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> index 2005014..766e910 100644
> --- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> +++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> @@ -71,9 +71,6 @@ properties:
>              description: CPU to Codec rate channels.
>              $ref: /schemas/types.yaml#/definitions/uint32
>  
> -        required:
> -          - remote-endpoint
> -
>    ports:
>      description: multi OF-Graph subnode
>      type: object
> -- 
> 2.7.4
>
Sameer Pujar Dec. 10, 2020, 2:44 p.m. UTC | #2
Hi Rob,

>> The remote-endpoint may not be available if it is part of some
>> pluggable module. One such example would be an audio card, the
>> Codec endpoint will not be available until it is plugged in.
>> Hence drop 'remote-endpoint' as a required property.
> Please hold off on this. I have more changes coming.

OK, I will wait for your patch. Kindly note that this is currently 
blocking series 
https://patchwork.kernel.org/project/alsa-devel/list/?series=391735&state=*

Thanks,
Sameer.
Sameer Pujar Dec. 28, 2020, 6:45 a.m. UTC | #3
Hi Rob,

>>> The remote-endpoint may not be available if it is part of some
>>> pluggable module. One such example would be an audio card, the
>>> Codec endpoint will not be available until it is plugged in.
>>> Hence drop 'remote-endpoint' as a required property.
>> Please hold off on this. I have more changes coming.

Is this a good time to push for audio-graph-port changes?
Sameer Pujar Jan. 11, 2021, 4:49 a.m. UTC | #4
Hi Rob,


On 12/10/2020 8:14 PM, Sameer Pujar wrote:
> Hi Rob,
>
>>> The remote-endpoint may not be available if it is part of some
>>> pluggable module. One such example would be an audio card, the
>>> Codec endpoint will not be available until it is plugged in.
>>> Hence drop 'remote-endpoint' as a required property.
>> Please hold off on this. I have more changes coming.

Sorry to bother you again. Is it possible if we take this patch now and 
your remaining changes can come later? This would help to unblock below 
series, which is pending quite some time now.

>
> OK, I will wait for your patch. Kindly note that this is currently 
> blocking series 
> https://patchwork.kernel.org/project/alsa-devel/list/?series=391735&state=*
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
index 2005014..766e910 100644
--- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
+++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
@@ -71,9 +71,6 @@  properties:
             description: CPU to Codec rate channels.
             $ref: /schemas/types.yaml#/definitions/uint32
 
-        required:
-          - remote-endpoint
-
   ports:
     description: multi OF-Graph subnode
     type: object