diff mbox series

[v3,2/5] dt-bindings: pinctrl: k3: Introduce pinmux definitions for AM64

Message ID 20210120202532.9011-3-d-gerlach@ti.com
State Accepted
Commit 1818a28fffda55c7ec3235db6ed771c6fc737fa1
Headers show
Series arm64: Initial support for Texas Instruments AM642 Platform | expand

Commit Message

Dave Gerlach Jan. 20, 2021, 8:25 p.m. UTC
Add pinctrl macros for AM64 SoC. These macro definitions are similar to
that of previous platforms, but adding new definitions to avoid any
naming confusions in the soc dts files.

Unlike what checkpatch insists, we do not need parentheses enclosing
the values for this macro as we do intend it to generate two separate
values as has been done for other similar platforms.

Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
---
 include/dt-bindings/pinctrl/k3.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Nishanth Menon Jan. 25, 2021, 2:39 p.m. UTC | #1
On 14:25-20210120, Dave Gerlach wrote:
> Add pinctrl macros for AM64 SoC. These macro definitions are similar to

> that of previous platforms, but adding new definitions to avoid any

> naming confusions in the soc dts files.

> 

> Unlike what checkpatch insists, we do not need parentheses enclosing

> the values for this macro as we do intend it to generate two separate

> values as has been done for other similar platforms.

> 

> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>


I need Rob's ack to apply this patch.

> ---

>  include/dt-bindings/pinctrl/k3.h | 5 ++++-

>  1 file changed, 4 insertions(+), 1 deletion(-)

> 

> diff --git a/include/dt-bindings/pinctrl/k3.h b/include/dt-bindings/pinctrl/k3.h

> index b0eea7cc6e23..e085f102b283 100644

> --- a/include/dt-bindings/pinctrl/k3.h

> +++ b/include/dt-bindings/pinctrl/k3.h

> @@ -3,7 +3,7 @@

>   * This header provides constants for pinctrl bindings for TI's K3 SoC

>   * family.

>   *

> - * Copyright (C) 2018 Texas Instruments Incorporated - https://www.ti.com/

> + * Copyright (C) 2018-2021 Texas Instruments Incorporated - https://www.ti.com/

>   */

>  #ifndef _DT_BINDINGS_PINCTRL_TI_K3_H

>  #define _DT_BINDINGS_PINCTRL_TI_K3_H

> @@ -35,4 +35,7 @@

>  #define J721E_IOPAD(pa, val, muxmode)		(((pa) & 0x1fff)) ((val) | (muxmode))

>  #define J721E_WKUP_IOPAD(pa, val, muxmode)	(((pa) & 0x1fff)) ((val) | (muxmode))

>  

> +#define AM64X_IOPAD(pa, val, muxmode)		(((pa) & 0x1fff)) ((val) | (muxmode))

> +#define AM64X_MCU_IOPAD(pa, val, muxmode)	(((pa) & 0x1fff)) ((val) | (muxmode))

> +

>  #endif

> -- 

> 2.28.0

> 


-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
Rob Herring (Arm) Feb. 9, 2021, 2:34 a.m. UTC | #2
On Wed, 20 Jan 2021 14:25:29 -0600, Dave Gerlach wrote:
> Add pinctrl macros for AM64 SoC. These macro definitions are similar to

> that of previous platforms, but adding new definitions to avoid any

> naming confusions in the soc dts files.

> 

> Unlike what checkpatch insists, we do not need parentheses enclosing

> the values for this macro as we do intend it to generate two separate

> values as has been done for other similar platforms.

> 

> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>

> ---

>  include/dt-bindings/pinctrl/k3.h | 5 ++++-

>  1 file changed, 4 insertions(+), 1 deletion(-)

> 


Acked-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/include/dt-bindings/pinctrl/k3.h b/include/dt-bindings/pinctrl/k3.h
index b0eea7cc6e23..e085f102b283 100644
--- a/include/dt-bindings/pinctrl/k3.h
+++ b/include/dt-bindings/pinctrl/k3.h
@@ -3,7 +3,7 @@ 
  * This header provides constants for pinctrl bindings for TI's K3 SoC
  * family.
  *
- * Copyright (C) 2018 Texas Instruments Incorporated - https://www.ti.com/
+ * Copyright (C) 2018-2021 Texas Instruments Incorporated - https://www.ti.com/
  */
 #ifndef _DT_BINDINGS_PINCTRL_TI_K3_H
 #define _DT_BINDINGS_PINCTRL_TI_K3_H
@@ -35,4 +35,7 @@ 
 #define J721E_IOPAD(pa, val, muxmode)		(((pa) & 0x1fff)) ((val) | (muxmode))
 #define J721E_WKUP_IOPAD(pa, val, muxmode)	(((pa) & 0x1fff)) ((val) | (muxmode))
 
+#define AM64X_IOPAD(pa, val, muxmode)		(((pa) & 0x1fff)) ((val) | (muxmode))
+#define AM64X_MCU_IOPAD(pa, val, muxmode)	(((pa) & 0x1fff)) ((val) | (muxmode))
+
 #endif