diff mbox series

pinctrl: rockchip: make driver be tristate module

Message ID 20210223064211.120935-1-jay.xu@rock-chips.com
State Superseded
Headers show
Series pinctrl: rockchip: make driver be tristate module | expand

Commit Message

Jianqun Xu Feb. 23, 2021, 6:42 a.m. UTC 
Make pinctrl-rockchip driver to be tristate module, support to build as
a module, this is useful for GKI.

Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
---
 drivers/pinctrl/Kconfig            |  2 +-
 drivers/pinctrl/pinctrl-rockchip.c | 13 +++++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)

Comments

Linus Walleij March 2, 2021, 1:18 p.m. UTC | #1 
On Tue, Feb 23, 2021 at 7:42 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:

> Make pinctrl-rockchip driver to be tristate module, support to build as
> a module, this is useful for GKI.
>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>

Patch applied.

Yours,
Linus Walleij
Linus Walleij March 4, 2021, 8:18 a.m. UTC | #2 
On Tue, Mar 2, 2021 at 2:18 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> On Tue, Feb 23, 2021 at 7:42 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:

>

> > Make pinctrl-rockchip driver to be tristate module, support to build as

> > a module, this is useful for GKI.

> >

> > Reviewed-by: Heiko Stuebner <heiko@sntech.de>

> > Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>

>

> Patch applied.


Dropped this patch again since it breaks x86_64 allmodconfig.

Yours,
Linus Walleij
Linus Walleij March 10, 2021, 1:47 p.m. UTC | #3 
On Fri, Mar 5, 2021 at 2:02 AM Kever Yang <kever.yang@rock-chips.com> wrote:

> Hi Linus,

>     Is there a place we can see the error report for "x86_64 allmodconfig"?

> Since we don't have a build environment for architectures other than arm,

> it would be best if we can get the error without have to setup the build environment.


It comes out from the kernel build robot when I apply the patch, hehe :D

But I think the kernel build robot people at Arm can pick any git branch
for builds, on request.

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 03c62e1cb395..ba12061a80b1 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -208,7 +208,7 @@  config PINCTRL_OXNAS
 	select MFD_SYSCON
 
 config PINCTRL_ROCKCHIP
-	bool
+	tristate "Rockchip gpio and pinctrl driver"
 	depends on OF
 	select PINMUX
 	select GENERIC_PINCONF
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index aa1a1c850d05..70dc03af5699 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -16,10 +16,12 @@ 
  */
 
 #include <linux/init.h>
+#include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/io.h>
 #include <linux/bitops.h>
 #include <linux/gpio/driver.h>
+#include <linux/of_device.h>
 #include <linux/of_address.h>
 #include <linux/of_irq.h>
 #include <linux/pinctrl/machine.h>
@@ -4256,3 +4258,14 @@  static int __init rockchip_pinctrl_drv_register(void)
 	return platform_driver_register(&rockchip_pinctrl_driver);
 }
 postcore_initcall(rockchip_pinctrl_drv_register);
+
+static void __exit rockchip_pinctrl_drv_unregister(void)
+{
+	platform_driver_unregister(&rockchip_pinctrl_driver);
+}
+module_exit(rockchip_pinctrl_drv_unregister);
+
+MODULE_DESCRIPTION("ROCKCHIP Pin Controller Driver");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:pinctrl-rockchip");
+MODULE_DEVICE_TABLE(of, rockchip_pinctrl_dt_match);