| Message ID | 20210302164145.28552-1-clabbe.montjoie@gmail.com |
|---|---|
| State | Accepted |
| Commit | 1dbc6a1e25be8575d6c4114d1d2b841a796507f7 |
| Headers | show |
| Series | crypto: sun8i-ss: fix result memory leak on error path | expand |
On Tue, Mar 02, 2021 at 05:41:45PM +0100, Corentin Labbe wrote: > This patch fixes a memory leak on an error path. > > Fixes: d9b45418a917 ("crypto: sun8i-ss - support hash algorithms") > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > --- > drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This patch was already merged a month ago: commit 1dbc6a1e25be8575d6c4114d1d2b841a796507f7 Author: Corentin Labbe <clabbe.montjoie@gmail.com> Date: Fri Feb 12 09:46:10 2021 +0100 crypto: sun8i-ss - fix result memory leak on error path Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c index 11cbcbc83a7b..0b9aa24a5edd 100644 --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c @@ -438,8 +438,8 @@ int sun8i_ss_hash_run(struct crypto_engine *engine, void *breq) kfree(pad); memcpy(areq->result, result, algt->alg.hash.halg.digestsize); - kfree(result); theend: + kfree(result); crypto_finalize_hash_request(engine, breq, err); return 0; }
This patch fixes a memory leak on an error path. Fixes: d9b45418a917 ("crypto: sun8i-ss - support hash algorithms") Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> --- drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.26.2