mbox series

[net-next,v6,0/6] net: qualcomm: rmnet: stop using C bit-fields

Message ID 20210315215151.3029676-1-elder@linaro.org
Headers show
Series net: qualcomm: rmnet: stop using C bit-fields | expand

Message

Alex Elder March 15, 2021, 9:51 p.m. UTC
Version 6 is the same as version 5, but has been rebased on updated
net-next/master.  With any luck, the patches I'm sending out this
time won't contain garbage.

Version 5 of this series responds to a suggestion made by Alexander
Duyck, to determine the offset to the checksummed range of a packet
using skb_network_header_len() on patch 2.  I have added his
Reviewed-by tag to all (other) patches, and removed Bjorn's from
patch 2.

The change required some updates to the subsequent patches, and I
reordered some assignments in a minor way in the last patch.

I don't expect any more discussion on this series (but will respond
if there is any).  So at this point I would really appreciate it
if KS and/or Sean would offer a review, or at least acknowledge it.
I presume you two are able to independently test the code as well,
so I request that, and hope you are willing to do so.

Version 4 of this series is here:
  https://lore.kernel.org/netdev/20210315133455.1576188-1-elder@linaro.org

					-Alex


Alex Elder (6):
  net: qualcomm: rmnet: mark trailer field endianness
  net: qualcomm: rmnet: simplify some byte order logic
  net: qualcomm: rmnet: kill RMNET_MAP_GET_*() accessor macros
  net: qualcomm: rmnet: use masks instead of C bit-fields
  net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum trailer
  net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum header

 .../ethernet/qualcomm/rmnet/rmnet_handlers.c  | 10 +--
 .../net/ethernet/qualcomm/rmnet/rmnet_map.h   | 12 ----
 .../qualcomm/rmnet/rmnet_map_command.c        | 11 +++-
 .../ethernet/qualcomm/rmnet/rmnet_map_data.c  | 56 ++++++----------
 include/linux/if_rmnet.h                      | 65 +++++++++----------
 5 files changed, 64 insertions(+), 90 deletions(-)

-- 
2.27.0

Comments

Subash Abhinov Kasiviswanathan March 16, 2021, 2:38 a.m. UTC | #1
On 2021-03-15 15:51, Alex Elder wrote:
> Version 6 is the same as version 5, but has been rebased on updated

> net-next/master.  With any luck, the patches I'm sending out this

> time won't contain garbage.

> 

> Version 5 of this series responds to a suggestion made by Alexander

> Duyck, to determine the offset to the checksummed range of a packet

> using skb_network_header_len() on patch 2.  I have added his

> Reviewed-by tag to all (other) patches, and removed Bjorn's from

> patch 2.

> 

> The change required some updates to the subsequent patches, and I

> reordered some assignments in a minor way in the last patch.

> 

> I don't expect any more discussion on this series (but will respond

> if there is any).  So at this point I would really appreciate it

> if KS and/or Sean would offer a review, or at least acknowledge it.

> I presume you two are able to independently test the code as well,

> so I request that, and hope you are willing to do so.

> 

> Version 4 of this series is here:

>   

> https://lore.kernel.org/netdev/20210315133455.1576188-1-elder@linaro.org

> 

> 					-Alex

> 

> 

> Alex Elder (6):

>   net: qualcomm: rmnet: mark trailer field endianness

>   net: qualcomm: rmnet: simplify some byte order logic

>   net: qualcomm: rmnet: kill RMNET_MAP_GET_*() accessor macros

>   net: qualcomm: rmnet: use masks instead of C bit-fields

>   net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum 

> trailer

>   net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum header

> 

>  .../ethernet/qualcomm/rmnet/rmnet_handlers.c  | 10 +--

>  .../net/ethernet/qualcomm/rmnet/rmnet_map.h   | 12 ----

>  .../qualcomm/rmnet/rmnet_map_command.c        | 11 +++-

>  .../ethernet/qualcomm/rmnet/rmnet_map_data.c  | 56 ++++++----------

>  include/linux/if_rmnet.h                      | 65 +++++++++----------

>  5 files changed, 64 insertions(+), 90 deletions(-)


For the series

Reviewed-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
patchwork-bot+netdevbpf@kernel.org March 16, 2021, 4 a.m. UTC | #2
Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Mon, 15 Mar 2021 16:51:45 -0500 you wrote:
> Version 6 is the same as version 5, but has been rebased on updated

> net-next/master.  With any luck, the patches I'm sending out this

> time won't contain garbage.

> 

> Version 5 of this series responds to a suggestion made by Alexander

> Duyck, to determine the offset to the checksummed range of a packet

> using skb_network_header_len() on patch 2.  I have added his

> Reviewed-by tag to all (other) patches, and removed Bjorn's from

> patch 2.

> 

> [...]


Here is the summary with links:
  - [net-next,v6,1/6] net: qualcomm: rmnet: mark trailer field endianness
    https://git.kernel.org/netdev/net-next/c/45f3a13c8166
  - [net-next,v6,2/6] net: qualcomm: rmnet: simplify some byte order logic
    https://git.kernel.org/netdev/net-next/c/50c62a111c48
  - [net-next,v6,3/6] net: qualcomm: rmnet: kill RMNET_MAP_GET_*() accessor macros
    https://git.kernel.org/netdev/net-next/c/9d131d044f89
  - [net-next,v6,4/6] net: qualcomm: rmnet: use masks instead of C bit-fields
    https://git.kernel.org/netdev/net-next/c/16653c16d282
  - [net-next,v6,5/6] net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum trailer
    https://git.kernel.org/netdev/net-next/c/cc1b21ba6251
  - [net-next,v6,6/6] net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum header
    https://git.kernel.org/netdev/net-next/c/86ca860e12ec

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html