diff mbox series

[net,4/9] octeontx2-af: Remove TOS field from MKEX TX

Message ID 1615886833-71688-5-git-send-email-hkelam@marvell.com
State Superseded
Headers show
Series [net,1/9] octeontx2-pf: Do not modify number of rules | expand

Commit Message

Hariprasad Kelam March 16, 2021, 9:27 a.m. UTC 
From: Subbaraya Sundeep <sbhatta@marvell.com>

TOS overlaps with DMAC field in mcam search key and hence installing
rules for TX side are failing. Hence remove TOS field from TX profile.

Fixes: 42006910("octeontx2-af: cleanup KPU config data")
Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
---
 drivers/net/ethernet/marvell/octeontx2/af/npc_profile.h | 2 --
 1 file changed, 2 deletions(-)

Comments

sundeep subbaraya March 17, 2021, 6:37 a.m. UTC | #1 
Hi Jakub,

On Tue, Mar 16, 2021 at 10:53 PM Jakub Kicinski <kuba@kernel.org> wrote:
>

> On Tue, 16 Mar 2021 14:57:08 +0530 Hariprasad Kelam wrote:

> > From: Subbaraya Sundeep <sbhatta@marvell.com>

> >

> > TOS overlaps with DMAC field in mcam search key and hence installing

> > rules for TX side are failing. Hence remove TOS field from TX profile.

>

> Could you clarify what "installing rules is failing" means?

> Return error or does not behave correctly?


Returns error. The MKEX profile can be in a way where higher layer packet fields
can overwrite lower layer packet fields in output MCAM Key. The commit
42006910 ("octeontx2-af: cleanup KPU config data") introduced TX TOS field and
it overwrites DMAC. AF driver return error when TX rule is installed
with DMAC as
match criteria since DMAC gets overwritten and cannot be supported. Layers from
lower to higher in our case:
LA - Ethernet
LB - VLAN
LC - IP
LD - TCP/UDP
and so on.

We make sure there are no overlaps between layers but TOS got added by mistake.
We will elaborate the commit description and send the next version.

Thanks,
Sundeep
Jakub Kicinski March 17, 2021, 6:47 p.m. UTC | #2 
On Wed, 17 Mar 2021 12:07:12 +0530 sundeep subbaraya wrote:
> On Tue, Mar 16, 2021 at 10:53 PM Jakub Kicinski <kuba@kernel.org> wrote:

> >

> > On Tue, 16 Mar 2021 14:57:08 +0530 Hariprasad Kelam wrote:  

> > > From: Subbaraya Sundeep <sbhatta@marvell.com>

> > >

> > > TOS overlaps with DMAC field in mcam search key and hence installing

> > > rules for TX side are failing. Hence remove TOS field from TX profile.  

> >

> > Could you clarify what "installing rules is failing" means?

> > Return error or does not behave correctly?  

> 

> Returns error. The MKEX profile can be in a way where higher layer packet fields

> can overwrite lower layer packet fields in output MCAM Key. The commit

> 42006910 ("octeontx2-af: cleanup KPU config data") introduced TX TOS field and

> it overwrites DMAC. AF driver return error when TX rule is installed

> with DMAC as

> match criteria since DMAC gets overwritten and cannot be supported. Layers from

> lower to higher in our case:

> LA - Ethernet

> LB - VLAN

> LC - IP

> LD - TCP/UDP

> and so on.

> 

> We make sure there are no overlaps between layers but TOS got added by mistake.

> We will elaborate the commit description and send the next version.


Thank you! The longer explanation makes the error clear.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/marvell/octeontx2/af/npc_profile.h b/drivers/net/ethernet/marvell/octeontx2/af/npc_profile.h
index b192692..5c372d2 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/npc_profile.h
+++ b/drivers/net/ethernet/marvell/octeontx2/af/npc_profile.h
@@ -13499,8 +13499,6 @@  static struct npc_mcam_kex npc_mkex_default = {
 			[NPC_LT_LC_IP] = {
 				/* SIP+DIP: 8 bytes, KW2[63:0] */
 				KEX_LD_CFG(0x07, 0xc, 0x1, 0x0, 0x10),
-				/* TOS: 1 byte, KW1[63:56] */
-				KEX_LD_CFG(0x0, 0x1, 0x1, 0x0, 0xf),
 			},
 			/* Layer C: IPv6 */
 			[NPC_LT_LC_IP6] = {