Message ID | 20210317230946.23675-1-s-anna@ti.com |
---|---|
Headers | show |
Series | AM64x HwSpinlock and Mailbox DT nodes | expand |
> Hi Nishanth, > > The following series adds the HwSpinlock and Mailbox DT nodes for > AM64x SoCs on AM64x-EVM and AM64x-SK boards. The bindings for both > drivers were merged in 5.12-rc1. > > Patches are based on top of your latest ti-k3-dts-next branch, > commit 04a80a75baa1 ("arm64: dts: ti: k3-am642-evm: Add USB support"). > > Following is the patch summary: > - Patch 1 adds the HwSpinlock node > - Patch 2 adds all the relevant Mailbox clusters that generate > interrupts towards A53 > - Patches 3 and 4 add the actual communication sub-mailbox devices > and disables unused clusters for AM64x EVM and AM64x SK boards > respectively. > > Boot Logs: > 1. AM64x EVM: https://pastebin.ubuntu.com/p/JMxrqr2zQN/ > 2. AM64x SK: https://pastebin.ubuntu.com/p/rJcyXvD9hV/ > > regards > Suman > > Suman Anna (4): > arm64: dts: ti: k3-am64-main: Add hwspinlock node > arm64: dts: ti: k3-am64-main: Add mailbox cluster nodes > arm64: dts: ti: k3-am642-evm: Add IPC sub-mailbox nodes > arm64: dts: ti: k3-am642-sk: Add IPC sub-mailbox nodes > > arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 64 ++++++++++++++++++++++++ > arch/arm64/boot/dts/ti/k3-am642-evm.dts | 43 ++++++++++++++++ > arch/arm64/boot/dts/ti/k3-am642-sk.dts | 43 ++++++++++++++++ > 3 files changed, 150 insertions(+) I don't see any issues with this patchset, and dtbs_check reports no errors. Reviewed-by: Gowtham Tammana <g-tammana@ti.com>
On 18:09-20210317, Suman Anna wrote: > Hi Nishanth, > > The following series adds the HwSpinlock and Mailbox DT nodes for > AM64x SoCs on AM64x-EVM and AM64x-SK boards. The bindings for both > drivers were merged in 5.12-rc1. > > Patches are based on top of your latest ti-k3-dts-next branch, > commit 04a80a75baa1 ("arm64: dts: ti: k3-am642-evm: Add USB support"). yep, you'd be next in the queue here, so if you dont mind rebasing one last time, it will help. Also in the repost, please address the following comment. > > > Suman Anna (4): > arm64: dts: ti: k3-am64-main: Add hwspinlock node > arm64: dts: ti: k3-am64-main: Add mailbox cluster nodes > arm64: dts: ti: k3-am642-evm: Add IPC sub-mailbox nodes > arm64: dts: ti: k3-am642-sk: Add IPC sub-mailbox nodes please squash patches 3,4. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
Hi Nishanth, On 3/22/21 12:24 PM, Nishanth Menon wrote: > On 18:09-20210317, Suman Anna wrote: >> Hi Nishanth, >> >> The following series adds the HwSpinlock and Mailbox DT nodes for >> AM64x SoCs on AM64x-EVM and AM64x-SK boards. The bindings for both >> drivers were merged in 5.12-rc1. >> >> Patches are based on top of your latest ti-k3-dts-next branch, >> commit 04a80a75baa1 ("arm64: dts: ti: k3-am642-evm: Add USB support"). > > yep, you'd be next in the queue here, so if you dont mind rebasing one > last time, it will help. Also in the repost, please address the > following comment. > >> >> >> Suman Anna (4): >> arm64: dts: ti: k3-am64-main: Add hwspinlock node >> arm64: dts: ti: k3-am64-main: Add mailbox cluster nodes >> arm64: dts: ti: k3-am642-evm: Add IPC sub-mailbox nodes >> arm64: dts: ti: k3-am642-sk: Add IPC sub-mailbox nodes > > please squash patches 3,4. Hmm, I prefer to not mix or combine stuff that affects more than a single board. This is not a bug fix, so, if you don't mind, I would like to keep these as is. regards Suman
On 12:34-20210322, Suman Anna wrote: > Hi Nishanth, > > On 3/22/21 12:24 PM, Nishanth Menon wrote: > > On 18:09-20210317, Suman Anna wrote: > >> Hi Nishanth, > >> > >> The following series adds the HwSpinlock and Mailbox DT nodes for > >> AM64x SoCs on AM64x-EVM and AM64x-SK boards. The bindings for both > >> drivers were merged in 5.12-rc1. > >> > >> Patches are based on top of your latest ti-k3-dts-next branch, > >> commit 04a80a75baa1 ("arm64: dts: ti: k3-am642-evm: Add USB support"). > > > > yep, you'd be next in the queue here, so if you dont mind rebasing one > > last time, it will help. Also in the repost, please address the > > following comment. > > > >> > >> > >> Suman Anna (4): > >> arm64: dts: ti: k3-am64-main: Add hwspinlock node > >> arm64: dts: ti: k3-am64-main: Add mailbox cluster nodes > >> arm64: dts: ti: k3-am642-evm: Add IPC sub-mailbox nodes > >> arm64: dts: ti: k3-am642-sk: Add IPC sub-mailbox nodes > > > > please squash patches 3,4. > > Hmm, I prefer to not mix or combine stuff that affects more than a single board. > This is not a bug fix, so, if you don't mind, I would like to keep these as is. Lets stay consistent with patches I have been consolidating, I see no reason to add to a patch count here. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D