diff mbox series

kselftest/arm64: mte: Fix misleading output when skipping tests

Message ID 20210819172902.56211-1-broonie@kernel.org
State Accepted
Commit 83e5dcbece4ea67ec3ad94b897e2844184802fd7
Headers show
Series kselftest/arm64: mte: Fix misleading output when skipping tests | expand

Commit Message

Mark Brown Aug. 19, 2021, 5:29 p.m. UTC
When skipping the tests due to a lack of system support for MTE we
currently print a message saying FAIL which makes it look like the test
failed even though the test did actually report KSFT_SKIP, creating some
confusion. Change the error message to say SKIP instead so things are
clearer.

Signed-off-by: Mark Brown <broonie@kernel.org>

---
 tools/testing/selftests/arm64/mte/mte_common_util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.20.1

Comments

Catalin Marinas Aug. 20, 2021, 10:21 a.m. UTC | #1
On Thu, 19 Aug 2021 18:29:02 +0100, Mark Brown wrote:
> When skipping the tests due to a lack of system support for MTE we

> currently print a message saying FAIL which makes it look like the test

> failed even though the test did actually report KSFT_SKIP, creating some

> confusion. Change the error message to say SKIP instead so things are

> clearer.


Applied to arm64 (for-next/kselftest), thanks!

[1/1] kselftest/arm64: mte: Fix misleading output when skipping tests
      https://git.kernel.org/arm64/c/83e5dcbece4e

-- 
Catalin
diff mbox series

Patch

diff --git a/tools/testing/selftests/arm64/mte/mte_common_util.c b/tools/testing/selftests/arm64/mte/mte_common_util.c
index f50ac31920d1..0328a1e08f65 100644
--- a/tools/testing/selftests/arm64/mte/mte_common_util.c
+++ b/tools/testing/selftests/arm64/mte/mte_common_util.c
@@ -298,7 +298,7 @@  int mte_default_setup(void)
 	int ret;
 
 	if (!(hwcaps2 & HWCAP2_MTE)) {
-		ksft_print_msg("FAIL: MTE features unavailable\n");
+		ksft_print_msg("SKIP: MTE features unavailable\n");
 		return KSFT_SKIP;
 	}
 	/* Get current mte mode */