| Message ID | 1396618989-2897-17-git-send-email-daniel.lezcano@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Friday, April 04, 2014 03:43:08 PM Daniel Lezcano wrote: > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Daniel, On 4 April 2014 19:13, Daniel Lezcano <daniel.lezcano@linaro.org> wrote: > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > arch/arm/mach-exynos/Makefile | 1 - > drivers/cpuidle/Kconfig.arm | 7 +++++++ > drivers/cpuidle/Makefile | 1 + > .../cpuidle.c => drivers/cpuidle/cpuidle-exynos.c | 0 > 4 files changed, 8 insertions(+), 1 deletion(-) > rename arch/arm/mach-exynos/cpuidle.c => drivers/cpuidle/cpuidle-exynos.c (100%) This driver now references platform header file (plat/cpu.h) for some Exynos5440 specific check which is not good considering multiplatform support. Any plan to get rid of this?
On 04/07/2014 11:51 AM, Sachin Kamat wrote: > Hi Daniel, > > On 4 April 2014 19:13, Daniel Lezcano <daniel.lezcano@linaro.org> wrote: >> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> >> Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org> >> --- >> arch/arm/mach-exynos/Makefile | 1 - >> drivers/cpuidle/Kconfig.arm | 7 +++++++ >> drivers/cpuidle/Makefile | 1 + >> .../cpuidle.c => drivers/cpuidle/cpuidle-exynos.c | 0 >> 4 files changed, 8 insertions(+), 1 deletion(-) >> rename arch/arm/mach-exynos/cpuidle.c => drivers/cpuidle/cpuidle-exynos.c (100%) > > This driver now references platform header file (plat/cpu.h) for some > Exynos5440 specific check > which is not good considering multiplatform support. Any plan to get > rid of this? Yes. Prevent to register the platform device for this board and remove these lines in the driver. What is the benefit of having a single state WFI cpuidle driver ? That pulls all the governor computation and decision for nothing.
diff --git a/arch/arm/mach-exynos/Makefile b/arch/arm/mach-exynos/Makefile index a656dbe..21bd364 100644 --- a/arch/arm/mach-exynos/Makefile +++ b/arch/arm/mach-exynos/Makefile @@ -16,7 +16,6 @@ obj-$(CONFIG_ARCH_EXYNOS) += exynos.o obj-$(CONFIG_PM_SLEEP) += pm.o sleep.o obj-$(CONFIG_PM_GENERIC_DOMAINS) += pm_domains.o -obj-$(CONFIG_CPU_IDLE) += cpuidle.o obj-$(CONFIG_ARCH_EXYNOS) += pmu.o diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm index d988948..92f0c12 100644 --- a/drivers/cpuidle/Kconfig.arm +++ b/drivers/cpuidle/Kconfig.arm @@ -44,3 +44,10 @@ config ARM_AT91_CPUIDLE depends on ARCH_AT91 help Select this to enable cpuidle for AT91 processors + +config ARM_EXYNOS_CPUIDLE + bool "Cpu Idle Driver for the Exynos processors" + default y + depends on ARCH_EXYNOS + help + Select this to enable cpuidle for Exynos processors diff --git a/drivers/cpuidle/Makefile b/drivers/cpuidle/Makefile index f71ae1b..0d1540a 100644 --- a/drivers/cpuidle/Makefile +++ b/drivers/cpuidle/Makefile @@ -13,6 +13,7 @@ obj-$(CONFIG_ARM_KIRKWOOD_CPUIDLE) += cpuidle-kirkwood.o obj-$(CONFIG_ARM_ZYNQ_CPUIDLE) += cpuidle-zynq.o obj-$(CONFIG_ARM_U8500_CPUIDLE) += cpuidle-ux500.o obj-$(CONFIG_ARM_AT91_CPUIDLE) += cpuidle-at91.o +obj-$(CONFIG_ARM_EXYNOS_CPUIDLE) += cpuidle-exynos.o ############################################################################### # POWERPC drivers