| Message ID | 20220126221725.710167-1-bhupesh.sharma@linaro.org |
|---|---|
| Headers | show |
| Series | Add ethernet support for Qualcomm SA8155p-ADP board | expand |
> +ðernet { > + status = "okay"; > + > + snps,reset-gpio = <&tlmm 79 GPIO_ACTIVE_LOW>; > + snps,reset-active-low; > + snps,reset-delays-us = <0 11000 70000>; > + > + snps,ptp-ref-clk-rate = <250000000>; > + snps,ptp-req-clk-rate = <96000000>; > + > + snps,mtl-rx-config = <&mtl_rx_setup>; > + snps,mtl-tx-config = <&mtl_tx_setup>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <ðernet_defaults>; > + > + phy-handle = <&rgmii_phy>; > + phy-mode = "rgmii"; Where are the rgmii delays being added for this board? Andrew
Hi Andrew, Sorry for the late reply. On Thu, 27 Jan 2022 at 05:37, Andrew Lunn <andrew@lunn.ch> wrote: > > > +ðernet { > > + status = "okay"; > > + > > + snps,reset-gpio = <&tlmm 79 GPIO_ACTIVE_LOW>; > > + snps,reset-active-low; > > + snps,reset-delays-us = <0 11000 70000>; > > + > > + snps,ptp-ref-clk-rate = <250000000>; > > + snps,ptp-req-clk-rate = <96000000>; > > + > > + snps,mtl-rx-config = <&mtl_rx_setup>; > > + snps,mtl-tx-config = <&mtl_tx_setup>; > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <ðernet_defaults>; > > + > > + phy-handle = <&rgmii_phy>; > > + phy-mode = "rgmii"; > > Where are the rgmii delays being added for this board? I am not sure if I am missing something, but I don't see any rgmii tx or rx delay dts properties for the dwmac-qcom-ethqos driver (see [1] and [2]). I see that some stmmac drivers (for e.g. drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c), do define and use dts properties that define the delays (for e.g. 'allwinner,tx-delay-ps'), but I cannot find something equivalent for 'dwmac-qcom-ethqos.c'. [1]. Documentation/devicetree/bindings/net/qcom,ethqos.txt [2]. Documentation/devicetree/bindings/net/snps,dwmac.yaml Regards, Bhupesh
The SA8155p-ADP board supports on-board ethernet (Gibabit Interface), with support for both RGMII and RMII buses. This patchset adds the support for the same. Note that this patchset is based on an earlier sent patchset for adding PDC controller support on SM8150 (see [1]). [1]. https://lore.kernel.org/linux-arm-msm/20220119203133.467264-1-bhupesh.sharma@linaro.org/T Bhupesh Sharma (3): clk: qcom: gcc: Add PCIe, EMAC and UFS GDSCs for SM8150 clk: qcom: gcc-sm8150: use runtime PM for the clock controller clk: qcom: gcc-sm8150: Use PWRSTS_ON (only) as a workaround for emac gdsc Bjorn Andersson (1): net: stmmac: dwmac-qcom-ethqos: Adjust rgmii loopback_en per platform Vinod Koul (4): dt-bindings: net: qcom,ethqos: Document SM8150 SoC compatible net: stmmac: Add support for SM8150 arm64: dts: qcom: sm8150: add ethernet node arm64: dts: qcom: sa8155p-adp: Enable ethernet node .../devicetree/bindings/net/qcom,ethqos.txt | 4 +- arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 144 ++++++++++++++++++ arch/arm64/boot/dts/qcom/sm8150.dtsi | 27 ++++ drivers/clk/qcom/gcc-sm8150.c | 105 +++++++++++-- .../stmicro/stmmac/dwmac-qcom-ethqos.c | 37 ++++- include/dt-bindings/clock/qcom,gcc-sm8150.h | 9 +- 6 files changed, 305 insertions(+), 21 deletions(-)