| Message ID | 20220309115918.22469-2-broonie@kernel.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | kselftest/arm64: Test ptrace writing via FPSIMD and reading via SVE | expand |
On 3/9/22 4:59 AM, Mark Brown wrote: > The comment for ptrace_sve_get_fpsimd_data() doesn't describe what the test > does at all, fix that. > > Signed-off-by: Mark Brown <broonie@kernel.org> > --- > tools/testing/selftests/arm64/fp/sve-ptrace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/arm64/fp/sve-ptrace.c b/tools/testing/selftests/arm64/fp/sve-ptrace.c > index a3c1e67441f9..6b139d5f67f1 100644 > --- a/tools/testing/selftests/arm64/fp/sve-ptrace.c > +++ b/tools/testing/selftests/arm64/fp/sve-ptrace.c > @@ -397,7 +397,7 @@ static void ptrace_set_sve_get_sve_data(pid_t child, > free(write_buf); > } > > -/* Validate attempting to set SVE data and read SVE data */ > +/* Validate attempting to set SVE data and read it via the FPSIMD regset */ > static void ptrace_set_sve_get_fpsimd_data(pid_t child, > const struct vec_type *type, > unsigned int vl) > Looks good to me. Reviewed-by: Shuah Khan <skhan@linuxfoundation.org> thanks, -- Shuah
diff --git a/tools/testing/selftests/arm64/fp/sve-ptrace.c b/tools/testing/selftests/arm64/fp/sve-ptrace.c index a3c1e67441f9..6b139d5f67f1 100644 --- a/tools/testing/selftests/arm64/fp/sve-ptrace.c +++ b/tools/testing/selftests/arm64/fp/sve-ptrace.c @@ -397,7 +397,7 @@ static void ptrace_set_sve_get_sve_data(pid_t child, free(write_buf); } -/* Validate attempting to set SVE data and read SVE data */ +/* Validate attempting to set SVE data and read it via the FPSIMD regset */ static void ptrace_set_sve_get_fpsimd_data(pid_t child, const struct vec_type *type, unsigned int vl)
The comment for ptrace_sve_get_fpsimd_data() doesn't describe what the test does at all, fix that. Signed-off-by: Mark Brown <broonie@kernel.org> --- tools/testing/selftests/arm64/fp/sve-ptrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)