diff mbox series

dt-bindings: PCI: fsl,imx6q-pcie: Add missing type for 'reset-gpio-active-high'

Message ID 20220719215031.1875860-1-robh@kernel.org
State Accepted
Commit fba4866241e07f8f545b3dcc72fbbadde485530d
Headers show
Series dt-bindings: PCI: fsl,imx6q-pcie: Add missing type for 'reset-gpio-active-high' | expand

Commit Message

Rob Herring July 19, 2022, 9:50 p.m. UTC
'reset-gpio-active-high' is missing a type definition and is not a common
property. The type is boolean.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Hongxing Zhu July 20, 2022, 1:31 a.m. UTC | #1
Hi Rob:
Thanks for your kindly help.

> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: 2022年7月20日 5:51
> To: Hongxing Zhu <hongxing.zhu@nxp.com>; Lucas Stach
> <l.stach@pengutronix.de>; Bjorn Helgaas <bhelgaas@google.com>; Krzysztof
> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Shawn Guo
> <shawnguo@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>;
> Pengutronix Kernel Team <kernel@pengutronix.de>; Fabio Estevam
> <festevam@gmail.com>; dl-linux-imx <linux-imx@nxp.com>
> Cc: linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] dt-bindings: PCI: fsl,imx6q-pcie: Add missing type for
> 'reset-gpio-active-high'
> 
> 'reset-gpio-active-high' is missing a type definition and is not a common
> property. The type is boolean.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Richard Zhu <hongxing.zhu@nxp.com>

Best Regards
Richard Zhu
> ---
>  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> index 252e5b72aee0..376e739bcad4 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> @@ -144,6 +144,7 @@ properties:
>      description: If present then the reset sequence using the GPIO
>        specified in the "reset-gpio" property is reversed (H=reset state,
>        L=operation state) (optional required).
> +    type: boolean
> 
>    vpcie-supply:
>      description: Should specify the regulator in charge of PCIe port power.
> --
> 2.34.1
Bjorn Helgaas July 20, 2022, 9:07 p.m. UTC | #2
On Tue, Jul 19, 2022 at 03:50:31PM -0600, Rob Herring wrote:
> 'reset-gpio-active-high' is missing a type definition and is not a common
> property. The type is boolean.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

You've merged previous updates, Rob, so I assume you'll do the same
with this.

> ---
>  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> index 252e5b72aee0..376e739bcad4 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> @@ -144,6 +144,7 @@ properties:
>      description: If present then the reset sequence using the GPIO
>        specified in the "reset-gpio" property is reversed (H=reset state,
>        L=operation state) (optional required).
> +    type: boolean
>  
>    vpcie-supply:
>      description: Should specify the regulator in charge of PCIe port power.
> -- 
> 2.34.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Rob Herring July 22, 2022, 9:59 p.m. UTC | #3
On Tue, 19 Jul 2022 15:50:31 -0600, Rob Herring wrote:
> 'reset-gpio-active-high' is missing a type definition and is not a common
> property. The type is boolean.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Applied, thanks!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
index 252e5b72aee0..376e739bcad4 100644
--- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
@@ -144,6 +144,7 @@  properties:
     description: If present then the reset sequence using the GPIO
       specified in the "reset-gpio" property is reversed (H=reset state,
       L=operation state) (optional required).
+    type: boolean
 
   vpcie-supply:
     description: Should specify the regulator in charge of PCIe port power.