mbox series

[v3,0/2] Add support for the Pine64 PinePhone Pro phone

Message ID 20220815123004.252014-1-tom@tom-fitzhenry.me.uk
Headers show
Series Add support for the Pine64 PinePhone Pro phone | expand

Message

Tom Fitzhenry Aug. 15, 2022, 12:30 p.m. UTC 
PinePhone Pro is a RK3399 based phone produced by Pine64.

Add a basic DTS for it. This is a working base that will allow myself and
others to add more nodes.

Changes since v2:
* Used rk3399-opp.dtsi (+ disabled) rather than introducing rk3399-t-opp.dtsi
* Removed superfluous comments.
* Followed DT Generic Names Recommendation
* Set 'From:' of DTS patch to be Martijn, the primary contributor to the DT.

Changes since v1:
* Simplified the DT to a minimal base.
* Introduced the RK3399-T OPPs.

Martijn Braam (1):
  arm64: dts: rockchip: Add initial support for Pine64 PinePhone Pro

Tom Fitzhenry (1):
  dt-bindings: arm: rockchip: Add PinePhone Pro bindings

 .../devicetree/bindings/arm/rockchip.yaml     |   5 +
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../dts/rockchip/rk3399-pinephone-pro.dts     | 394 ++++++++++++++++++
 3 files changed, 400 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts


base-commit: 2e1170c71ec0c0fb785ce76fca7c682e930af2b8

Comments

Caleb Connolly Aug. 15, 2022, 10:27 p.m. UTC | #1 
On 15/08/2022 13:30, Tom Fitzhenry wrote:
> Document board compatible names for Pine64 PinePhonePro.
> 
> https://wiki.pine64.org/wiki/PinePhone_Pro
> 
> Signed-off-by: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>

Reviewed-by: Caleb Connolly <kc@postmarketos.org>
> ---
>   Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 7811ba64149cb..8ddedbd1ce317 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -494,6 +494,11 @@ properties:
>             - const: pine64,pinenote
>             - const: rockchip,rk3566
> 
> +      - description: Pine64 PinePhonePro
> +        items:
> +          - const: pine64,pinephone-pro
> +          - const: rockchip,rk3399
> +
>         - description: Pine64 Rock64
>           items:
>             - const: pine64,rock64
> --
> 2.37.1
>
Krzysztof Kozlowski Aug. 16, 2022, 7:50 a.m. UTC | #2 
On 15/08/2022 15:30, Tom Fitzhenry wrote:
> Document board compatible names for Pine64 PinePhonePro.
> 
> https://wiki.pine64.org/wiki/PinePhone_Pro
> 
> Signed-off-by: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>

Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.

https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540

If a tag was not added on purpose, please state why and what changed.


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof