| Message ID | 20220817143458.335938-5-justin.he@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | Modularize ghes_edac driver | expand |
On Wednesday, August 17, 2022 8:35 AM, Jia He wrote: > When ghes_edac is loaded, a regular edac driver for the CPU type / platform > still attempts to register itself and fails in its module_init call. > > Suggested-by: Toshi Kani <toshi.kani@hpe.com> > Suggested-by: Borislav Petkov <bp@alien8.de> > Signed-off-by: Jia He <justin.he@arm.com> > --- > drivers/edac/amd64_edac.c | 3 +++ > drivers/edac/pnd2_edac.c | 3 +++ > drivers/edac/sb_edac.c | 3 +++ > drivers/edac/skx_base.c | 3 +++ > 4 files changed, 12 insertions(+) Can you change i10nm_base.c and igen6_edac.c as well? They are listed in your list below. On Monday, August 15, 2022 8:20 PM, Justin He wrote: > I assume that all those edac drivers which used owner checking are > impacted, right? So the impacted list should be: > drivers/edac/pnd2_edac.c:1532: if (owner && strncmp(owner, > EDAC_MOD_STR, sizeof(EDAC_MOD_STR))) > drivers/edac/sb_edac.c:3513: if (owner && strncmp(owner, > EDAC_MOD_STR, sizeof(EDAC_MOD_STR))) > drivers/edac/amd64_edac.c:4333: if (owner && strncmp(owner, > EDAC_MOD_STR, sizeof(EDAC_MOD_STR))) > drivers/edac/i10nm_base.c:552: if (owner && strncmp(owner, > EDAC_MOD_STR, sizeof(EDAC_MOD_STR))) > drivers/edac/skx_base.c:657: if (owner && strncmp(owner, > EDAC_MOD_STR, sizeof(EDAC_MOD_STR))) > drivers/edac/igen6_edac.c:1275: if (owner && strncmp(owner, > EDAC_MOD_STR, sizeof(EDAC_MOD_STR))) Thanks, Toshi
> -----Original Message----- > From: Kani, Toshi <toshi.kani@hpe.com> > Sent: Friday, August 19, 2022 7:57 AM > To: Justin He <Justin.He@arm.com>; Ard Biesheuvel <ardb@kernel.org>; Len > Brown <lenb@kernel.org>; James Morse <James.Morse@arm.com>; Tony Luck > <tony.luck@intel.com>; Borislav Petkov <bp@alien8.de>; Mauro Carvalho > Chehab <mchehab@kernel.org>; Robert Richter <rric@kernel.org>; Robert > Moore <robert.moore@intel.com>; Qiuxu Zhuo <qiuxu.zhuo@intel.com>; > Yazen Ghannam <yazen.ghannam@amd.com> > Cc: linux-acpi@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-edac@vger.kernel.org; devel@acpica.org; Rafael J . Wysocki > <rafael@kernel.org>; Shuai Xue <xueshuai@linux.alibaba.com>; Jarkko > Sakkinen <jarkko@kernel.org>; linux-efi@vger.kernel.org; nd <nd@arm.com> > Subject: RE: [PATCH v2 4/7] EDAC: Get chipset-specific edac drivers selected > only when ghes_edac is not enabled > > On Wednesday, August 17, 2022 8:35 AM, Jia He wrote: > > When ghes_edac is loaded, a regular edac driver for the CPU type / > > platform still attempts to register itself and fails in its module_init call. > > > > Suggested-by: Toshi Kani <toshi.kani@hpe.com> > > Suggested-by: Borislav Petkov <bp@alien8.de> > > Signed-off-by: Jia He <justin.he@arm.com> > > --- > > drivers/edac/amd64_edac.c | 3 +++ > > drivers/edac/pnd2_edac.c | 3 +++ > > drivers/edac/sb_edac.c | 3 +++ > > drivers/edac/skx_base.c | 3 +++ > > 4 files changed, 12 insertions(+) > > Can you change i10nm_base.c and igen6_edac.c as well? > > They are listed in your list below. > Okay, will do. And will also include the ARM specific edac drivers just as Borislav mentioned. -- Cheers, Justin (Jia He)
diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c index 2f854feeeb23..e4eaf6668feb 100644 --- a/drivers/edac/amd64_edac.c +++ b/drivers/edac/amd64_edac.c @@ -4329,6 +4329,9 @@ static int __init amd64_edac_init(void) int err = -ENODEV; int i; + if (ghes_get_devices(0)) + return -EBUSY; + owner = edac_get_owner(); if (owner && strncmp(owner, EDAC_MOD_STR, sizeof(EDAC_MOD_STR))) return -EBUSY; diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c index a20b299f1202..73f2ba0e64e3 100644 --- a/drivers/edac/pnd2_edac.c +++ b/drivers/edac/pnd2_edac.c @@ -1528,6 +1528,9 @@ static int __init pnd2_init(void) edac_dbg(2, "\n"); + if (ghes_get_devices(0)) + return -EBUSY; + owner = edac_get_owner(); if (owner && strncmp(owner, EDAC_MOD_STR, sizeof(EDAC_MOD_STR))) return -EBUSY; diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c index 9678ab97c7ac..1d0520a16840 100644 --- a/drivers/edac/sb_edac.c +++ b/drivers/edac/sb_edac.c @@ -3506,6 +3506,9 @@ static int __init sbridge_init(void) edac_dbg(2, "\n"); + if (ghes_get_devices(0)) + return -EBUSY; + owner = edac_get_owner(); if (owner && strncmp(owner, EDAC_MOD_STR, sizeof(EDAC_MOD_STR))) return -EBUSY; diff --git a/drivers/edac/skx_base.c b/drivers/edac/skx_base.c index 1abc020d49ab..fe267f8543f5 100644 --- a/drivers/edac/skx_base.c +++ b/drivers/edac/skx_base.c @@ -653,6 +653,9 @@ static int __init skx_init(void) edac_dbg(2, "\n"); + if (ghes_get_devices(0)) + return -EBUSY; + owner = edac_get_owner(); if (owner && strncmp(owner, EDAC_MOD_STR, sizeof(EDAC_MOD_STR))) return -EBUSY;
When ghes_edac is loaded, a regular edac driver for the CPU type / platform still attempts to register itself and fails in its module_init call. Suggested-by: Toshi Kani <toshi.kani@hpe.com> Suggested-by: Borislav Petkov <bp@alien8.de> Signed-off-by: Jia He <justin.he@arm.com> --- drivers/edac/amd64_edac.c | 3 +++ drivers/edac/pnd2_edac.c | 3 +++ drivers/edac/sb_edac.c | 3 +++ drivers/edac/skx_base.c | 3 +++ 4 files changed, 12 insertions(+)