| Message ID | 20221001030641.29354-5-quic_molvera@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
Hi Melody,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on 987a926c1d8a40e4256953b04771fbdb63bc7938]
url: https://github.com/intel-lab-lkp/linux/commits/Melody-Olvera/Add-misc-support-for-QDU1000-QRU1000-SoCs/20221001-111140
base: 987a926c1d8a40e4256953b04771fbdb63bc7938
config: hexagon-randconfig-r001-20221002
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/fc61c357ddde657995cd0f200df393966486a594
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Melody-Olvera/Add-misc-support-for-QDU1000-QRU1000-SoCs/20221001-111140
git checkout fc61c357ddde657995cd0f200df393966486a594
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/soc/qcom/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/soc/qcom/rpmhpd.c:364:33: warning: unused variable 'qdru1000_desc' [-Wunused-const-variable]
static const struct rpmhpd_desc qdru1000_desc = {
^
1 warning generated.
vim +/qdru1000_desc +364 drivers/soc/qcom/rpmhpd.c
363
> 364 static const struct rpmhpd_desc qdru1000_desc = {
365 .rpmhpds = qdru1000_rpmhpds,
366 .num_pds = ARRAY_SIZE(qdru1000_rpmhpds),
367 };
368
On Fri, Sep 30, 2022 at 08:06:40PM -0700, Melody Olvera wrote: > Add the power domains exposed by RPMH in the Qualcomm QDU1000 > and QRU1000 platforms. > > Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> > --- > drivers/soc/qcom/rpmhpd.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c > index 092f6ab09acf..f70573cbc636 100644 > --- a/drivers/soc/qcom/rpmhpd.c > +++ b/drivers/soc/qcom/rpmhpd.c > @@ -353,6 +353,19 @@ static const struct rpmhpd_desc sm8450_desc = { > .num_pds = ARRAY_SIZE(sm8450_rpmhpds), > }; > > +/* QDU1000/QRU1000 RPMH powerdomains */ > +static struct rpmhpd *qdru1000_rpmhpds[] = { > + [QDRU1000_CX] = &cx, > + [QDRU1000_EBI] = &ebi, > + [QDRU1000_MSS] = &mss, > + [QDRU1000_MX] = &mx, > +}; > + > +static const struct rpmhpd_desc qdru1000_desc = { > + .rpmhpds = qdru1000_rpmhpds, > + .num_pds = ARRAY_SIZE(qdru1000_rpmhpds), > +}; > + Looks like you missed adding a (or two) entires to rpmhpd_match_table. Regards, Bjorn > /* SC7180 RPMH powerdomains */ > static struct rpmhpd *sc7180_rpmhpds[] = { > [SC7180_CX] = &cx_w_mx_parent, > -- > 2.37.3 >
diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c index 092f6ab09acf..f70573cbc636 100644 --- a/drivers/soc/qcom/rpmhpd.c +++ b/drivers/soc/qcom/rpmhpd.c @@ -353,6 +353,19 @@ static const struct rpmhpd_desc sm8450_desc = { .num_pds = ARRAY_SIZE(sm8450_rpmhpds), }; +/* QDU1000/QRU1000 RPMH powerdomains */ +static struct rpmhpd *qdru1000_rpmhpds[] = { + [QDRU1000_CX] = &cx, + [QDRU1000_EBI] = &ebi, + [QDRU1000_MSS] = &mss, + [QDRU1000_MX] = &mx, +}; + +static const struct rpmhpd_desc qdru1000_desc = { + .rpmhpds = qdru1000_rpmhpds, + .num_pds = ARRAY_SIZE(qdru1000_rpmhpds), +}; + /* SC7180 RPMH powerdomains */ static struct rpmhpd *sc7180_rpmhpds[] = { [SC7180_CX] = &cx_w_mx_parent,
Add the power domains exposed by RPMH in the Qualcomm QDU1000 and QRU1000 platforms. Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> --- drivers/soc/qcom/rpmhpd.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)