[v3,0/5] Add misc support for QDU1000/QRU1000 SoCs

This series containes firmware, SoC, rpmpd, and tz-log bindings as
well as pmic, rpmpd, and socinfo support for QDU1000 and QRU1000 SoCs.

The Qualcomm Technologies, Inc. Distributed Unit 1000 and Radio Unit
1000 are new SoCs meant for enabling Open RAN solutions. See more at
https://www.qualcomm.com/content/dam/qcomm-martech/dm-assets/documents/qualcomm_5g_ran_platforms_product_brief.pdf

Changes from v2:
- Dropped qru compat strings
- Marked no clocks on qdu/qru scm device
- Revised rpmhpd constants
- Updated socinfo driver to new format

Melody Olvera (5):
  dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatibles
  dt-bindings: power: rpmpd: Add QDU1000/QRU1000 to rpmpd binding
  soc: qcom: rpmhpd: Add QDU1000/QRU1000 power domains
  dt-bindings: arm: qcom,ids: Add SoC IDs for QDU1000/QRU1000
  soc: qcom: socinfo: Add QDU1000/QRU1000 SoC IDs to the soc_id table

 .../devicetree/bindings/firmware/qcom,scm.yaml    | 15 +++++++++++++++
 .../devicetree/bindings/power/qcom,rpmpd.yaml     |  1 +
 drivers/soc/qcom/rpmhpd.c                         | 14 ++++++++++++++
 drivers/soc/qcom/socinfo.c                        |  6 ++++++
 include/dt-bindings/arm/qcom,ids.h                |  6 ++++++
 include/dt-bindings/power/qcom-rpmpd.h            |  6 ++++++
 6 files changed, 48 insertions(+)


base-commit: 60eac8672b5b6061ec07499c0f1b79f6d94311ce

On Thu, Oct 27, 2022 at 11:25:42AM -0400, Krzysztof Kozlowski wrote:
> On 26/10/2022 15:05, Melody Olvera wrote:
> > Add compatible and constants for the power domains exposed by the RPMH
> > in the Qualcomm QDU1000 and QRU1000 platforms.
> > 
> > Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> 
> Looks good, but you did not Cc maintainers and  they must see this patch.
> 

$ ./scripts/get_maintainer.pl -f Documentation/devicetree/bindings/power/qcom,rpmpd.yaml include/dt-bindings/power/qcom-rpmpd.h
Andy Gross <agross@kernel.org> (maintainer:ARM/QUALCOMM SUPPORT)
Bjorn Andersson <andersson@kernel.org> (maintainer:ARM/QUALCOMM SUPPORT,in file)
Konrad Dybcio <konrad.dybcio@somainline.org> (reviewer:ARM/QUALCOMM SUPPORT)
Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
linux-arm-msm@vger.kernel.org (open list:ARM/QUALCOMM SUPPORT)
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
linux-kernel@vger.kernel.org (open list)

So you're right; Melody did miss Konrad in the recipients list. But he's
typically doing a very good job of keeping an eye on the list - and both
you and I got the patch.


Why didn't you add your R-b if you think it looks good?

> Who do you think will review and pick up this patch?
> 

Per the maintainers file that would be me, and as you don't seem to
object to the content of the patch I'm queueing this now.

Thanks,
Bjorn

On 10/27/2022 8:24 AM, Krzysztof Kozlowski wrote:
> On 26/10/2022 15:05, Melody Olvera wrote:
>> Add compatibles for scm driver for QDU1000 and QRU1000 platforms.
>>
>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>> ---
>>  .../devicetree/bindings/firmware/qcom,scm.yaml    | 15 +++++++++++++++
>>  1 file changed, 15 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> index be1b5746eddb..5352181aa393 100644
>> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> @@ -38,6 +38,7 @@ properties:
>>            - qcom,scm-msm8994
>>            - qcom,scm-msm8996
>>            - qcom,scm-msm8998
>> +          - qcom,scm-qdu1000
>>            - qcom,scm-sc7180
>>            - qcom,scm-sc7280
>>            - qcom,scm-sc8280xp
>> @@ -81,6 +82,20 @@ properties:
>>      description: TCSR hardware block
>>  
>>  allOf:
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            const: qcom,scm-qdu1000
>> +    then:
>> +      properties:
>> +        '#reset-cells':
>> +          maxItems: 1
> This is wrong... how can you have here more items?

Being removed anyways.

>
>> +        clocks: false
>> +        clock-names: false
>> +
>> +      required:
>> +        - '#reset-cells'
> Missing blank line.

Ack.

Thanks,
Melody
>
>>    - if:
>>        properties:
>>          compatible:
> Best regards,
> Krzysztof
>